Re: [Tsv-art] Tsvart last call review of draft-ietf-dprive-rfc7626-bis-03

"Brian Trammell (IETF)" <ietf@trammell.ch> Wed, 18 December 2019 16:57 UTC

Return-Path: <ietf@trammell.ch>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C46001208F3; Wed, 18 Dec 2019 08:57:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uNJbaiVt8Qpf; Wed, 18 Dec 2019 08:57:21 -0800 (PST)
Received: from smtp-sh.infomaniak.ch (smtp-sh.infomaniak.ch [128.65.195.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D9522120874; Wed, 18 Dec 2019 08:57:20 -0800 (PST)
Received: from smtp-3-0000.mail.infomaniak.ch ([10.4.36.107]) by smtp-sh.infomaniak.ch (8.14.5/8.14.5) with ESMTP id xBIGvH88013839 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 18 Dec 2019 17:57:18 +0100
Received: from [IPv6:2a02:169:17b2::b9f0:e4b1:7253:9c1a] (unknown [IPV6:2a02:169:17b2:0:b9f0:e4b1:7253:9c1a]) by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 9D593101BDA7A; Wed, 18 Dec 2019 17:57:17 +0100 (CET)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
From: "Brian Trammell (IETF)" <ietf@trammell.ch>
In-Reply-To: <2E3DE6EC-E79F-49B9-8BD2-2B016899F7B1@sinodun.com>
Date: Wed, 18 Dec 2019 17:57:17 +0100
Cc: tsv-art@ietf.org, dns-privacy@ietf.org, draft-ietf-dprive-rfc7626-bis.all@ietf.org, last-call@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <31C1D6C5-83F3-41A3-A122-55B2006DB342@trammell.ch>
References: <157497318519.5479.6114640755702328077@ietfa.amsl.com> <2E3DE6EC-E79F-49B9-8BD2-2B016899F7B1@sinodun.com>
To: Sara Dickinson <sara@sinodun.com>
X-Mailer: Apple Mail (2.3445.104.11)
X-Antivirus: Dr.Web (R) for Unix mail servers drweb plugin ver.6.0.2.8
X-Antivirus-Code: 0x100000
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/grGstCxR0XaQMkJgz3INDgmqFBM>
Subject: Re: [Tsv-art] Tsvart last call review of draft-ietf-dprive-rfc7626-bis-03
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Dec 2019 16:57:25 -0000

hi Sara, all,

> On 18 Dec 2019, at 14:43, Sara Dickinson <sara@sinodun.com> wrote:
> 
>> 
>> On 28 Nov 2019, at 20:33, Brian Trammell via Datatracker <noreply@ietf.org> wrote:
>> 
>> Reviewer: Brian Trammell
>> Review result: Ready with Nits
> 
> Brian, 
> 
> Thanks for the review!
> 
>> 
>> This document has been reviewed as part of the transport area review team's
>> ongoing effort to review key IETF documents. These comments were written
>> primarily for the transport area directors, but are copied to the document's
>> authors and WG to allow them to address any issues raised and also to the IETF
>> discussion list for information.
>> 
>> When done at the time of IETF Last Call, the authors should consider this
>> review as part of the last-call comments they receive. Please always CC
>> tsv-art@ietf.org if you reply to or forward this review.
>> 
>> This draft is ready for publication from a transport point of view. I have
>> minor nits / suggestions:
>> 
>> (1) References to QUIC imply that work is underway to build DNS over QUIC;
>> while this has been suggested, there is to my knowledge no ongoing
>> specification or implementation of such an application. There should be some
>> additional text pointing out this context where QUIC is first mentioned.
> 
> A specification for DNS-over-QUIC was actually started in April 2017 and is still active:
> https://datatracker.ietf.org/doc/draft-huitema-quic-dnsoquic/
> but is, of course, somewhat held up because version 1.0 of QUIC will only support HTTP. I thought there was a reference to this but you are correct - it isn’t in there! I will add it in the introduction immediately after the referance to I-D.ietf-quic-transport.

Great.

> FYI - I am aware of work on a prototype implementation on and off since then and there was experimental work to implement it in a DNS benchmarking tool at the IETF 105 hackathon: https://github.com/DNS-OARC/flamethrower/tree/dns-over-quic
> 
> 
>> 
>> (2) The references have some typos (e.g. [pitfalls-of-dns-encrption]) and are
>> occasionally oddly named (e.g. [firefox] for a Mozilla announcement about DoH);
>> suggest reviewing these.
> 
> Suggest (if these references remain):
> 
> [chrome] -> [chrome-doh-experiment] (article is titled “"Experimenting with same-provider DNS-over-HTTPS upgrade”)
> [firefox] -> [mozilla-doh-as-default]  (article is titled “What's next in making Encrypted DNS-over- HTTPS the Default”
> [pitfalls-of-dns-encrption] -> [pitfalls-of-dns-encryption]

These are all good, thanks!

Cheers,

Brian

> The rest look OK (I think) or have the same names as in the original RFC....
> 
> Sara.
> 
> 
> _______________________________________________
> Tsv-art mailing list
> Tsv-art@ietf.org
> https://www.ietf.org/mailman/listinfo/tsv-art