Re: [Tsv-art] [Last-Call] Tsvart last call review of draft-ietf-sfc-nsh-integrity-06

Joe Touch <touch@strayalpha.com> Thu, 29 July 2021 04:41 UTC

Return-Path: <touch@strayalpha.com>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 753F63A0BB6; Wed, 28 Jul 2021 21:41:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.086
X-Spam-Level:
X-Spam-Status: No, score=-2.086 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MIME_QP_LONG_LINE=0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=strayalpha.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CQ6lpeM8_sCD; Wed, 28 Jul 2021 21:41:14 -0700 (PDT)
Received: from server217-3.web-hosting.com (server217-3.web-hosting.com [198.54.115.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2381F3A0BCD; Wed, 28 Jul 2021 21:41:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=strayalpha.com; s=default; h=To:References:Message-Id:Cc:Date:In-Reply-To: From:Subject:Mime-Version:Content-Transfer-Encoding:Content-Type:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ksqny8F8YK7tfPIQ47rRILUnQhD+SjTxi00jBCCT+5U=; b=UWYfXCjHsWGqv0X8YByOBWqxQg NjGu+djIDuZO4jZ+6umR0wsAph0uDbUQGSLTMGgiepJB3norqFq8BuVzsF+8nAUF+SNSku6xGhJET tHrOzbL3izfYsVx/66rA1jnpds5phPpeLNx4y7Yx+fTNaQzPl9vGLDGoDkpOsgtJBI/0LuQckLmBr 3ENATifnsRtPdDwiV1kzgk/T0q/YF+gCF+uJ9U/dLJm/xPWsDBPmo8oCLIjG3vO2I+b6AaiIA64IJ 8Er+92sBo7NE4ziC/4I430JaUb3npN/zd1UBwgGhgcyfRy0B6eU4v9hSfzEothqX/yucWWJ+LbAGZ yUtN82Nw==;
Received: from cpe-172-114-237-88.socal.res.rr.com ([172.114.237.88]:64853 helo=smtpclient.apple) by server217.web-hosting.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <touch@strayalpha.com>) id 1m8xr1-001NBr-Ch; Thu, 29 Jul 2021 00:41:12 -0400
Content-Type: multipart/alternative; boundary=Apple-Mail-43B50022-F870-4A03-86D1-6D43CC45DE89
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (1.0)
From: Joe Touch <touch@strayalpha.com>
In-Reply-To: <CAFpG3gdRLTQvuoaEeRAhDUAqD3yBQ0jdBpZJzSvrJVPN-bMKTg@mail.gmail.com>
Date: Wed, 28 Jul 2021 21:41:06 -0700
Cc: tsv-art@ietf.org, draft-ietf-sfc-nsh-integrity.all@ietf.org, sfc@ietf.org, last-call@ietf.org
Message-Id: <FA6B54B4-28FA-4C19-AB37-66B54B22E53E@strayalpha.com>
References: <CAFpG3gdRLTQvuoaEeRAhDUAqD3yBQ0jdBpZJzSvrJVPN-bMKTg@mail.gmail.com>
To: tirumal reddy <kondtir@gmail.com>
X-Mailer: iPad Mail (18G82)
X-OutGoing-Spam-Status: No, score=-0.5
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - server217.web-hosting.com
X-AntiAbuse: Original Domain - ietf.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - strayalpha.com
X-Get-Message-Sender-Via: server217.web-hosting.com: authenticated_id: touch@strayalpha.com
X-Authenticated-Sender: server217.web-hosting.com: touch@strayalpha.com
X-Source:
X-Source-Args:
X-Source-Dir:
X-From-Rewrite: unmodified, already matched
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/i4x5aFv6Eeg8BWOmZpI_71tv2ts>
Subject: Re: [Tsv-art] [Last-Call] Tsvart last call review of draft-ietf-sfc-nsh-integrity-06
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2021 04:41:21 -0000

Insufficient.

> On Jul 28, 2021, at 7:09 AM, tirumal reddy <kondtir@gmail.com> wrote:
> 
> 
> Thanks Joseph for the detailed comment and explanation. We plan to add the following text to address the issue:
> 
> Note that the term “transport encapsulation” used in this document is equivalent to the term “tunnel encapsulation” used In [ietf-intarea-tunnel]. 
> 
> Cheers,
> -Tiru
> 
>> On Mon, 26 Jul 2021 at 10:34, Joseph Touch via Datatracker <noreply@ietf.org> wrote:
>> Reviewer: Joseph Touch
>> Review result: Not Ready
>> 
>> This document has been reviewed as part of the transport area review team's
>> ongoing effort to review key IETF documents. These comments were written
>> primarily for the transport area directors, but are copied to the document's
>> authors and WG to allow them to address any issues raised and also to the IETF
>> discussion list for information.
>> 
>> When done at the time of IETF Last Call, the authors should consider this
>> review as part of the last-call comments they receive. Please always CC
>> tsv-art@ietf.org if you reply to or forward this review.
>> 
>> It was very difficult to review this document for IETF transport protocol
>> considerations.
>> 
>> Although "transport encapsulation" is indicated repeatedly, it is never
>> referred to directly or described either in this document or its citations. It
>> appears to be using this term in the sense of RFC8300, which too never defines
>> it, but uses examples that are more accurately referred to in the IETF as link
>> layer protocols or either network or link tunnel protocols (IP in IP, GRE,
>> VXLAN, Ethernet).
>> 
>> Regardless of the fact that this confusion originates in RFC8300, it needs to
>> be addressed here and corrected before this document can be reviewed to
>> determine if there are any IETF transport area issues.
>> 
>> The remainder of these notes provide detail of this issue.
>> 
>> -----
>> 
>> The document refers back to RFC8300 to define the NSH itself; that document
>> discusses transport issues just as vaguely (never mentioning a particular
>> transport protocol), and when it discusses fragmentation, it refers to section
>> 9 of a document (draft-ietf-rtgwg-dt-encap-02 from 2017) that had expired prior
>> to the publication of RFC8300.  Because transport fragmentation is, IMO, a
>> normative issue, this should not have been permitted.
>> 
>> Further, Section 9 of that draft incorrectly recommends reliance on ICMP
>> feedback to address MTU failures when not under a single operator’s management.
>> That was widely known even then to be insufficient due to blackholing; this had
>> motivated PLPMTUD in RFC4821 a full decade earlier. RFC8300 compounds this
>> error by simply asserting that the operator should ensure that ICMPs are not
>> blocked, overlooking the need to address when this is not the case.
>> 
>> This document cannot ignore that issue and simply refer to RFC8300 on this
>> issue.
>> 
>> Note that one of the only places an actual encapsulation protocol is mentioned
>> is RFC8300, in which Section 5 mentions IP and  Section 6.1 Table 1 describes
>> VXLAN-GPE, GRE, and Ethernet – all of which are described as “transport
>> encapsulation”.
>> 
>> If, in fact, IETF transport protocols are being used, at some point the use of
>> an actual IETF transport protocol should be described (e.g., TCP, UDP, SCTP,
>> DCCP). At that point, the transport issues would be reviewable. As the document
>> currently stands, it completely ignores such transport issues and should not
>> proceed until this is addressed and re-reviewed.
>> 
>> If instead, as I suspect, the term “transport encapsulation” actually refers to
>> “network layer encapsulation” or “link layer encapsulation” and really implies
>> some sort of tunnel, there would be no transport area issues to review unless
>> that tunnel were to include a transport protocol as part of the layers of
>> encapsulation. If that is the case, the document should be revised to replace
>> the term “transport” with something that more accurately describes VXLAN-GPE,
>> GRE, Ethernet, and IP encapsulation using IETF terminology. Note that
>> draft-ietf-intarea-tunnels never uses the term “transport” except when
>> referring to the use of IETF transport protocols as a tunnel layer, e.g. (i.e.,
>> the last sentence of Sec 8 of this doc is incorrect in implying otherwise).
>> 
>> (I would also note that neither this doc nor RFC8300 define “transport
>> encapsulation” in their terminology; even if they would, they should not
>> attempt to define it in a way inconsistent with widespread use in the IETF).
>> 
>> 
>> 
> -- 
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call