[Tsv-art] TSV-ART review of draft-ietf-acme-acme-08

Martin Stiemerling <mls.ietf@gmail.com> Tue, 28 November 2017 10:38 UTC

Return-Path: <mls.ietf@gmail.com>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BAFF81200F3; Tue, 28 Nov 2017 02:38:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VpiOuuJZO4hG; Tue, 28 Nov 2017 02:38:23 -0800 (PST)
Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 52E70124BE8; Tue, 28 Nov 2017 02:38:23 -0800 (PST)
Received: by mail-wm0-x22b.google.com with SMTP id r68so797614wmr.3; Tue, 28 Nov 2017 02:38:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=pjGs+A205wWurz8xUPR2vRv9smUrsv4RRYHB1pMm0M8=; b=mVh5APJpOZx7P96vorPJ6ncgxJ332E+YQwr9q5Ji1/NqBU3Kiur90Xcva8q5WoK6Jp vwYujD7xVMTD02rOnA7OHmmLeaVwxQx3LeXjMwe2qwEe6KMXiIPQ6bq02O41g1vsY4KP 2HQ7MhYcPfCqFLreyYuJZSs3ZIdK5LKsJSOEdnh4gXHIQaC4cu8TGK0h352LiGa4F7sn AppNW5W+AltMiwrpt/GqxgXbWtuqFnFyRBaAKIoiYCXEGG0uwpKacQ8XxPbpwzQnqXPZ GC8FzxOTrVGiVEXEGIGtzZXgy21V7V5oFbbQkrCzT2/5Iwc2KD6q/r7ftNYnUDgnB9Fu aVwQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=pjGs+A205wWurz8xUPR2vRv9smUrsv4RRYHB1pMm0M8=; b=VlhZ8WPP5H5dJCq2fDhwBo7R6UAVpGY7N0d08i7O3n0XzFjcYGPnONio3VbdDk4CxO cciXArdLhPmlox8eAsU8TNgOhfsEBPK/Kq37Mp/hQsD3+Z1Xplur4IhoH6LBeHwUdO1H t3JW7SAAZT+kTQQB3I3iFdto3sZoeRNabyjfpeBO6c4W/ZHc7Qia2Gfl48BdCFZ+ClPm FL1JoBkdhgKhQQynpL1RvpsH9x37JOn8LQjs9x+rONW+nid4YDmh1AmSyG0WdF54a3xt ATkK2ncdgLOdYweuCLTAfx2PEE+IYj82CKKCZBydoTgn+YsfSbPAXt3XBlbI9+HnH0bS aSBA==
X-Gm-Message-State: AJaThX5oyU27ldIvWxGcmxtM8XnDR+rvru672pfC8xL9EyP8eHDKB2PQ RXqpYJe5IVItS5GCAIkee1jfmQ==
X-Google-Smtp-Source: AGs4zMY0IwQhntI8dpTu0JJ2XMTzXICRdJCjdaPPpXUmeXaBGc/ZJeT6QcgfSEuhr1uTKbAwjyYJaA==
X-Received: by 10.80.215.158 with SMTP id w30mr1946414edi.81.1511865501589; Tue, 28 Nov 2017 02:38:21 -0800 (PST)
Received: from ?IPv6:2003:74:cf3f:7155:88c:94fb:c791:d5c7? (p2003000653148A55088C94FBC791D5C7.dip0.t-ipconnect.de. [2003:6:5314:8a55:88c:94fb:c791:d5c7]) by smtp.googlemail.com with ESMTPSA id g3sm17378119edi.66.2017.11.28.02.38.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Nov 2017 02:38:20 -0800 (PST)
From: Martin Stiemerling <mls.ietf@gmail.com>
To: acme@ietf.org
Cc: tsv-art@ietf.org
Message-ID: <d73e832a-c7b3-7ae7-5dba-5cdfa75e8619@gmail.com>
Date: Tue, 28 Nov 2017 11:38:19 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/qyt1PXOrSdzDlGaSPbp-p2x8Ivc>
Subject: [Tsv-art] TSV-ART review of draft-ietf-acme-acme-08
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Nov 2017 10:38:30 -0000

Hi all,

I've reviewed this document as part of the transport area review team's 
ongoing effort to review key IETF documents. These comments were written 
primarily for the transport area directors, but are copied to the 
document's authors for their information and to allow them to address 
any issues raised. When done at the time of IETF Last Call, the authors 
should consider this review together with any other last-call comments 
they receive. Please always CC tsv-art@… if you reply to or forward this 
review.

Summary:
This draft is basically ready for publication, but has nits that should 
be fixed before publication.

Editorials:
- Abstract says "DISCLAIMER:...":
This should be removed before publication or there is an issue with the 
intended status of Standards Track.

- A nit, but: section 7.3.4 uses http instead of https in the example:
"instance": "http://example.com/agreement/?token=W8Ih3PswD-8"
All other instances use https.


Technicals:

- Section 8.2. Retrying challenges
Any guidance on what "some times" means? At least in terms of a time 
scale, e.g., seconds, minutes, hours?


Thanks for the clearly written document!

Regards,

   Martin Stiemerling