[Tsv-art] Tsvart last call review of draft-ietf-pce-pcep-flowspec-09

Joseph Touch via Datatracker <noreply@ietf.org> Sat, 04 July 2020 02:20 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: tsv-art@ietf.org
Delivered-To: tsv-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 59F6E3A0A2A; Fri, 3 Jul 2020 19:20:51 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Joseph Touch via Datatracker <noreply@ietf.org>
To: <tsv-art@ietf.org>
Cc: draft-ietf-pce-pcep-flowspec.all@ietf.org, last-call@ietf.org, pce@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.7.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <159382925133.13370.16692501581037089439@ietfa.amsl.com>
Reply-To: Joseph Touch <touch@strayalpha.com>
Date: Fri, 03 Jul 2020 19:20:51 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/x7unr4zvy5MhTXdf8ClSHA9IfO4>
Subject: [Tsv-art] Tsvart last call review of draft-ietf-pce-pcep-flowspec-09
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Jul 2020 02:20:52 -0000

Reviewer: Joseph Touch
Review result: Ready with Nits

This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
tsv-art@ietf.org if you reply to or forward this review.

Overall, the document has no direct transport issues.

There are potential issues in coupled documents, notably in
draft-ietf-idr-rfc5575bis. Section 4.2.2.4 of that other document indicates
three issues of concern: 1) inability to handle transport protocols other than
TCP and UDP (e.g., SCTP or DCCP), 2) inability to handle any but initial
fragments, and 3) the omission of addressing MTU issues in the associated
tunnels. Presumably those will be addressed when that document is reviewed more
thoroughly.

Nits:

I would encourage a revision of the abstract to focus on this document and its
contributions, particularly as a single paragraph. The abstract of this
document buries the lede; the final sentence would be usefully moved to the
front and supporting material explaining context can be moved into the intro or
a background section. The abstract could more usefully provide a summary of the
actual contents of this document instead, e.g., from paragraph 7 of the
introduction.

The introduction has similar issues; the document itself is not discussed until
the 6th paragraph. Again, it would be useful to focus on this document and
address the relation of its contents to other documents and the overall PCE
architecture in a background section separately.

It also seems odd that this paragraph (#6 of the intro) undermines the
terminology of the document that this supplements (as cited in the abstract).
These documents as a pair should have consistent use of terminology, coining
new terms as needed rather than redefining a key term as different in the two.