Re: [tsvwg] Linux DCTCP response to loss (was: L4S and the RACK requirement)

Bob Briscoe <ietf@bobbriscoe.net> Sat, 23 February 2019 17:58 UTC

Return-Path: <ietf@bobbriscoe.net>
X-Original-To: tsvwg@ietfa.amsl.com
Delivered-To: tsvwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 43266130DC8 for <tsvwg@ietfa.amsl.com>; Sat, 23 Feb 2019 09:58:28 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=bobbriscoe.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7TMfVX2D6qag for <tsvwg@ietfa.amsl.com>; Sat, 23 Feb 2019 09:58:25 -0800 (PST)
Received: from server.dnsblock1.com (server.dnsblock1.com [85.13.236.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4279E12F19D for <tsvwg@ietf.org>; Sat, 23 Feb 2019 09:58:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=bobbriscoe.net; s=default; h=Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1I4+ZyF1QXak58GxGAlch/12ivhbF/5oZ0vqvJRzlQI=; b=H49DTT5tXu4ubxGqKi9lHvPEE V6sfIop1yVWsGjo4Qu9Ec3UtLsMcZvnUw/LUmMkjvQPmSiQ7/G7Ifh/k3kyY+KdZLQLiJvcKo8Enf l7+HGlRvAIWB8ls7GUCJSOg8mMGA+3aJ4Eky4NbBP6ef4Ihm/RSWIrHxz5jvttIB8bvlRid5Ulm/F yN71QOqbwPozsALhpZFXLhVia2pTa3jblAIST4lyMsvnxrS8Lo5gX9IqQ72zDd9134dJ1EuVW+n99 pqJKxjtxcrk96+VkHDOIs6iQweK83IugrRUYRnl9iUWZhH99kj+GpPaeX8RzblCK9RMzov/EOefw/ 2T7YWv9hg==;
Received: from 40.0.208.46.dyn.plus.net ([46.208.0.40]:33358 helo=[192.168.0.5]) by server.dnsblock1.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from <ietf@bobbriscoe.net>) id 1gxbZ3-00030I-JX; Sat, 23 Feb 2019 17:58:17 +0000
To: Yuchung Cheng <ycheng@google.com>, "De Schepper, Koen (Koen)" <koen.de_schepper@nokia.com>, "Tilmans, Olivier (Nokia - BE/Antwerp)" <olivier.tilmans@nokia-bell-labs.com>
Cc: "Scheffenegger, Richard" <rs.ietf@gmx.at>, "Black, David" <David.Black@dell.com>, "tsvwg@ietf.org" <tsvwg@ietf.org>, Neal Cardwell <ncardwell@google.com>
References: <fb6d2979-a6a4-b122-a90e-4a0732ee89fa@mti-systems.com> <CAK6E8=chZjxNd6RFx-dfPU1jbbjmsW0DcDeGSTpLkWo3f=9k2Q@mail.gmail.com> <CE03DB3D7B45C245BCA0D2432779493630439583@MX307CL04.corp.emc.com> <CAK6E8=cdDmFmTB8-BjFeHvVL9JeDAW9TJyhaKBJmpZMy4ff-YQ@mail.gmail.com> <CE03DB3D7B45C245BCA0D243277949363043EF3B@MX307CL04.corp.emc.com> <50e27fa2-750b-5602-ceab-c48274c854e0@gmx.at> <fc617ea4-000a-805d-9453-57f0d5c930a3@bobbriscoe.net> <CAK6E8=fLFufEH07x+zFXDkSHPSosC6T5XuMbrsUZ8hta=gW0rg@mail.gmail.com>
From: Bob Briscoe <ietf@bobbriscoe.net>
Message-ID: <7892f8b6-5032-42d9-18b7-29995c14cde1@bobbriscoe.net>
Date: Sat, 23 Feb 2019 17:58:16 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <CAK6E8=fLFufEH07x+zFXDkSHPSosC6T5XuMbrsUZ8hta=gW0rg@mail.gmail.com>
Content-Type: multipart/alternative; boundary="------------796E997D2BC0740AC164E9FA"
Content-Language: en-GB
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - server.dnsblock1.com
X-AntiAbuse: Original Domain - ietf.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - bobbriscoe.net
X-Get-Message-Sender-Via: server.dnsblock1.com: authenticated_id: in@bobbriscoe.net
X-Authenticated-Sender: server.dnsblock1.com: in@bobbriscoe.net
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsvwg/5kvHROu0eRwQe3TlcEno-XKycIE>
Subject: Re: [tsvwg] Linux DCTCP response to loss (was: L4S and the RACK requirement)
X-BeenThere: tsvwg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Working Group <tsvwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsvwg/>
List-Post: <mailto:tsvwg@ietf.org>
List-Help: <mailto:tsvwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Feb 2019 17:58:28 -0000

Yuchung, [also adding Olivier who was about to try to repost Koen's 
patch to Linux netdev]


I'm saying the Linux implementation of DCTCP RFC has a bug (not a design 
issue).
[So this fork of the thread probably ought to move to a more appropriate 
list, given it's Linux-specific.]

I wasn't aware of any problem with Koen's patch reducing by 75% instead 
of 50%.
https://www.spinics.net/lists/netdev/msg420916.html
Are you saying you've tried the patch and it reduces by 75%, or you've 
looked at the code and you think it will reduce by 75%?


Bob


On 22/02/2019 18:15, Yuchung Cheng wrote:
>> For instance "MUST react to packet loss in a way that will coexist safely with a TCP Reno" is a safety requirement. So a DCTCP that does not satisfy this requirement cannot safely be used on the Internet For instance, Windows DCTCP is safe on the public Internet, but current mainline Linux DCTCP is not because there's bug where it intends to fall back to Reno - here's Koen's patch from 2yrs ago.
> how so? I believe Linux DCTCP correctly implements
> https://tools.ietf.org/html/rfc8257#section-3.5
>
> AFAIK Koen's patch makes DCTCP reduces cwnd by 75% (instead of 50%)
> when a loss happens w/o any prior CE marks (in a round trip).
>
> Could you identify which case you're referring to
> 1) DCTCP RFC has a design issue
> 2) Linux implementation of DCTCP RFC has a bug
>
>

-- 
________________________________________________________________
Bob Briscoe                               http://bobbriscoe.net/