Re: [tsvwg] Yangdoctors early review of draft-ietf-tsvwg-natsupp-16

Michael Tuexen <tuexen@fh-muenster.de> Thu, 02 April 2020 14:56 UTC

Return-Path: <tuexen@fh-muenster.de>
X-Original-To: tsvwg@ietfa.amsl.com
Delivered-To: tsvwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 21D033A1452; Thu, 2 Apr 2020 07:56:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.612
X-Spam-Level:
X-Spam-Status: No, score=-1.612 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, KHOP_HELO_FCRDNS=0.276, SPF_NONE=0.001, T_SPF_HELO_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rEwKZ2v6QFoE; Thu, 2 Apr 2020 07:55:59 -0700 (PDT)
Received: from drew.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D6AAF3A1446; Thu, 2 Apr 2020 07:55:58 -0700 (PDT)
Received: from [IPv6:2a02:8109:1140:c3d:1d0e:a873:57a5:414e] (unknown [IPv6:2a02:8109:1140:c3d:1d0e:a873:57a5:414e]) (Authenticated sender: macmic) by drew.franken.de (Postfix) with ESMTPSA id 2A12872230C0D; Thu, 2 Apr 2020 16:55:55 +0200 (CEST)
From: Michael Tuexen <tuexen@fh-muenster.de>
Message-Id: <BC802C91-E358-46ED-8940-312913171CCD@fh-muenster.de>
Content-Type: multipart/signed; boundary="Apple-Mail=_F63C4A3C-19FC-4D32-AD18-0B377ACB5572"; protocol="application/pkcs7-signature"; micalg=sha-256
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Date: Thu, 2 Apr 2020 16:55:54 +0200
In-Reply-To: <79697006-e8f3-07b8-592d-6fbf5a923d24@erg.abdn.ac.uk>
Cc: tsvwg@ietf.org, draft-ietf-tsvwg-natsupp.all@ietf.org
To: Gorry Fairhurst <gorry@erg.abdn.ac.uk>
References: <158583476117.26366.13230075547049117315@ietfa.amsl.com> <79697006-e8f3-07b8-592d-6fbf5a923d24@erg.abdn.ac.uk>
X-Mailer: Apple Mail (2.3608.80.23.2.2)
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsvwg/5nOVDjuEiDvtiOteYPpjFKhNT0o>
Subject: Re: [tsvwg] Yangdoctors early review of draft-ietf-tsvwg-natsupp-16
X-BeenThere: tsvwg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Working Group <tsvwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsvwg/>
List-Post: <mailto:tsvwg@ietf.org>
List-Help: <mailto:tsvwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Apr 2020 14:56:01 -0000

> On 2. Apr 2020, at 16:54, Gorry Fairhurst <gorry@erg.abdn.ac.uk> wrote:
> 
> Editors, could you please correct this in the revision.
Sure.

Best regards
Michael
> 
> Gorry
> 
> (TSVWG Document Shepherd)
> 
> On 02/04/2020 14:39, Radek Krejčí via Datatracker wrote:
>> Reviewer: Radek Krejčí
>> Review result: Ready with Nits
>> 
>> I have reviewed this document from a YANG model perspective only.
>> 
>> The document contains very simple YANG model ietf-nat-sctp augmenting ietf-nat
>> by a few values.
>> 
>> The module compiles by tools with no error or warning and the only note I have
>> is to the <CODE BEGINS> tag in the draft's text which misses filename for the
>> module, it should look like this:
>> 
>> <CODE BEGINS> file "ietf-nat-sctp@2019-11-18.yang"
>>