Re: [tsvwg] WGLC for DPLPMTUD - WGLC comments, still to be resolved.

G Fairhurst <gorry@erg.abdn.ac.uk> Fri, 20 December 2019 15:21 UTC

Return-Path: <gorry@erg.abdn.ac.uk>
X-Original-To: tsvwg@ietfa.amsl.com
Delivered-To: tsvwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 190161200A4 for <tsvwg@ietfa.amsl.com>; Fri, 20 Dec 2019 07:21:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F19tdRWkhZ3U for <tsvwg@ietfa.amsl.com>; Fri, 20 Dec 2019 07:20:59 -0800 (PST)
Received: from pegasus.erg.abdn.ac.uk (pegasus.erg.abdn.ac.uk [137.50.19.135]) by ietfa.amsl.com (Postfix) with ESMTP id D5C3E12009E for <tsvwg@ietf.org>; Fri, 20 Dec 2019 07:20:58 -0800 (PST)
Received: from G-MacBook.local (fgrpf.plus.com [212.159.18.54]) by pegasus.erg.abdn.ac.uk (Postfix) with ESMTPSA id 656E81B000A6; Fri, 20 Dec 2019 15:20:55 +0000 (GMT)
Message-ID: <5DFCE6D6.1090306@erg.abdn.ac.uk>
Date: Fri, 20 Dec 2019 15:20:54 +0000
From: G Fairhurst <gorry@erg.abdn.ac.uk>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: Maksim Proshin <maksim.proshin@mera.com>
CC: "tsvwg@ietf.org" <tsvwg@ietf.org>
References: <5b408f37-97aa-65d8-9a55-348aaddb2440@mti-systems.com> <2FD1B21B-E91F-4B92-8745-4FB6168EBDF8@erg.abdn.ac.uk> <b1bb816189c040599b02e4f0768cf336@mera.com>
In-Reply-To: <b1bb816189c040599b02e4f0768cf336@mera.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsvwg/eo2iKMDhiAk7kMTKxoiafNCThoc>
Subject: Re: [tsvwg] WGLC for DPLPMTUD - WGLC comments, still to be resolved.
X-BeenThere: tsvwg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Working Group <tsvwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsvwg/>
List-Post: <mailto:tsvwg@ietf.org>
List-Help: <mailto:tsvwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Dec 2019 15:21:00 -0000


Maxim, thanks again for all your comments. These comments below will 
require more help to resolve. Please help us discuss on the list, or 
help by offering some initial text proposals.

Best wishes,

Gorry

Major comments:

1.
RFC 4821 states that “an implementation SHOULD implement some form of 
MTU verification” and I don’t see how that aspect is addressed in 
DPLMTUD. Did I miss it or was it intentionally skipped?
GF: QUERY - I am unsure I understand the question - but maybe this 
relates to always probing a new PLPMTU before it is used - in which 
case, this is covered.

3.
Some PLs like SCTP can’t re-fragment data during retransmission which 
might lead to a problem if PMTU was decreased in run-time or the PLPMTU 
value was discovered wrongly. In some case the data would never be 
retransmitted. This aspect is not covered in the draft. I think it would 
be good at least to recommend to not set DF-bit for retransmitted data 
and to not fragment user data to pieces larger than BASE_PMTU (or even 
MIN_PMTU?).
GF: QUERY What does the WG think?

5.
Sec 3: “A method is REQUIRED to signal an appropriate MPS to the higher 
layer using the PL. ” – In general I don’t see how the draft addresses 
it. Is it up to the PL implementation or the PL specification? I assume 
it requires SCTP Socket API update. If so, is it out of scope of this doc?
GF: Should we specify this?

Minor comments:

6.
Im: The default value is specified for some parameters but not for all 
and without clear explanation of why such values are used as default. 
The same is for recommended values. Shouldn’t it be consistent?
GF : Which parameters do you mean?

9.
Mi: Sec 1.3. why don’t you refer to SCTP specification RFC4960 instead 
of or additionally to RFC4821. Section 7.3 of RFC4960 has a statement 
“An endpoint SHOULD apply these techniques, and SHOULD do so on a 
per-destination-address basis.” so for me it’s more relelvant to refer 
to RFC4960.
GF : Should this document update RFC4960?

17.
Im/Q: Sec 4.4: “MUST suspend” – I assume it’s valid in general even when 
PL is using the other PL like QUIC uses UDP. If so, it would be good to 
clarify.
GF: I did not understand what text to add.

25.
Im: Sec 6.2 (maybe general for Sec 6): It would be good to recommend to 
enable fragmentation (do not set DF bit) for all packets except for 
probes or at least for retransmitted packets.
GF:  i understand and know this is done. in some SCTP implementations. 
What specific text is required?

26.
Im/Q: Sec 6.2: Should or should not probe packets influence assoc and 
path error counters? I think it’s “SHOULD” when a probe is acknowledged 
and “SHOULD NOT” when it’s lost. In other words probes should only clear 
the error counters in my view.
GF: Is this correct below:
NEW:
  A successful probe updates the association and path
             counters, but an unsuccessful probe is discounted (assumed
             to be a result of choosing too large a PLPMTU).