Re: [tsvwg] Yangdoctors early review of draft-ietf-tsvwg-natsupp-16

Gorry Fairhurst <gorry@erg.abdn.ac.uk> Thu, 02 April 2020 14:54 UTC

Return-Path: <gorry@erg.abdn.ac.uk>
X-Original-To: tsvwg@ietfa.amsl.com
Delivered-To: tsvwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3D1E3A1495; Thu, 2 Apr 2020 07:54:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.877
X-Spam-Level:
X-Spam-Status: No, score=-0.877 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, MISSING_HEADERS=1.021, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0-_j80VWrnYA; Thu, 2 Apr 2020 07:54:58 -0700 (PDT)
Received: from pegasus.erg.abdn.ac.uk (pegasus.erg.abdn.ac.uk [IPv6:2001:630:42:150::2]) by ietfa.amsl.com (Postfix) with ESMTP id 728493A1072; Thu, 2 Apr 2020 07:54:50 -0700 (PDT)
Received: from GF-MacBook-Pro.local (fgrpf.plus.com [212.159.18.54]) by pegasus.erg.abdn.ac.uk (Postfix) with ESMTPSA id 2BC9D1B00151; Thu, 2 Apr 2020 15:54:47 +0100 (BST)
Cc: tsvwg@ietf.org, draft-ietf-tsvwg-natsupp.all@ietf.org
References: <158583476117.26366.13230075547049117315@ietfa.amsl.com>
From: Gorry Fairhurst <gorry@erg.abdn.ac.uk>
Message-ID: <79697006-e8f3-07b8-592d-6fbf5a923d24@erg.abdn.ac.uk>
Date: Thu, 2 Apr 2020 15:54:46 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <158583476117.26366.13230075547049117315@ietfa.amsl.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsvwg/ndoodZY-KNw86LPt0AsvEwgkAcs>
Subject: Re: [tsvwg] Yangdoctors early review of draft-ietf-tsvwg-natsupp-16
X-BeenThere: tsvwg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Working Group <tsvwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsvwg/>
List-Post: <mailto:tsvwg@ietf.org>
List-Help: <mailto:tsvwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Apr 2020 14:55:05 -0000

Editors, could you please correct this in the revision.

Gorry

(TSVWG Document Shepherd)

On 02/04/2020 14:39, Radek Krejčí via Datatracker wrote:
> Reviewer: Radek Krejčí
> Review result: Ready with Nits
>
> I have reviewed this document from a YANG model perspective only.
>
> The document contains very simple YANG model ietf-nat-sctp augmenting ietf-nat
> by a few values.
>
> The module compiles by tools with no error or warning and the only note I have
> is to the <CODE BEGINS> tag in the draft's text which misses filename for the
> module, it should look like this:
>
> <CODE BEGINS> file "ietf-nat-sctp@2019-11-18.yang"
>