Re: [Unbearable] Ben Campbell's Yes on draft-ietf-tokbind-negotiation-12: (with COMMENT)

Andrei Popov <Andrei.Popov@microsoft.com> Wed, 09 May 2018 21:50 UTC

Return-Path: <Andrei.Popov@microsoft.com>
X-Original-To: unbearable@ietfa.amsl.com
Delivered-To: unbearable@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F3D6212DB6E; Wed, 9 May 2018 14:50:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.011
X-Spam-Level:
X-Spam-Status: No, score=-2.011 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=microsoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YptIK9SR6PGT; Wed, 9 May 2018 14:50:36 -0700 (PDT)
Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0714.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe49::714]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 44D1C129C6B; Wed, 9 May 2018 14:50:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zPV2ceKLatG5bfkcNG0IaMn1idTAJ+tmidEMhaaeMJ8=; b=b3GlPbXoAfAMPwh9bunNprf5DTedxA65WFlWluYsgjQYbdsjvjMhb0ASwRbBemHdGa7TSq+gf+1kPGpyv6tCkXB4adl7hp+V74zIvSm9+W/etCKr1SJestUQD4sAWqTVT7sQ19G/E7fIpPtG8m8aQawJdiAj9L6oj3m3BOKz3Gw=
Received: from DM5PR21MB0507.namprd21.prod.outlook.com (10.172.91.141) by DM5PR21MB0745.namprd21.prod.outlook.com (10.173.172.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.776.4; Wed, 9 May 2018 21:50:34 +0000
Received: from DM5PR21MB0507.namprd21.prod.outlook.com ([fe80::49e8:420f:baa2:a62f]) by DM5PR21MB0507.namprd21.prod.outlook.com ([fe80::49e8:420f:baa2:a62f%6]) with mapi id 15.20.0776.004; Wed, 9 May 2018 21:50:34 +0000
From: Andrei Popov <Andrei.Popov@microsoft.com>
To: Ben Campbell <ben@nostrum.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-tokbind-negotiation@ietf.org" <draft-ietf-tokbind-negotiation@ietf.org>, John Bradley <ve7jtb@ve7jtb.com>, "tokbind-chairs@ietf.org" <tokbind-chairs@ietf.org>, "ve7jtb@ve7jtb.com" <ve7jtb@ve7jtb.com>, "unbearable@ietf.org" <unbearable@ietf.org>
Thread-Topic: Ben Campbell's Yes on draft-ietf-tokbind-negotiation-12: (with COMMENT)
Thread-Index: AQHT59EiwpQ8z5zuzESbJ1S4FE6uo6Qn7rSQ
Date: Wed, 9 May 2018 21:50:34 +0000
Message-ID: <DM5PR21MB0507D89084BCFF1A8BCC19C48C990@DM5PR21MB0507.namprd21.prod.outlook.com>
References: <152589634849.4060.1233669853296271255.idtracker@ietfa.amsl.com>
In-Reply-To: <152589634849.4060.1233669853296271255.idtracker@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [2001:4898:80e8:c::4ca]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; DM5PR21MB0745; 7:TGbAWZyCqvgmbWXu/iucMgbTWjWlRvIAA3+uyOr0WSaOxIwojCyjgtkvH9ANwX1BaIi8qghOLwVjTCtEb8yqtU1oes9Chqbmz4XMD46cl2AU7otAaAzvJrhSE7QFWW44jc06pl841Hq8l5NsUbPg4MzV5tvT+6GxQiu+lnbW1MUoD08290wUkjOfkCANu+ssOomFpDrXQ+I0YypOsQ8LWj1/+QmevVwQRXHa86FPBTROlgtwFPgxRFt5Vsyk7/Lh; 20:Bp09UbGrNToLkBa0RTwVFKhuGAgblf0Nway4krvwObyhg8U+Y3UJaEyaaR8ODotLQVjXRbKJ+Zlrmei+bX//ASMWPACkAtv5i29d5sVA2mNjFelfMCPBqayFtOL12ZXYIbwIJ1q3pE//zrHNuHkxpfegTdpA5ML8beiIMYFKTtQ=
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR21MB0745;
x-ms-traffictypediagnostic: DM5PR21MB0745:
x-microsoft-antispam-prvs: <DM5PR21MB074510B4CD23C1013EA39E968C990@DM5PR21MB0745.namprd21.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(158342451672863)(189930954265078)(219752817060721);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231254)(2018427008)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:DM5PR21MB0745; BCL:0; PCL:0; RULEID:; SRVR:DM5PR21MB0745;
x-forefront-prvs: 0667289FF8
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(366004)(396003)(346002)(39380400002)(39860400002)(13464003)(189003)(199004)(51914003)(3280700002)(55016002)(76176011)(9686003)(6246003)(2906002)(486006)(68736007)(46003)(14454004)(476003)(99286004)(3660700001)(8990500004)(5250100002)(97736004)(446003)(74316002)(7696005)(53936002)(11346002)(86612001)(2900100001)(6116002)(6306002)(86362001)(305945005)(7736002)(6436002)(5660300001)(186003)(6346003)(33656002)(229853002)(81166006)(6506007)(8676002)(8936002)(54906003)(478600001)(110136005)(105586002)(316002)(72206003)(22452003)(10090500001)(10290500003)(25786009)(966005)(102836004)(53546011)(106356001)(81156014)(4326008); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR21MB0745; H:DM5PR21MB0507.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=Andrei.Popov@microsoft.com;
x-microsoft-antispam-message-info: yO99HX95W2PPDw7h3/0e8t13jLfNuC47SVy9C2JEfFTYOBAU/RcFQQq+/JDkKHL9XOnQ+c1AOsr4dn+rNa02WNt8atAVUiFDbL2i/wUMXolEomXS4yRLcDeanb6zXqc+7nc+ejaELpktRcfyyeHKH0Kh4b/2ZaIgR9RrjcU3TWL4PnKjjRr4w08j84jUJGZP
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 581f0220-5784-49bf-660e-08d5b5f6e4b2
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 581f0220-5784-49bf-660e-08d5b5f6e4b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2018 21:50:34.5121 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR21MB0745
Archived-At: <https://mailarchive.ietf.org/arch/msg/unbearable/zJtLtNSKBD1yCKLliDLPfGhfd7c>
Subject: Re: [Unbearable] Ben Campbell's Yes on draft-ietf-tokbind-negotiation-12: (with COMMENT)
X-BeenThere: unbearable@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "\"This list is for discussion of proposals for doing better than bearer tokens \(e.g. HTTP cookies, OAuth tokens etc.\) for web applications. The specific goal is chartering a WG focused on preventing security token export and replay attacks.\"" <unbearable.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/unbearable>, <mailto:unbearable-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/unbearable/>
List-Post: <mailto:unbearable@ietf.org>
List-Help: <mailto:unbearable-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/unbearable>, <mailto:unbearable-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 May 2018 21:50:39 -0000

Hi Ben,

Thanks for the review; some answers below.
> Additionally, do I understand the version negotiation to require the client to support all previous version from the one it initially advertises?
No, the draft says specifically:
" There is no requirement for the client to support any Token
   Binding versions other than the one advertised in the client's
   "token_binding" extension."

> §1.1: Please consider using the 8174 boilerplate across the cluster. While I did not find lower case keywords in this draft, I did in the other two and it would be best to be consistent across all three.
Will make this change in the next revision.

> §2: "[I-D.ietf-tokbind-protocol] describes version {1, 0} of the protocol.":
> While one might infer that version to be {1,0} give the name "Token Binding 1.0", I never saw it explicitly mentioned.
Sorry, I did not understand the concern. Can you elaborate?

Thanks,

Andrei

-----Original Message-----
From: Ben Campbell <ben@nostrum.com> 
Sent: Wednesday, May 9, 2018 1:06 PM
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-tokbind-negotiation@ietf.org; John Bradley <ve7jtb@ve7jtb.com>om>; tokbind-chairs@ietf.org; ve7jtb@ve7jtb.com; unbearable@ietf.org
Subject: Ben Campbell's Yes on draft-ietf-tokbind-negotiation-12: (with COMMENT)

Ben Campbell has entered the following ballot position for
draft-ietf-tokbind-negotiation-12: Yes

When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)


Please refer to https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Fiesg%2Fstatement%2Fdiscuss-criteria.html&data=02%7C01%7CAndrei.Popov%40microsoft.com%7C3a1591db5ceb4c9f9e3508d5b5e842b3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636614931539696277&sdata=tz5MtEsJwqlG7QHQWgLVy6HMgX1xyLTqzmnFA7U9Gmc%3D&reserved=0
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracker.ietf.org%2Fdoc%2Fdraft-ietf-tokbind-negotiation%2F&data=02%7C01%7CAndrei.Popov%40microsoft.com%7C3a1591db5ceb4c9f9e3508d5b5e842b3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636614931539696277&sdata=JMexEpyWjrBwY5V2PvFVHCqaXtPlw7PaBRJK4Qk%2F5lc%3D&reserved=0



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Thanks for this document. I am balloting "yes", but have a few comments:

- I support Alexey's DISCUSS. Additionally, do I understand the version negotiation to require the client to support all previous version from the one it initially advertises? If so, how would you deprecate a version at some time in the future?

- I shared some of the confusion about this being limited to TLS 1.2 and earlier. In particular, there is repeating language that to the effect of "For TLS 1.2 and earlier...", which seems strange for a draft that only supports 1.2 in the first place.

§1.1: Please consider using the 8174 boilerplate across the cluster. While I did not find lower case keywords in this draft, I did in the other two and it would be best to be consistent across all three.

§2: "[I-D.ietf-tokbind-protocol] describes version {1, 0} of the protocol.":
While one might infer that version to be {1,0} give the name "Token Binding 1.0", I never saw it explicitly mentioned.

Editorial Comments:

§2: "Please note that the server MAY select any lower protocol version, see Section 3": comma splice