Re: [Unbearable] [Gen-art] Genart last call review of draft-ietf-tokbind-https-14

Alissa Cooper <alissa@cooperw.in> Wed, 09 May 2018 18:01 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: unbearable@ietfa.amsl.com
Delivered-To: unbearable@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 854FD12D967; Wed, 9 May 2018 11:01:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.8
X-Spam-Level:
X-Spam-Status: No, score=-0.8 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=q5tI6ZhX; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=CrfaMOJ5
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EBBXMoIPq_91; Wed, 9 May 2018 11:01:34 -0700 (PDT)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 713B912D969; Wed, 9 May 2018 11:01:34 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id AAF452280C; Wed, 9 May 2018 14:01:33 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 09 May 2018 14:01:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=+vAHPIre+GSpNMHd7xdfrmVxL3gzj7+++WxqdmAZNtc=; b=q5tI6ZhX TgjocwKP7kWsfxXh1FICi2+vAboReReWLaaXGLRa0YsFspAbp62VbOfVQC25iZbb oih8ix+zte8XZGNNCM5XH+Vmu7ac9uKQFXW0aH/WRBPlRN8lzKZczv7+/pVWtoTo ORCT8z5aPo+YgoWMUOEsHMkKWBiVY0iQUJ+rFTFjhLtMFy0vlkJh3dBZOuQx8s5t 7ljyUYDziJdPY7ubqeFbWynxHh8yvdC1OtR57kuR2omkEQg/Kvn/JtwKgXC0rWmS RfZxPA/49njJAoZWrwNUCWZJDnOaqL4KHgu8BNfFiyXCBe2PWKm/MtTtfsEIVtmr FpF/jV2PaNT20w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=+vAHPIre+GSpNMHd7xdfrmVxL3gzj 7+++WxqdmAZNtc=; b=CrfaMOJ54kjFq2IzVO/AqSxZb0pVF503oR0zVh8m7OLsu 6cuvKWbwMaiLPstGb+ycD2MTkL8TmKCT+/7LTkC6fEqrM1eUaPZsvALk76mO6XOt YoHYyMQ+vkYHx5dZ4bHsYNlBC3yNTdaYpAnnczwDQzZwBotn8N1X4fnbZUA0fkT0 6bxNqOdzkHBuskSrmz5JM/9jEe6zcfsy+GLaJmsor2mqdpQWsWBaN/CSd4vUL9Jx TpGYHl+VV755QSC7pXsutS+ZtkIG37G9WlcgX7o398gyYEnwItsgWufbOktbQEyO bMC5B2HyhtWz6zwnZKbfFZxKqOKtZtULkAQ2pxo+A==
X-ME-Sender: <xms:fTfzWuT4813AaIdPdFl8u6_FbebPlpJpQem3QGpBpkhH1hODmIG6Xg>
Received: from rtp-alcoop-nitro2.cisco.com (unknown [173.38.117.81]) by mail.messagingengine.com (Postfix) with ESMTPA id 0F50FE4076; Wed, 9 May 2018 14:01:33 -0400 (EDT)
Content-Type: multipart/alternative; boundary="Apple-Mail=_A288C79E-3724-49AF-B3AE-19735A4768E6"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <CADHfa2AHaAA_1hhMKOcHWO1KT17vDaF=ohpBCQnvyMHTQnbZ0g@mail.gmail.com>
Date: Wed, 09 May 2018 14:01:32 -0400
Cc: Linda.dunbar@huawei.com, IETF Gen-ART <gen-art@ietf.org>, draft-ietf-tokbind-https.all@ietf.org, Tokbind WG <unbearable@ietf.org>
Message-Id: <35FD9C36-926F-4465-AFBC-9B7D07313473@cooperw.in>
References: <152537970365.4463.14132908604998547675@ietfa.amsl.com> <CADHfa2AHaAA_1hhMKOcHWO1KT17vDaF=ohpBCQnvyMHTQnbZ0g@mail.gmail.com>
To: Dirk Balfanz <balfanz@google.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/unbearable/_ccr2ms3AiQoAqZvgFLmAwtimvU>
Subject: Re: [Unbearable] [Gen-art] Genart last call review of draft-ietf-tokbind-https-14
X-BeenThere: unbearable@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "\"This list is for discussion of proposals for doing better than bearer tokens \(e.g. HTTP cookies, OAuth tokens etc.\) for web applications. The specific goal is chartering a WG focused on preventing security token export and replay attacks.\"" <unbearable.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/unbearable>, <mailto:unbearable-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/unbearable/>
List-Post: <mailto:unbearable@ietf.org>
List-Help: <mailto:unbearable-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/unbearable>, <mailto:unbearable-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 May 2018 18:01:40 -0000

Linda, thanks for your review. Dirk, thanks for your response. Vary is defined in RFC 7231 I think, so it would be trivial to add a citation, but agree that it is not strictly necessary.

I have entered a DISCUSS ballot to chat about some issues in Sec 2.1.

Alissa

> On May 3, 2018, at 10:54 PM, Dirk Balfanz <balfanz@google.com> wrote:
> 
> The Vary response header refers to this HTTP header: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Vary <https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Vary> 
> 
> I think an additional definition/citation is unnecessary, as other basic concepts of HTTP are also left undefined/uncited in the spec..
> 
> Please let me know if that's not acceptable, and I'll look for a way to add a citation.
> 
> Thank,
> 
> Dirk.
> 
> 
> On Thu, May 3, 2018 at 1:35 PM Linda Dunbar <Linda.dunbar@huawei.com <mailto:Linda.dunbar@huawei.com>> wrote:
> Reviewer: Linda Dunbar
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>>.
> 
> Document: draft-ietf-tokbind-https-14
> Reviewer: Linda Dunbar
> Review Date: 2018-05-03
> IETF LC End Date: 2018-03-12
> IESG Telechat date: 2018-05-10
> 
> Summary:
> The document is written very clear, easy to understand,  and content is
> complete.
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits/editorial comments:
> 
> Section 2 Page 4:
> Question: is "Very response" a specific response in the following sentence?  If
> yes, need to provide the definition as  I don't see it being defined anywhere
>   "MAY be listed by a server in a Vary response header field,.."
> 
> thank you.
> 
> Linda dunbar
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art