Re: [Webpush] Kathleen Moriarty's No Objection on draft-ietf-webpush-vapid-03: (with COMMENT)

Martin Thomson <martin.thomson@gmail.com> Wed, 16 August 2017 01:11 UTC

Return-Path: <martin.thomson@gmail.com>
X-Original-To: webpush@ietfa.amsl.com
Delivered-To: webpush@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 727FF132076; Tue, 15 Aug 2017 18:11:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MkMkf3E-B3Bh; Tue, 15 Aug 2017 18:11:04 -0700 (PDT)
Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com [IPv6:2607:f8b0:4001:c06::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7E0661321F0; Tue, 15 Aug 2017 18:11:04 -0700 (PDT)
Received: by mail-io0-x22a.google.com with SMTP id g71so8635250ioe.5; Tue, 15 Aug 2017 18:11:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0opyc7/E762GRZSiARV/i6g4GLy0HVSPoHOBdM/7ejg=; b=NzuWJt+FuHD49Km2r2TNz+fxhH5H3KTmhsuZWMoai0sFOj6WQh29H2CVFooT+JBALn d9ZD5hxDtzHGZa58shdlwwDc08S9+OHHL9ZIAExEdLU/0+LVP9lRFSKg4WuhkpwMQHIl DcG9IwFByvj4CkJmpwSMb5QOr+cPT5v2aBZ2acNN2Lq95or8jcxt5YSsy1k+QqSVMQOB EBy2oVwa1YLtuBJZ/z6Vx8Wu81w/j9xHEARTf7ZOkFbu/0lZ8/KWfPV4IXvh9hZYZ1Wc Kmp0XugtZS+89MVd5/VrJs4qOeRiOHKsB6p4J6cIdGDAEA8kwhNRrzpAWcOxC6DFKB9D +OQg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0opyc7/E762GRZSiARV/i6g4GLy0HVSPoHOBdM/7ejg=; b=e8Wxyu+PU+ObgV4CwdwFJdyhhh5ttH501b2EfWkc2GD0m1Hdb6Rf5SHK5Ubqkv7mpX /oNZLioV8lQcjEqslxIcGZmTiTlvNKec39EHeMFYPKBAww8qaMMWTBcQQXYHo3gsmJtd avlL1duUrvia9bIba3QNCj92VPtYltIBjx/OGSW/KwsE/DXjNIqcqZEuFF6eRQFtWH+j lw1ze6QKIvSf66aKiwgcK+JZ21GQVB0XB2Hk5j6Y4FYTfyaVGybD80AIla6rLVV7Gqm4 5suqTXoIh2YJ7RcztULVz2MmWul324eZV5gqP7WtoVLd7hB/D+naRtaYNqKvgEsMZzGD xqDw==
X-Gm-Message-State: AHYfb5iQ2vEyPS339c94X8ZjHWr+MdhTQJj8b52xkKgcDJaU+/GxEQnd F1nKdn/6e9tTrS0n4TaQm2ZnTQNXRw==
X-Received: by 10.107.134.196 with SMTP id q65mr24601ioi.193.1502845863828; Tue, 15 Aug 2017 18:11:03 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.164.42 with HTTP; Tue, 15 Aug 2017 18:11:03 -0700 (PDT)
In-Reply-To: <150282302424.20984.16954614287039839165.idtracker@ietfa.amsl.com>
References: <150282302424.20984.16954614287039839165.idtracker@ietfa.amsl.com>
From: Martin Thomson <martin.thomson@gmail.com>
Date: Wed, 16 Aug 2017 11:11:03 +1000
Message-ID: <CABkgnnXotYcLeJyPcF97Den=-bEzoOv6WWjT3uQ=ELGA94DkNA@mail.gmail.com>
To: Kathleen Moriarty <Kathleen.Moriarty.ietf@gmail.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-webpush-vapid <draft-ietf-webpush-vapid@ietf.org>, Phil Sorber <sorber@apache.org>, webpush-chairs@ietf.org, "webpush@ietf.org" <webpush@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/webpush/DQY854UR0Yy5jt9amZybpiovpZ0>
Subject: Re: [Webpush] Kathleen Moriarty's No Objection on draft-ietf-webpush-vapid-03: (with COMMENT)
X-BeenThere: webpush@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Discussion of potential IETF work on a web push protocol <webpush.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/webpush>, <mailto:webpush-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/webpush/>
List-Post: <mailto:webpush@ietf.org>
List-Help: <mailto:webpush-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/webpush>, <mailto:webpush-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Aug 2017 01:11:06 -0000

On 16 August 2017 at 04:50, Kathleen Moriarty
<Kathleen.Moriarty.ietf@gmail.com>; wrote:
> In section 3, it seems that you are just signing the JWK and that seems fine
> from the text and the purpose listed - origin server authentication.
>
> Then in section 3.2, there's a reference to I-D.ietf-webpush-encryption saying,
> "An application server MUST select a different
>    private key for the key exchange".  This makes me think that encryption is
>    used as well, but I think it would be helpful to see the point made more
>    clear here or in the security considerations section.  Is confidentiality
>    provided/required or just integrity for this draft?

There are two separate mechanisms.  -encryption sends a message to the
user agent.  That message has confidentiality and integrity protection
- the push service can't see or modify that message.  In the envelope
of that message, we have this JWT.  The confidentiality/integrity
protection for that is HTTPS.  Confidentiality is required to prevent
theft of the token, as stated in the security considerations.  What I
now realize is that I didn't actually reiterate the requirement for
HTTPS from 8030.

  https://github.com/webpush-wg/webpush-vapid/pull/41

The text you cite is included specifically to maybe prevent someone
from incorrectly using the same key for signing (in -vapid) and
encryption (in -encryption).  Unfortunately, this specific type of
misuse is possible in a lot of codebases and does happen.