Re: [Webpush] Eric Rescorla's No Objection on draft-ietf-webpush-encryption-08: (with COMMENT)

Martin Thomson <martin.thomson@gmail.com> Wed, 16 August 2017 00:47 UTC

Return-Path: <martin.thomson@gmail.com>
X-Original-To: webpush@ietfa.amsl.com
Delivered-To: webpush@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B7196132409; Tue, 15 Aug 2017 17:47:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hKWQLQx59LH9; Tue, 15 Aug 2017 17:47:38 -0700 (PDT)
Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9659113226B; Tue, 15 Aug 2017 17:47:38 -0700 (PDT)
Received: by mail-io0-x230.google.com with SMTP id g71so8526667ioe.5; Tue, 15 Aug 2017 17:47:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9rB0Yd0Bcm98nnxtVpDjJN0YHR1N9n4XRAZDkE0+tFI=; b=S/OVX6E8U4YsXj/xuMFacfnYEScKeC5x2Y+dM8JL+ZxoOsQeLHArxC1ovBid29Qh5U FWZf+ro7OnriKuOPFs3FecU1+lC/fx2bl4nzSBMhd3CeoSwP7qwGZ7uVj3FkJMCi+rJn rQsJak5KlRU/J4mpfpbahZfdkk67she+3pRSkLqAP9dUDXATCUvb/O/59ss7Prc041Fw T39khVx4suoYM8Kpvd+wLcBz/O+PR5oGSNzW7yF90cH+hkpKJRLTI/+lZVyJyooXKyZm l8XtZUYahDgOGc/66J6gv1Ofo6fFlGBUK0Ci/Rjexzq9kUjzstUiGE9iw+/GOoYC9LHy ndsg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9rB0Yd0Bcm98nnxtVpDjJN0YHR1N9n4XRAZDkE0+tFI=; b=XqDJxyneTCSUWPbD4/e3JLqsvhDVJfkT9YsDxTTJH+BCKFhbqTYp4mkZ+y+pq62MYJ uG1nfua08g9E4aK0RMldLXBvEDyWXaOrfCKT8zHHZ4UEDaDsnn+3D2bX60sUTS9Q4woe 5MDZasW3vBXeUdPGChseySY72VR0QvzZE259x6bVs7vMwRIKgsqNPRdoq5a8uGgwGcZL LZxKEeGeSQ1tNKMPQ5gMudZV0ammgijvvwFazsP5ZOq2TuQFyZKRMdcCO+C3O5IWyeyp JvRI4nfKmBvwxHiNfG6TpR+1IxLGi4KzrVXfaGt9ZfJ6V+qXrWVS96gx9paQK3unQkkx R5FA==
X-Gm-Message-State: AIVw111vei0qg4GmcCdbI86RGflyxRIwrvu/2fyGKDk/Trha5ElVJRLm ec4LgQiDPtrguJsdEgy2Uu+BgIasJg==
X-Received: by 10.107.134.196 with SMTP id q65mr23493393ioi.193.1502844457821; Tue, 15 Aug 2017 17:47:37 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.164.42 with HTTP; Tue, 15 Aug 2017 17:47:37 -0700 (PDT)
In-Reply-To: <150284295232.12589.16313686807738978537.idtracker@ietfa.amsl.com>
References: <150284295232.12589.16313686807738978537.idtracker@ietfa.amsl.com>
From: Martin Thomson <martin.thomson@gmail.com>
Date: Wed, 16 Aug 2017 10:47:37 +1000
Message-ID: <CABkgnnWJmnjG+LEqgRoFyRvK_i53o7Ue+XQ8Hd=JuZ-qsZRehg@mail.gmail.com>
To: Eric Rescorla <ekr@rtfm.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-webpush-encryption@ietf.org, Phil Sorber <sorber@apache.org>, webpush-chairs@ietf.org, "webpush@ietf.org" <webpush@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/webpush/K_WmRAzZzxboFECH4lF0s82Ht5M>
Subject: Re: [Webpush] Eric Rescorla's No Objection on draft-ietf-webpush-encryption-08: (with COMMENT)
X-BeenThere: webpush@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Discussion of potential IETF work on a web push protocol <webpush.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/webpush>, <mailto:webpush-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/webpush/>
List-Post: <mailto:webpush@ietf.org>
List-Help: <mailto:webpush-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/webpush>, <mailto:webpush-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Aug 2017 00:47:41 -0000

Thanks ekr, your PR is here:

  https://github.com/webpush-wg/webpush-encryption/pull/20

I ripped off your text.

On 16 August 2017 at 10:22, Eric Rescorla <ekr@rtfm.com>; wrote:
> Eric Rescorla has entered the following ballot position for
> draft-ietf-webpush-encryption-08: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-webpush-encryption/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> Moving to No Objection because my DISCUSS is fixed in:
> https://github.com/webpush-wg/webpush-encryption/commit/645a04b3b86ffe10322134e27a3d3c5eb5a8b06b
>
> Note, I think technically only the UA needs to do point verification if the app
> generates a fresh key as implied by S 2. It would also be nice to have a cite
> to how to do the point verification. This text can be stolen from TLS 1.3.
>
> S 1.
>    This document describes how messages sent using this protocol can be
>    secured against inspection, modification and falsification by a Push
>    Service.
>
> "forgery" is more customary than falsification.
>
> S 3.3.
>
>    key_info = "WebPush: info" || 0x00 || ua_public || as_public
>
> You should make clear that the string is not null-terminated. Ugh, I know.
>
> S 3.4.
> You should clearly separate which pieces are defined in this document
> and which are defined in the HTTP encryption document.
>
>