Re: [Webpush] Alexey Melnikov's Discuss on draft-ietf-webpush-protocol-11: (with DISCUSS and COMMENT)

Martin Thomson <martin.thomson@gmail.com> Wed, 12 October 2016 15:35 UTC

Return-Path: <martin.thomson@gmail.com>
X-Original-To: webpush@ietfa.amsl.com
Delivered-To: webpush@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6F0C71200DF; Wed, 12 Oct 2016 08:35:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gFmIZOktzjF6; Wed, 12 Oct 2016 08:35:56 -0700 (PDT)
Received: from mail-qk0-x22a.google.com (mail-qk0-x22a.google.com [IPv6:2607:f8b0:400d:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 51642129411; Wed, 12 Oct 2016 08:35:56 -0700 (PDT)
Received: by mail-qk0-x22a.google.com with SMTP id f128so36247079qkb.1; Wed, 12 Oct 2016 08:35:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HyKinFGeI5/iBNZkavKm35fJvb9QEFG38l5tIqBhm+w=; b=aTojmqulcsaFoxYRiwBCN1IAX6KjljolTni4CLqlzlIC1tfBop6Aqg21SnS8540YmS yyICt9R+2oa2txBn3c3iBOLxhenbb37WgAVpjb1/DmA5uFfKFR6tDgHspUbvWxoZMWio l02Az6fDnWhaqvQ+6JBxjNd3dpbdOZe1yFR45Y8UDcXHCdQ3j7UYSHekS3/ipp2qAqgZ I4sspNItSwjqSDlQrPvd5jIR27NO1EiYdqbR/p9PgbXV4Z3SZYtRd+bPs7rZlAuqkQ7I IRmKFy7u8tRShHc7yBLqiJ4cFhLyGmEk3FLpDsC/Bf/Vw0k113yXHx+QfP9/yvkBOuX8 lyYQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HyKinFGeI5/iBNZkavKm35fJvb9QEFG38l5tIqBhm+w=; b=HHb/ZWH4Aa7MrCqNJbjo+W8mpYnrjbmPw6xKtnxhcw2bTQz09mV45wKq0Ug7vKBSDm WKPewPUHgybI3eu++imszjfeH7/oY04re4RdzZ1JCFz6ur5xSSkF3BljGRJHz7JqNLI+ hc9nTOoYILokntMeyUYOV/MlcFC4zQBNGq6JHQKnj+5gWixfa0lt6i4unK3XkiarnhA8 v3igNT5s5knO3EidYWwsLGTaU4xddnvKwFyFdV7mjxzXcUSs7gN4+Ar/efr2AbRL+gvU r5XBYeItGpQD75WwVnxELLOEBWhOAkNKJ3Y/bOCGWrdi9jluVJOWSJ1iHhEI8mmP/FHZ KOaA==
X-Gm-Message-State: AA6/9Rki5TS15pe279TDFtpcE0c6H3n1PVd9c8IeZPESad0F5/QkCsVUwu4/cv02v18U9RUwrXLwtPdo35Aksw==
X-Received: by 10.55.99.17 with SMTP id x17mr1657540qkb.147.1476286554787; Wed, 12 Oct 2016 08:35:54 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.140.85.7 with HTTP; Wed, 12 Oct 2016 08:35:54 -0700 (PDT)
In-Reply-To: <147628318443.27316.12918309346360247871.idtracker@ietfa.amsl.com>
References: <147628318443.27316.12918309346360247871.idtracker@ietfa.amsl.com>
From: Martin Thomson <martin.thomson@gmail.com>
Date: Thu, 13 Oct 2016 02:35:54 +1100
Message-ID: <CABkgnnV6uS=1rUYQ7+JtVkGFs6yfv+R4RqNeydBF=AEMhcuE+w@mail.gmail.com>
To: Alexey Melnikov <aamelnikov@fastmail.fm>
Content-Type: text/plain; charset=UTF-8
Archived-At: <https://mailarchive.ietf.org/arch/msg/webpush/XNu5YG7NATL4YS9cXISRIiY_Jp8>
Cc: draft-ietf-webpush-protocol@ietf.org, Shida Schubert <shida@ntt-at.com>, webpush-chairs@ietf.org, The IESG <iesg@ietf.org>, "webpush@ietf.org" <webpush@ietf.org>
Subject: Re: [Webpush] Alexey Melnikov's Discuss on draft-ietf-webpush-protocol-11: (with DISCUSS and COMMENT)
X-BeenThere: webpush@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Discussion of potential IETF work on a web push protocol <webpush.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/webpush>, <mailto:webpush-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/webpush/>
List-Post: <mailto:webpush@ietf.org>
List-Help: <mailto:webpush-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/webpush>, <mailto:webpush-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2016 15:35:58 -0000

Hi Alexey,

Thanks for going through this so thoroughly.

Most of these are - as you say - trivial, and I have PRs for the
issues that you identified, see below.

On 13 October 2016 at 01:39, Alexey Melnikov <aamelnikov@fastmail.fm> wrote:
> 1) In 5.2: is there upper limit on the TTL? The ABNF doesn't restrict the
> value, but it is important for interoperability

Magnus Westerlund noted the same problem, so we've cribbed some text
from other HTTP documents.  You can see the updated text here:
https://github.com/webpush-wg/webpush-protocol/pull/131

> 2) In 5.3: urgency is defined as a list of one or more values. The
> description says that it defines the lowest value allowed. There is also
> a sentence prohibiting multiple values. Why is this a set and how would
> multiple values be interpreted?

This was in keeping with providing a definition for the header field
that is consistent with other HTTP header fields, but I believe that
you are correct in that the list construction in the ABNF is a hazard
rather than a feature:
https://github.com/webpush-wg/webpush-protocol/pull/135

> 3) In 6:
>
> I don't know where the ":link" Pseudo-Header field came from. Can you
> clarify where it is defined?

Pure editorial error, it's a real header field, as in RFC 5988:
https://github.com/webpush-wg/webpush-protocol/pull/134

> 1)
> I see you defined a new HTTP Header Field "Urgency". Can you reuse email
> header field "Priority" instead (possibly extending it)
>       Can be 'normal', 'urgent', or 'non-urgent' and can influence
>       transmission speed and delivery.
> ?

The working group discussed this specifically and at some length.
Priority was actually one of my original proposals.  The concern is
that this is NOT a priority, but an urgency.  That the values are the
same is merely convenient.

> 2) In 4.1:
>
> Can 429 be used when no subscription set is specified? (If yes, this
> should be mentioned in section 4)

I think that I'd rather leave this to Section 4.1.  It follows the
text immediately. subsection of 4 anyway.

> 3) In 6.1: ":link" is included in the PUSH_PROMISE and not the HEADERS
> block (when compared to section 6). Is this intentional or should one of
> the examples be fixed?

Yes, the link relation should be in the response, not the promise.  Thanks.

> 4) In general case it is not possible to achieve message reliability
> because a push server is allowed to expire messages after they were
> accepted for delivery due to overload. (Similarly for forced subscription
> expiration.) I don't think the document makes this clear in Section 7.4.

You are right, we mention this elsewhere, but not here:
https://github.com/webpush-wg/webpush-protocol/pull/136

> 5) In 9.3:

Alissa covered this already.