Re: [Webpush] AD Review of draft-ietf-webpush-vapid

Adam Roach <adam@nostrum.com> Thu, 15 June 2017 16:21 UTC

Return-Path: <adam@nostrum.com>
X-Original-To: webpush@ietfa.amsl.com
Delivered-To: webpush@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0E61C129524; Thu, 15 Jun 2017 09:21:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.881
X-Spam-Level:
X-Spam-Status: No, score=-1.881 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.001, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aZibHEp9Oyg7; Thu, 15 Jun 2017 09:21:06 -0700 (PDT)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 62EB4129486; Thu, 15 Jun 2017 09:21:06 -0700 (PDT)
Received: from Orochi.local (99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id v5FGL3YA022427 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 15 Jun 2017 11:21:03 -0500 (CDT) (envelope-from adam@nostrum.com)
X-Authentication-Warning: raven.nostrum.com: Host 99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228] claimed to be Orochi.local
To: Costin Manolache <costin@gmail.com>
Cc: draft-ietf-webpush-vapid.all@ietf.org, "webpush@ietf.org" <webpush@ietf.org>
References: <47693535-bfde-d2b3-4db5-98ffa05da2ad@nostrum.com> <CAP8-Fqkb2_4tapnySbfAAqzbvZL=MGMKX1+xQYs23LBBb97LKg@mail.gmail.com>
From: Adam Roach <adam@nostrum.com>
Message-ID: <dbbce94d-5e66-c77e-11cd-d43da5373d89@nostrum.com>
Date: Thu, 15 Jun 2017 11:20:58 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:52.0) Gecko/20100101 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <CAP8-Fqkb2_4tapnySbfAAqzbvZL=MGMKX1+xQYs23LBBb97LKg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/webpush/l6yi2v8A1WUeSzAX5NPqpVizuDo>
Subject: Re: [Webpush] AD Review of draft-ietf-webpush-vapid
X-BeenThere: webpush@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Discussion of potential IETF work on a web push protocol <webpush.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/webpush>, <mailto:webpush-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/webpush/>
List-Post: <mailto:webpush@ietf.org>
List-Help: <mailto:webpush-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/webpush>, <mailto:webpush-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jun 2017 16:21:08 -0000

On 6/15/17 02:07, Costin Manolache wrote:
> I think the 'negotiation' must happen much earlier - at subscribe time 
> (and in general case - out of band). At the time of auth, when VAPID
> is used, the caller must have an endpoint that is bound to the server 
> public key.
>
> If a EC256 public key is used at the time of endpoint creation - it 
> determines the signing algorithm as well.
>
> So the 'challenge' happens long in advance.


This makes sense, but it is a substantially different answer than Martin 
gave. I'll note that the subscription request doesn't indicate the 
algorithm to which the key corresponds, so the push server doesn't seem 
to have any ability to detect an algorithm mismatch until it's way too 
late to do anything about it.

I'm not too caught up on what the details of the plan are, but I think 
that whatever is intended should be documented. I don't want to have 
this protocol painted into a corner when we decide to move on to other 
algorithms, and when I combine your and Martin's answers, it's not clear 
whether that's the case. I do get the impression, however, that this 
aspect of the system design hasn't yet been discussed by the working 
group. It should be.

/a