Re: [websec] Last Call: <draft-ietf-websec-origin-04.txt> (The Web Origin Concept) to Proposed Standard

"Roy T. Fielding" <fielding@gbiv.com> Fri, 02 September 2011 19:37 UTC

Return-Path: <fielding@gbiv.com>
X-Original-To: websec@ietfa.amsl.com
Delivered-To: websec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B05B521F8CED; Fri, 2 Sep 2011 12:37:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -105.678
X-Spam-Level:
X-Spam-Status: No, score=-105.678 tagged_above=-999 required=5 tests=[AWL=-3.079, BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9W-RcGwp53fu; Fri, 2 Sep 2011 12:37:17 -0700 (PDT)
Received: from homiemail-a67.g.dreamhost.com (caiajhbdccac.dreamhost.com [208.97.132.202]) by ietfa.amsl.com (Postfix) with ESMTP id 12EDA21F8CE9; Fri, 2 Sep 2011 12:37:17 -0700 (PDT)
Received: from homiemail-a67.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a67.g.dreamhost.com (Postfix) with ESMTP id A01DB88065; Fri, 2 Sep 2011 12:38:53 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gbiv.com; h=subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to; q=dns; s=gbiv.com; b=f3gQaRY9TUmalVYO MzIdr3O7ccLAh6KHmCcQ2bwkqa5Y4BawPMZjHL6x5UBiusD6a2zBf+sLL23ycET8 AjBHJpC/uGrz7QJIrk1ASBVKgDm34Uq15KfighWp9Qpc6Vd+CfZjlm8Ysw/cvQKe vUDuP28i5fl8YHj6OgnL8AF85os=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gbiv.com; h=subject :mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=gbiv.com; bh=ZszVJLr5ZPC2Fdqw17GzRB7V0Vg=; b=v1TjFZdaB47fFkkaXJIznNTKJ1OF 95Nex+uLyBaXbFwqu/VTxkHXvMVgexxcwriU7dtCf1ZnUxr/glNc6UktwC0YneVO UPbMiKbAH1uCuBDu2ruRFURa+nOPJl4UNRbDz2XRu64FJOP5JG/0r7zg39ZtTjtY UydFrjTbVGkCEis=
Received: from [10.134.89.83] (unknown [75.103.10.98]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: fielding@gbiv.com) by homiemail-a67.g.dreamhost.com (Postfix) with ESMTPSA id 5E3EA8806B; Fri, 2 Sep 2011 12:38:53 -0700 (PDT)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset="us-ascii"
From: "Roy T. Fielding" <fielding@gbiv.com>
In-Reply-To: <20110823211953.14482.9265.idtracker@ietfa.amsl.com>
Date: Fri, 02 Sep 2011 12:38:58 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <712C43CF-5F59-4F3D-B88F-11B3CEE52591@gbiv.com>
References: <20110823211953.14482.9265.idtracker@ietfa.amsl.com>
To: ietf@ietf.org
X-Mailer: Apple Mail (2.1084)
Cc: websec <websec@ietf.org>
Subject: Re: [websec] Last Call: <draft-ietf-websec-origin-04.txt> (The Web Origin Concept) to Proposed Standard
X-BeenThere: websec@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Web Application Security Minus Authentication and Transport <websec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/websec>, <mailto:websec-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/websec>
List-Post: <mailto:websec@ietf.org>
List-Help: <mailto:websec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/websec>, <mailto:websec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Sep 2011 19:37:17 -0000

On Aug 23, 2011, at 2:19 PM, The IESG wrote:

> The IESG has received a request from the Web Security WG (websec) to
> consider the following document:
> - 'The Web Origin Concept'
>  <draft-ietf-websec-origin-04.txt> as a Proposed Standard

Sec 2.2: the definition of OWS includes a mistake that I just fixed in httpbis.

   OWS            = *( [ obs-fold ] WSP )
                    ; "optional" whitespace
   obs-fold       = CRLF

should be

   OWS            = *( HTAB / SP / obs-fold )
                    ; "optional" whitespace
   obs-fold       = CRLF ( HTAB / SP )
                    ; obsolete line folding

The problem isn't in OWS itself -- the above are equivalent.
It is the definition of obs-fold that is wrong because it stands
for the obsolete line folding allowed by RFC2616 (RFC822, etc.).
A CRLF alone is not an obs-fold, so optimizing the ABNF in that
way was wrong in httpbis.  Likewise, I recommend replacing WSP with
its equivalent ( HTAB / SP ) because the name is misleading and
is only used in this one section.

OTOH, perhaps a simpler change is in order.  The above definitions
are only used once in the document (Section 7.1).  Furthermore,
since we are defining a new header field (and not all header fields),
we can be more proscriptive in 7.1 and remove the section above.

In 7.1, instead of

   origin              = "Origin:" OWS origin-list-or-null OWS

define it as

   origin              = "Origin:" [ SP ] origin-list-or-null

and then most of 2.2 can be removed.


Sec 8: typo:  s/those model /those models /


Otherwise, the spec looks good.


Cheers,

Roy T. Fielding                     <http://roy.gbiv.com/>
Principal Scientist, Adobe Systems  <http://adobe.com/enterprise>