Re: [Wish] Implementation report for draft-ietf-wish-whip-00

[Lorenzo Miniero <[e-mail]>]

On Thu, 09 Sep 2021 18:39:12 +0200
Juliusz Chroboczek <[e-mail]> wrote:

> >      - what happens if a candidate is followed by random non-JSON
> > garbage? Is that an error?  If so, MUST I return an error or MAY I
> > return an error?  I'm currently just ignoring the garbage.  
> 
> Looking at the draft again, it doesn't look like the candidate is
> JSON, it's just the raw SDP.  Since we're doing bundle, the
> sdpMLineIndex is necessarily 0, so it doesn't need to be sent.
> 
> Is that right?
> 
> -- Juliusz
> 

Sergio pointed this out too in a private conversation, as the format of
the candidates to send in a PATCH was one of the assumptions I made in
my implementation. I chose to serialize them to a JSON object exactly
because of what you said (sdpMLineIndex), but if bundling is indeed
mandated, then it's unneeded and the "raw" candidate is fine. I'll fix
this in both server and client tomorrow.

What still isn't clear is whether or not grouping multiple candidates in
a single PATCH request (e.g., because we collected a few before we got
the answer back) is doable or not, and how they should be formatted in
case.

Lorenzo

-- 
I'm getting older but, unlike whisky, I'm not getting any better
https://twitter.com/elminiero