Re: [Wish] New draft version draft-murillo-whip-01

Juliusz Chroboczek <jch@irif.fr> Fri, 28 May 2021 15:15 UTC

Return-Path: <jch@irif.fr>
X-Original-To: wish@ietfa.amsl.com
Delivered-To: wish@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A9AD63A2C05 for <wish@ietfa.amsl.com>; Fri, 28 May 2021 08:15:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ULDIRvDvOzAk for <wish@ietfa.amsl.com>; Fri, 28 May 2021 08:15:33 -0700 (PDT)
Received: from korolev.univ-paris7.fr (korolev.univ-paris7.fr [IPv6:2001:660:3301:8000::1:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 83AB73A2C04 for <wish@ietf.org>; Fri, 28 May 2021 08:15:32 -0700 (PDT)
Received: from mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [81.194.30.253]) by korolev.univ-paris7.fr (8.14.4/8.14.4/relay1/82085) with ESMTP id 14SFFSj4025803; Fri, 28 May 2021 17:15:28 +0200
Received: from mailhub.math.univ-paris-diderot.fr (localhost [127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTP id 66CE9D4C4A; Fri, 28 May 2021 17:15:28 +0200 (CEST)
X-Virus-Scanned: amavisd-new at math.univ-paris-diderot.fr
Received: from mailhub.math.univ-paris-diderot.fr ([127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id tbJb9CHADZGe; Fri, 28 May 2021 17:15:25 +0200 (CEST)
Received: from pirx.irif.fr (unknown [78.194.40.74]) (Authenticated sender: jch) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTPSA id 6F519D4C43; Fri, 28 May 2021 17:15:23 +0200 (CEST)
Date: Fri, 28 May 2021 17:15:23 +0200
Message-ID: <877djiopo4.wl-jch@irif.fr>
From: Juliusz Chroboczek <jch@irif.fr>
To: Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com>
Cc: wish@ietf.org
In-Reply-To: <CA+ag07bfkvg1TNDGieN9=FbRZeWqbC0gWiC7DWGp84sP7-EkgA@mail.gmail.com>
References: <CA+ag07aArqZfdNEDLvm-T1+RN7Xf8PzU0yLoVXdjJbyAHCTZ-Q@mail.gmail.com> <87mtsfni5p.wl-jch@irif.fr> <CA+ag07axaTxz0hRkZfpMZUYMWmFeYmHrv7bb8z7JfxbXTpF46w@mail.gmail.com> <87bl8vndq8.wl-jch@irif.fr> <CA+ag07bfkvg1TNDGieN9=FbRZeWqbC0gWiC7DWGp84sP7-EkgA@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/28.0 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (korolev.univ-paris7.fr [194.254.61.138]); Fri, 28 May 2021 17:15:28 +0200 (CEST)
X-Miltered: at korolev with ID 60B10910.002 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)!
X-j-chkmail-Enveloppe: 60B10910.002 from mailhub.math.univ-paris-diderot.fr/mailhub.math.univ-paris-diderot.fr/null/mailhub.math.univ-paris-diderot.fr/<jch@irif.fr>
X-j-chkmail-Score: MSGID : 60B10910.002 on korolev.univ-paris7.fr : j-chkmail score : . : R=. U=. O=. B=0.000 -> S=0.000
X-j-chkmail-Status: Ham
Archived-At: <https://mailarchive.ietf.org/arch/msg/wish/BlS43K74csuTM3XtVMQlp3h434o>
Subject: Re: [Wish] New draft version draft-murillo-whip-01
X-BeenThere: wish@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: WebRTC Ingest Signaling over HTTPS <wish.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/wish>, <mailto:wish-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/wish/>
List-Post: <mailto:wish@ietf.org>
List-Help: <mailto:wish-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/wish>, <mailto:wish-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 May 2021 15:15:40 -0000

> It is explicitly stated that the HTTP PATCH request with the sdp fragment body
> containing the ICE candidates/restart info must be sent to the WHIP Resource
> URI returned on the Location header of the 201 create response to the original
> HTTP PUT request.

It was not clear to me that there are two URLs, the "WHIP Endpoint URL"
and the "WHIP Resource URL".  Everything is clear now.

> How do you think it should be further explained?

Perhaps the fact that there are two distinct URLs could be stated in
Section 3?

>>>> On a related note, what happens if the client is on a restrictive
>>>> network that doesn't allow UDP?  Are you assuming it has learned
>>>> the address of a TURN server out of band, or are you relying on
>>>> passive TCP candidates?  (Either would be fine, but it needs to
>>>> be spelled out.)

> When the client allocates a relay candidate on the TURN server to connect on a
> restricted network, it will send a STUN request via it to the server host
> candidates.

How did the client acquire the TURN server's address and credentials in
the first place?  You're assuming that this has happened out of band
before the first WHIP interaction, by some means not specified by this
protocol, right?

If so, that's fine with me, I just think that it should be stated explicitly.

>     Sorry if I'm being obtuse.  Client does trickle, so it sends an SDP offer
>     with incomplete candidates.  After contacting its STUN server, it attempts
>     to PATCH its offer, and receives 405.
> 
>     What should the client do in that situation?
> 
> It is stated on the draft:
> 
>    A WHIP client receiving a 405 response for an HTTP PATCH request
>    SHALL not send further request for ICE trickle or restart.  If the
>    WHIP client gathers additional candidates (via STUN/TURN) after the
>    SDP offer is sent, it MUST send STUN request to the ICE candidates
>    received from the media server as per [RFC8838] regardless if the

Aha, I see.  You're assuming that either the server is accessible from the
Internet, or it implements trickling of client candidates.

Makes perfect sense, thanks.

-- Juliusz