Re: [Wish] Use entity-tags for solving out of order PATCH requests

Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com> Thu, 03 March 2022 09:19 UTC

Return-Path: <sergio.garcia.murillo@gmail.com>
X-Original-To: wish@ietfa.amsl.com
Delivered-To: wish@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3C5F53A146E for <wish@ietfa.amsl.com>; Thu, 3 Mar 2022 01:19:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.107
X-Spam-Level:
X-Spam-Status: No, score=-7.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Sx2--NCzTPNr for <wish@ietfa.amsl.com>; Thu, 3 Mar 2022 01:19:51 -0800 (PST)
Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D8C233A0A2D for <wish@ietf.org>; Thu, 3 Mar 2022 01:19:51 -0800 (PST)
Received: by mail-pj1-x102a.google.com with SMTP id gj15-20020a17090b108f00b001bef86c67c1so4167807pjb.3 for <wish@ietf.org>; Thu, 03 Mar 2022 01:19:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m3RSRb/TxQWlau0p6FzuH5lAtG/9wdLmqn3/sCvOCPY=; b=AfeO2FrlfLLrfc6dTwS8/fzGoXhR0H5+2pvDb43yFZlj33L8xm2v6KWymX7kh+mgx5 Xg0Jm6fq1XgYNM9sRM3ZLdHdQyUMivSot6jlMaApTJ3e7xO4eBc1JmchuX2E1/P2Jo// gd+zQ+Vgq0Jr9KebxX1HZ2cIc9FPbbXx7CY6ExoUqQwdAv52zOpDkKaoep4Q+ZnVtJtR G7ZVKMqoyg+DcrPqOAdoH4v6Gj3D1Lz5a1J893fKYcxF9vWUj3PlrOBWyiWm6FfFn0nx 7Wc0MQqcsvKvvC9nM9YgYRUognP5Jo44Uj68pPVzyFMOFTIxH4HQpZGONK/XXF1kZAf+ fDFA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m3RSRb/TxQWlau0p6FzuH5lAtG/9wdLmqn3/sCvOCPY=; b=aJlsEa2/n7krY+20+sS8O1j3MlJy5JIDnM0M8i+BBcJUjUz9/lbcE9J67o8w2p0tTK 42OV98Db92Vxe4KCZe2GqhOIoQG9HrlEjTEAHKHTGOh7XAuPLzRfTgGDHSs8bahR4+RI PEFNuFhaE/iTdNG7Hg/WkZ7us/aNUdfaI/kTntZNHMdONSdgp1UaGhSH6WnljcauRdOb +wckAfHGZggn8MCrbokfNj/XMLR9QM6Ja86pOyDLpJ8+9QLvhVgYqvg3iq09KKG4lm6o tpkoQhoAohD1MHQUmUrjmY7waOpdj5IZXWzRdVnjBTdorR3TgsKJWSwWlk6cWg/rWabh 81CQ==
X-Gm-Message-State: AOAM531XsSsCU/2GNdDUrg+ydhuZxlKoDzNE7iBNoYL7zkIebMkhigKy pZQlcQzCdTrYX4MRZxPalULYrMecDtLs0gxd5yZUTk2m
X-Google-Smtp-Source: ABdhPJzCHv1nSi/FKRWW7xheFu1j94IkHGBsR1uhz12K0gndN/h5tL94iw3u2O0mDsr2NDE9nNd78bw5SD83cnDZ9mI=
X-Received: by 2002:a17:90b:4d08:b0:1be:f8a0:d156 with SMTP id mw8-20020a17090b4d0800b001bef8a0d156mr4320997pjb.138.1646299190856; Thu, 03 Mar 2022 01:19:50 -0800 (PST)
MIME-Version: 1.0
References: <CA+ag07bXRH9en5rWg3FBXOFp4OCz1N5HtpyK6+nbjycj1jkTaA@mail.gmail.com> <20220302182443.0b20caa6@lminiero>
In-Reply-To: <20220302182443.0b20caa6@lminiero>
From: Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com>
Date: Thu, 03 Mar 2022 10:19:40 +0100
Message-ID: <CA+ag07aVzYz-LJKYujTnSFKkw_L_hP5eFZ2HYQHx1j8vRv+T6w@mail.gmail.com>
To: Lorenzo Miniero <lorenzo@meetecho.com>
Cc: WISH List <wish@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000077116605d94ce6d9"
Archived-At: <https://mailarchive.ietf.org/arch/msg/wish/EogBcvaccRjZTz97xRfenzV0XAI>
Subject: Re: [Wish] Use entity-tags for solving out of order PATCH requests
X-BeenThere: wish@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: WebRTC Ingest Signaling over HTTPS <wish.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/wish>, <mailto:wish-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/wish/>
List-Post: <mailto:wish@ietf.org>
List-Help: <mailto:wish-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/wish>, <mailto:wish-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2022 09:19:56 -0000

Hi Lorenzo

On Wed, Mar 2, 2022 at 6:24 PM Lorenzo Miniero <lorenzo@meetecho.com> wrote:

>
> I think the changes look fine, I just have a couple of comments:
>
>         * What error should be returned in case a PATCH to trigger an
>           ICE restart does NOT contain the "*" If-Match value? The
>           draft says it's a MUST, but doesn't elaborate on the
>           consequences if that doesn't happen. Intuitively a 412 could
>           be returned as well, but the PATCH for ICE restart could
>           actually contains the last valid ETag, and so in that case a
>           412 sounds "wrong".
>

Not sure if ETags are mandated on the client side for non-GET requests, so
while we mandate the If-Match="*" on the whip spec, i think whip
implementations should just accept request without it for ice restarts and
do not return an error.


>         * It's also not clear to me if ETags apply to other requests
>           addressed to a WHIP resource. Thinking of the DELETE to tear
>           down the PeerConnection, for instance, would that need the
>           right ETag to be provided as well? Or would ETags be limited
>           exclusively to PATCH? If so, it might be better to clarify it
>           in the doc to limit the scope.
>

I have the same doubt as before, I don't think it is mandatory from the
HTTP specs to send the etags on the DELETE request, so we should just state
that it is only required for PATCH request.

Best regards
Sergio