Re: [Wish] Distinguishing ICE restarts from candidates

Lorenzo Miniero <lorenzo@meetecho.com> Sat, 11 September 2021 13:15 UTC

Return-Path: <lorenzo@meetecho.com>
X-Original-To: wish@ietfa.amsl.com
Delivered-To: wish@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 437ED3A145C for <wish@ietfa.amsl.com>; Sat, 11 Sep 2021 06:15:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.396
X-Spam-Level:
X-Spam-Status: No, score=-2.396 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.499, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=aruba.it
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P-XOkZvvxd82 for <wish@ietfa.amsl.com>; Sat, 11 Sep 2021 06:15:42 -0700 (PDT)
Received: from smtpcmd03117.aruba.it (smtpcmd03117.aruba.it [62.149.158.117]) by ietfa.amsl.com (Postfix) with ESMTP id 1B9AB3A145B for <wish@ietf.org>; Sat, 11 Sep 2021 06:15:41 -0700 (PDT)
Received: from lminiero ([93.34.33.200]) by Aruba Outgoing Smtp with ESMTPSA id P2r3mOW24SBjYP2r3mPItm; Sat, 11 Sep 2021 15:15:38 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1631366138; bh=2EW/AXtPwqiE18jHoY4HCow9aUKXCRZZYpr4iSQTbDY=; h=Date:From:To:Subject:MIME-Version:Content-Type; b=AunjDLmtC0EwgBG7FwJAEnudStCkClSXMAmEorKY6zGzO9b9poN9N85LLSnFg1wwu g/JyEmRF+SEoVhYX43BrZi4KC6zeXQ/kEt9t2/CzDvy/CdI4FMAWrj1smyp/91DsEv jMbifq0j0csvWGv7LO2qrLCLD784mQGZPTvVXC5WoUXsrKDzdlnYe+5S65PYHaEnhH uNdBKa1tgS8cfXOITvBVJY2Wxwy1uY2pgrZyxr2Yqul5wzTQX9INONil5exs0av6O0 Q0w6hyNAG2YbMybVZbEPUfGzQPPy5lLlIXP8mgCE+kF89cf7+UhcCSva1E5EIc6gxG XrrEAmW02spxg==
Date: Sat, 11 Sep 2021 15:15:36 +0200
From: Lorenzo Miniero <lorenzo@meetecho.com>
To: Juliusz Chroboczek <jch@irif.fr>
Cc: wish@ietf.org
Message-ID: <20210911151536.5ec7cd37@lminiero>
In-Reply-To: <87o88zuuuu.wl-jch@irif.fr>
References: <87o88zuuuu.wl-jch@irif.fr>
Organization: Meetecho
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-CMAE-Envelope: MS4wfC1hUCsF60WYSPHsjJWnekLk1QCWs7h51T/4Mm6GYaCpWjtLrj5Z488IvBFQUe0WSg6cWJ3umt7yLajn5SdZkuVsOFINAtCCT6pfmhTPQCQFdkQsvxtF odhaXU6FZmieqj5WwfWfbq1DOfjXbWT1NGMVQAUmAyYS5PnSzrldABDo
Archived-At: <https://mailarchive.ietf.org/arch/msg/wish/KyXKcKkoT20P0qoi9FE3p_jU9PQ>
Subject: Re: [Wish] Distinguishing ICE restarts from candidates
X-BeenThere: wish@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: WebRTC Ingest Signaling over HTTPS <wish.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/wish>, <mailto:wish-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/wish/>
List-Post: <mailto:wish@ietf.org>
List-Help: <mailto:wish-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/wish>, <mailto:wish-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Sep 2021 13:15:48 -0000

On Sat, 11 Sep 2021 15:04:09 +0200
Juliusz Chroboczek <jch@irif.fr> wrote:

> If I read draft-ietf-wish-whip-00 Section 4.1 right, both ICE
> restarts and candidates are sent using the PATCH method and MIME type
> "application/trickle-ice-sdpfrag".  Which is weird.
> 
> I'm currently assuming that a body starting with "v=" is an ICE
> restart, and a set of ICE candidates otherwise.
> 
> Should ICE restart use a POST with MIME type "application/sdp"?  Is it
> okay to simply use the method and/or the MIME type to distinguish
> between restarts and candidates?
> 
> -- Juliusz
> 


If you assume the media doesn't change, the info a PATCH provides would
be enough to trigger a restart, as in this context of all the info you
typically get in the whole SDP what's important are the ICE credentials
that change. So, as a server, receiving a ugfrag/pwd different from the
ones you were aware of will let you know a restart is taking place: if
as a server you require a full SDP to trigger it, it's just a matter of
updating the last SDP you received with the new ICE credentials (to act
as if you just received a new one), and generate an answer you will not
send back. That's probably how I'll implement it in my server (since it
wraps Janus that works on full SDPs), which I haven't done yet since my
client doesn't support restarts yet (they're not implemented in
GStreamer's webrtcbin).

Lorenzo

-- 
I'm getting older but, unlike whisky, I'm not getting any better
https://twitter.com/elminiero