Re: [Wish] Implementation report for draft-ietf-wish-whip-00

Lorenzo Miniero <lorenzo@meetecho.com> Fri, 10 September 2021 09:09 UTC

Return-Path: <lorenzo@meetecho.com>
X-Original-To: wish@ietfa.amsl.com
Delivered-To: wish@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5419A3A0A2D for <wish@ietfa.amsl.com>; Fri, 10 Sep 2021 02:09:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.399
X-Spam-Level:
X-Spam-Status: No, score=-2.399 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.499, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=aruba.it
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IA8e7ZqqcZ8d for <wish@ietfa.amsl.com>; Fri, 10 Sep 2021 02:09:31 -0700 (PDT)
Received: from smtpcmd11117.aruba.it (smtpcmd11117.aruba.it [62.149.156.117]) by ietfa.amsl.com (Postfix) with ESMTP id A385C3A0A22 for <wish@ietf.org>; Fri, 10 Sep 2021 02:09:29 -0700 (PDT)
Received: from lminiero ([2.232.93.8]) by Aruba Outgoing Smtp with ESMTPSA id OcXCmiK4NIR3HOcXDmwBof; Fri, 10 Sep 2021 11:09:27 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1631264967; bh=pbwLMFSpYjMEYPEOpkEsU1FhZwmbV3qeMjiYUPx1iNs=; h=Date:From:To:Subject:MIME-Version:Content-Type; b=j7y0V/WcAqAuHzJIrEwvlM8YxZ4vmGFNKF4M+EUwPwLApiWsn8FfHE5GIiiL89Ctn zwU5r2HVGbzkW+R38dCnPPRfbCIR3/q2D7RQRiMGuheoMFk6tfK8hzQMlzQ0jKosoo iMekyAGlw99syuTEYwpac/skaeHIrdrFLvTmK6tilgRhFaaY62Wzfe0zhHsm4SLaZu xKGWLM4nsf4kcsScRPfl2Cazz0199JW6QznHMwxy0u3eyKjpiUBnptGogPuaBoBeih J+ZUVTLrfxKeYx4Hr2zs296axUd8csD0zcdt/epL/vuk4kKJPp9cr8nzDdlKc5y1Ew l3QfUuEmIF14A==
Date: Fri, 10 Sep 2021 11:09:22 +0200
From: Lorenzo Miniero <lorenzo@meetecho.com>
To: Juliusz Chroboczek <jch@irif.fr>
Cc: wish@ietf.org
Message-ID: <20210910110922.3e9afce0@lminiero>
In-Reply-To: <87czpgby87.wl-jch@irif.fr>
References: <874kathgcl.wl-jch@irif.fr> <87wnnpg0un.wl-jch@irif.fr> <20210909185217.63e966c2@lminiero> <87czpgby87.wl-jch@irif.fr>
Organization: Meetecho
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-CMAE-Envelope: MS4wfOASqMy/QfdT6Q1KMzlLcsRTfc5uK8zGx4Ri0aD7XbHkeQXONFOUeMcFFm3IWklYwek1HpVAEIVHdLa3qRjNsBSGwAZNqTccZe66sPvwZupXmYI0WG6Q 9ylUlMpiE9vLzqKV0tW2rigfemqoRcGX/a78hVRyOjYsOtMECOh86ugS
Archived-At: <https://mailarchive.ietf.org/arch/msg/wish/RjlXT5MM3G1dO5eP2w6uEOjOQ9k>
Subject: Re: [Wish] Implementation report for draft-ietf-wish-whip-00
X-BeenThere: wish@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: WebRTC Ingest Signaling over HTTPS <wish.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/wish>, <mailto:wish-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/wish/>
List-Post: <mailto:wish@ietf.org>
List-Help: <mailto:wish-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/wish>, <mailto:wish-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Sep 2021 09:09:36 -0000

On Fri, 10 Sep 2021 11:01:44 +0200
Juliusz Chroboczek <jch@irif.fr> wrote:

> > Sergio pointed this out too in a private conversation, as the
> > format of the candidates to send in a PATCH was one of the
> > assumptions I made in my implementation. I chose to serialize them
> > to a JSON object exactly because of what you said (sdpMLineIndex),
> > but if bundling is indeed mandated, then it's unneeded and the
> > "raw" candidate is fine. I'll fix this in both server and client
> > tomorrow.  
> 
> Even though we don't need the sdpMLineIndex (due to bundling), we do
> need the ufrag, so simply sending the candidate line won't do.
> 
> Not sure if we need the ice-passwd.  I hope we don't, since it's not
> part of the RTCIceCandidate, so it would need parsing of the SDP on
> the client side.
> 
> -- Juliusz
> 

Yes, I checked RFC 8840 (my fault for missing it initially) and
ice-ugrag, ice-pwd and the "fake" m-line are all required. I'm updating
the code of both client and server right now to adhere to the spec.

Lorenzo

-- 
I'm getting older but, unlike whisky, I'm not getting any better
https://twitter.com/elminiero