Re: [Wish] WG Last Call for draft-ietf-wish-whip

Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com> Wed, 08 March 2023 14:06 UTC

Return-Path: <sergio.garcia.murillo@gmail.com>
X-Original-To: wish@ietfa.amsl.com
Delivered-To: wish@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 58348C15153D for <wish@ietfa.amsl.com>; Wed, 8 Mar 2023 06:06:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pzRVMdQmu50s for <wish@ietfa.amsl.com>; Wed, 8 Mar 2023 06:06:17 -0800 (PST)
Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A1333C151534 for <wish@ietf.org>; Wed, 8 Mar 2023 06:06:17 -0800 (PST)
Received: by mail-ed1-x52a.google.com with SMTP id u9so66303205edd.2 for <wish@ietf.org>; Wed, 08 Mar 2023 06:06:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678284376; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Z8lb8MYAVb/e6GB0gq0zvse2ZnlhAz7iEpY07+YhZIY=; b=icX5alvCss5chlUMU3v3ea4kDH1rqsI9PxfR940Uo0iYFrp7sHmZCJGfQnwnfD1Kqd ZQUBCeSTkOxJsdSwdnpEHMtzoLxseQuI9rxxdohtOWr+L0xjy1P5fIDJMFHU5Nc3I6IU PSY9E+T9GZRobL6I2j9gOS2RdXktTI3GjezFpaJxKQpeR5LnWGonSBAPOq5g6Al57aDO ol9W1nLIpCL+XYuGFW5B+38VuVWfi58DcWzPx7cgWcbiDQ8F2QpEnJG9PxPlb2MDhLR5 ALQZfKGBlZvCecte1Gc026bBLwrPVD2DWX8O0upBFtKzNjlZUsvAvRMb2yuS90Iheolv y3Dw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678284376; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z8lb8MYAVb/e6GB0gq0zvse2ZnlhAz7iEpY07+YhZIY=; b=QlaDATr8ooqgjB1jaaD+Vokc2mCydejtLb3grmprKeFX9RJz9XuvWPXF/PYKKaLDeL c/x8BRrneOg6qrAli0PrwoTqygo9gjLTGbD1vIhS+JcEAg/8BemCCSkP4gTGATw+e9c2 Xa3TsejImz57DLdRBWaQorFcxibCBFvWmwpk3l/YxsnhDYPFHp9jlMdYByFoFSo1+ueV 6+6C211sm19Tww4lqB49X1xgO17LG64e33p/aXeAtd0keHr0EqisiEFK4woi5EcJmNrf OnrPC4c2zh0K37N1G6kDnB38s1IJzRmE0q1s2DA6tS2Zf4BAgESo50Ja6Pf3M0EaZ+cM PEqw==
X-Gm-Message-State: AO0yUKXvpMbW666CSNflj7QNsPgpR46blJWr7VrSrtkyznz/pld7aiGs RvpK8DwPp+3XkxyUZ5/Qr7tuwp28lSgqVBqL162HHBMNf9M=
X-Google-Smtp-Source: AK7set+bP3j0xA7JeP49DPsUIi0l4/G3Pyv7tORqK8ca6J1OBWKt/jOH+l2F1FwgB6n1EalBr+vLMHPn/dEJrJikIMk=
X-Received: by 2002:a50:8a9d:0:b0:4bc:5de1:ee5 with SMTP id j29-20020a508a9d000000b004bc5de10ee5mr10097122edj.2.1678284375780; Wed, 08 Mar 2023 06:06:15 -0800 (PST)
MIME-Version: 1.0
References: <CA+ag07afe3oYQW=UzCruQtqntNhLuQsAi9XmfUNEbRCWBNPEaw@mail.gmail.com> <B29BF8C4-8A15-4091-9402-4D063E62EF84@gmail.com>
In-Reply-To: <B29BF8C4-8A15-4091-9402-4D063E62EF84@gmail.com>
From: Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com>
Date: Wed, 08 Mar 2023 15:06:04 +0100
Message-ID: <CA+ag07anitDZMmLj1YU=b=mu9iMNssFoTQbFGafd4mV9vFH4AA@mail.gmail.com>
To: Bernard Aboba <bernard.aboba@gmail.com>
Cc: wish@ietf.org
Content-Type: multipart/alternative; boundary="0000000000000cf29205f66408c2"
Archived-At: <https://mailarchive.ietf.org/arch/msg/wish/v4ixmbTcvdE4JRutZoTd4c_9meQ>
Subject: Re: [Wish] WG Last Call for draft-ietf-wish-whip
X-BeenThere: wish@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: WebRTC Ingest Signaling over HTTPS <wish.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/wish>, <mailto:wish-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/wish/>
List-Post: <mailto:wish@ietf.org>
List-Help: <mailto:wish-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/wish>, <mailto:wish-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Mar 2023 14:06:18 -0000

Hi Bernard,

I have created 3 PRs addressing your feedback:

https://github.com/wish-wg/webrtc-http-ingest-protocol/pulls

Could you review them and let me know if you are happy with the changes?  I
plan to submit a new draft by the end of the week.

Best regards
Sergio


On Tue, Feb 28, 2023 at 9:09 PM Bernard Aboba <bernard.aboba@gmail.com>
wrote:

> Comments below.
>
> On Feb 28, 2023, at 05:48, Sergio Garcia Murillo <
> sergio.garcia.murillo@gmail.com> wrote:
>
> 
>
> Hi Bernard,
>
> Thank you very much for your feedback, comments below inline.
>
> On Fri, Feb 24, 2023 at 10:56 PM Bernard Aboba <bernard.aboba@gmail.com>
> wrote:
>
>> Here is my (belated) review.
>>
>> Section 1
>>
>> “ While WebRTC has been very successful in a wide range of scenarios,
>>
>>    its adoption in the broadcasting/streaming industry is lagging
>>
>>    behind.”
>>
>> [BA] I recently saw a survey indicating that WHIP is now the second most
>> implemented ingestion protocol, second only to RTMP.  So while this
>> sentence may have been correct at one time, it seems out of date now.  Can
>> we delete this sentence?
>>
>> Also, overall Section 1 seems like it could be shortened considerably by
>> highlighting the major points. Here is my suggestion:
>>
>>
> I am ok with changing the introduction, will review your text and propose
> a PR with your changes.
>
>
> [BA] Sounds good.
>
>
>
>> Section 2
>>
>>
>> I do not see a definition of “track”.  I think this is important to clarify.
>>
>>
>  I already had a PR related to that adding a reference to RFC8830.
>
> https://github.com/wish-wg/webrtc-http-ingest-protocol/pull/95
>
> Do you think it would be enough?
>
>
> [BA] I would also add a definition for “track”.
>
> Yes, this is definitely possible, see me comment about using track as
> defined in RFC8830. Given that stereo and surround sound are SDP
> negotiated, do you think that we need to include any further clarification
> apart of the track one?
>
>
> [BA] I think that’s all that is needed.
>
>  I agree with you, should we remove the reference to SVC completely and
> only leave simulcast support in that section?
>
>
> [BA] That would make sense. Only thing to worry about might be ingestors
> that can’t handle reference scaling (e.g. spatial modes) but that’s an edge
> case that might be not be encountered in practice.
>
>
> Best regards
> Sergio
>
>