Re: [xml2rfc] url

Carsten Bormann <cabo@tzi.org> Sun, 07 July 2019 19:33 UTC

Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <B12A04BF-F7C0-4492-9061-7B1993D758C4@tzi.org>
Date: Sun, 07 Jul 2019 21:33:31 +0200
Cc: XML2RFC Interest Group <xml2rfc@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <CB663ECC-1772-4A46-861E-CBEBC0837C36@tzi.org>
References: <m2v9wermlb.wl-randy@psg.com> <m2pnmlsqhh.wl-randy@psg.com> <77F6A44C-4405-42A9-9CF0-E9C86EF10F3C@tzi.org> <B12A04BF-F7C0-4492-9061-7B1993D758C4@tzi.org>
To: Henrik Levkowetz <henrik@levkowetz.com>
Archived-At: <https://mailarchive.ietf.org/arch/msg/xml2rfc/A4d6bSHtZT-4avi_p5UyGAucfhg>
Subject: Re: [xml2rfc] url
Precedence: list

On Jul 7, 2019, at 21:05, Carsten Bormann <cabo@tzi.org> wrote:
> 
> Bug report: I think this should be something like
> 
>>>  hash = ‘-‘+base64.urlsafe_b64encode(hashlib.sha1(query).digest()) if query else ‘’

With 2.23.0, I actually get

    hash = '-'+base64.urlsafe_b64encode(hashlib.sha1(query)) if query else ''
TypeError: Unicode-objects must be encoded before hashing

(Python 3.7.3)

So this needs more than the change I was proposing (don’t laugh):

hash = '-' + base64.urlsafe_b64encode(hashlib.sha1(query.encode()).digest()).decode() if query else ''

(Python 2 compatibility left as an exercise to the reader.)

Grüße, Carsten

[xml2rfc] url Randy Bush
Re: [xml2rfc] url Carsten Bormann
Re: [xml2rfc] url Randy Bush
Re: [xml2rfc] url Carsten Bormann
Re: [xml2rfc] url Henrik Levkowetz
Re: [xml2rfc] url Carsten Bormann
Re: [xml2rfc] url Henrik Levkowetz