Re: [xml2rfc] Problem with anchor quoting for IANA references

Carsten Bormann <cabo@tzi.org> Tue, 27 April 2021 17:05 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: xml2rfc@ietfa.amsl.com
Delivered-To: xml2rfc@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2A3233A173F for <xml2rfc@ietfa.amsl.com>; Tue, 27 Apr 2021 10:05:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.219
X-Spam-Level:
X-Spam-Status: No, score=-4.219 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Aud7jhoGAxaT for <xml2rfc@ietfa.amsl.com>; Tue, 27 Apr 2021 10:04:55 -0700 (PDT)
Received: from gabriel-vm-2.zfn.uni-bremen.de (gabriel-vm-2.zfn.uni-bremen.de [134.102.50.17]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 894C53A1742 for <xml2rfc@ietf.org>; Tue, 27 Apr 2021 10:04:55 -0700 (PDT)
Received: from [192.168.217.118] (p548dcb12.dip0.t-ipconnect.de [84.141.203.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gabriel-vm-2.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4FV7RT71mpzyhk; Tue, 27 Apr 2021 19:04:53 +0200 (CEST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <F931F0D2-E11B-49A9-AC00-F467F40DCC99@tzi.org>
Date: Tue, 27 Apr 2021 19:04:53 +0200
Cc: "xml2rfc@ietf.org" <xml2rfc@ietf.org>
X-Mao-Original-Outgoing-Id: 641235893.47399-4cd90020e4113a22fcbabbea79715c59
Content-Transfer-Encoding: quoted-printable
Message-Id: <F77267D6-73E3-41DF-B6B0-000FF3DA7216@tzi.org>
References: <801231afed859093336860dcebfc02a1a64bc7a2.camel@rkf-eng.com> <F931F0D2-E11B-49A9-AC00-F467F40DCC99@tzi.org>
To: Brian Sipos <BSipos@rkf-eng.com>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
Archived-At: <https://mailarchive.ietf.org/arch/msg/xml2rfc/LuDd5k-fjpNjA0ofWYDM_27ScrU>
Subject: Re: [xml2rfc] Problem with anchor quoting for IANA references
X-BeenThere: xml2rfc@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <xml2rfc.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/xml2rfc>, <mailto:xml2rfc-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/xml2rfc/>
List-Post: <mailto:xml2rfc@ietf.org>
List-Help: <mailto:xml2rfc-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/xml2rfc>, <mailto:xml2rfc-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Apr 2021 17:05:00 -0000

Oh, and here is the bug:

                txt = re.sub(r"anchor='[^']*'", f"anchor='{self.replacement_anchor}", txt)
                txt = re.sub(r'anchor="[^"]*"', f"anchor='{self.replacement_anchor}'", txt)

Note the missing closing single quote in the first line (bibxml8/index.cgi, line 84).

Grüße, Carsten

> On 2021-04-27, at 18:55, Carsten Bormann <cabo@tzi.org> wrote:
> 
> On 2021-04-27, at 18:40, Brian Sipos <BSipos@rkf-eng.com> wrote:
>> 
>>> <reference anchor='HI
>>> target='http://www.iana.org/assignments/bundle'>
>> 
>> Note the lack of a closing quotation in the anchor attribute.
> 
> That is an old bug that already was fixed before.
> 
> (I have removed the use of the anchor query parameter from kramdown-rfc because it can do that itself, so I wouldn’t have noticed a regression recently.)
> 
> Grüße, Carsten
> 
> _______________________________________________
> xml2rfc mailing list
> xml2rfc@ietf.org
> https://www.ietf.org/mailman/listinfo/xml2rfc