IETF Logo Mail Archive

Re: [xml2rfc] url

Henrik Levkowetz <henrik@levkowetz.com> Sun, 07 July 2019 22:43 UTC

Return-Path: <henrik@levkowetz.com>
X-Original-To: xml2rfc@ietfa.amsl.com
Delivered-To: xml2rfc@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E5E0612017C for <xml2rfc@ietfa.amsl.com>; Sun, 7 Jul 2019 15:43:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mowgUadiJBWM for <xml2rfc@ietfa.amsl.com>; Sun, 7 Jul 2019 15:43:20 -0700 (PDT)
Received: from zinfandel.tools.ietf.org (zinfandel.tools.ietf.org [IPv6:2001:1890:126c::1:2a]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0461512011A for <xml2rfc@ietf.org>; Sun, 7 Jul 2019 15:43:20 -0700 (PDT)
Received: from h-202-242.a357.priv.bahnhof.se ([158.174.202.242]:59836 helo=tannat.localdomain) by zinfandel.tools.ietf.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from <henrik@levkowetz.com>) id 1hkFsJ-00008j-V5; Sun, 07 Jul 2019 15:43:18 -0700
To: Carsten Bormann <cabo@tzi.org>
References: <m2v9wermlb.wl-randy@psg.com> <m2pnmlsqhh.wl-randy@psg.com> <77F6A44C-4405-42A9-9CF0-E9C86EF10F3C@tzi.org> <B12A04BF-F7C0-4492-9061-7B1993D758C4@tzi.org> <CB663ECC-1772-4A46-861E-CBEBC0837C36@tzi.org>
Cc: XML2RFC Interest Group <xml2rfc@ietf.org>
From: Henrik Levkowetz <henrik@levkowetz.com>
Message-ID: <2f947e06-f57e-e0f2-7467-24f6f303cae4@levkowetz.com>
Date: Mon, 08 Jul 2019 00:43:06 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CB663ECC-1772-4A46-861E-CBEBC0837C36@tzi.org>
Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="HPaF04dLEdlln7MD2IiM7ClaFcTW99erL"
X-SA-Exim-Connect-IP: 158.174.202.242
X-SA-Exim-Rcpt-To: xml2rfc@ietf.org, cabo@tzi.org
X-SA-Exim-Mail-From: henrik@levkowetz.com
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on zinfandel.tools.ietf.org)
X-Clacks-Overhead: GNU Terry Pratchett
Archived-At: <https://mailarchive.ietf.org/arch/msg/xml2rfc/b4n9hHuX4cqHQT9lVsztG_s5kxk>
Subject: Re: [xml2rfc] url
X-BeenThere: xml2rfc@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <xml2rfc.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/xml2rfc>, <mailto:xml2rfc-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/xml2rfc/>
List-Post: <mailto:xml2rfc@ietf.org>
List-Help: <mailto:xml2rfc-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/xml2rfc>, <mailto:xml2rfc-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Jul 2019 22:43:22 -0000


On 2019-07-07 21:33, Carsten Bormann wrote:
> On Jul 7, 2019, at 21:05, Carsten Bormann <cabo@tzi.org> wrote:
>> 
>> Bug report: I think this should be something like
>> 
>>>>  hash = ‘-‘+base64.urlsafe_b64encode(hashlib.sha1(query).digest()) if query else ‘’
> 
> With 2.23.0, I actually get
> 
>     hash = '-'+base64.urlsafe_b64encode(hashlib.sha1(query)) if query else ''
> TypeError: Unicode-objects must be encoded before hashing
> 
> (Python 3.7.3)
> 
> So this needs more than the change I was proposing (don’t laugh):
> 
> hash = '-' + base64.urlsafe_b64encode(hashlib.sha1(query.encode()).digest()).decode() if query else ''

That's what I ended up with, too.  And it's fine for both 2.7 and 3.x

I've released an update that should fix this, 2.23.1.


	Henrik

v2.23.0 | Report a Bug | By Email