[xml2rfc] #407 (Version 2 cli): empty workgroup leads to crash
"xml2rfc issue tracker" <trac@tools.ietf.org> Tue, 14 May 2019 18:36 UTC
Return-Path: <trac@tools.ietf.org>
X-Original-To: xml2rfc@ietfa.amsl.com
Delivered-To: xml2rfc@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BDD6C1200EF for <xml2rfc@ietfa.amsl.com>; Tue, 14 May 2019 11:36:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hp_jJMay1_4S for <xml2rfc@ietfa.amsl.com>; Tue, 14 May 2019 11:36:39 -0700 (PDT)
Received: from zinfandel.tools.ietf.org (zinfandel.tools.ietf.org [IPv6:2001:1890:126c::1:2a]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 28D1C12001B for <xml2rfc@ietf.org>; Tue, 14 May 2019 11:36:39 -0700 (PDT)
Received: from localhost ([::1]:36291 helo=zinfandel.tools.ietf.org) by zinfandel.tools.ietf.org with esmtp (Exim 4.80) (envelope-from <trac@tools.ietf.org>) id 1hQcI2-0003Mc-5N; Tue, 14 May 2019 11:36:38 -0700
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: xml2rfc issue tracker <trac@tools.ietf.org>
X-Trac-Version: 0.12.5
Precedence: bulk
Cc: xml2rfc@ietf.org
Auto-Submitted: auto-generated
X-Mailer: Trac 0.12.5, by Edgewall Software
To: henrik@levkowetz.com, miek@miek.nl
X-Trac-Project: xml2rfc
Date: Tue, 14 May 2019 18:36:38 -0000
X-URL: http://tools.ietf.org/tools/xml2rfc/
X-Trac-Ticket-URL: https://trac.tools.ietf.org/tools/xml2rfc/trac/ticket/407
Message-ID: <060.6ef941789c9f839011006f368e551e59@tools.ietf.org>
X-Trac-Ticket-ID: 407
X-SA-Exim-Connect-IP: ::1
X-SA-Exim-Rcpt-To: henrik@levkowetz.com, miek@miek.nl, xml2rfc@ietf.org
X-SA-Exim-Mail-From: trac@tools.ietf.org
X-SA-Exim-Scanned: No (on zinfandel.tools.ietf.org); SAEximRunCond expanded to false
X-Clacks-Overhead: GNU Terry Pratchett
Archived-At: <https://mailarchive.ietf.org/arch/msg/xml2rfc/kNdIAXgNImUcVhcz4Aq_V9kL3JE>
Subject: [xml2rfc] #407 (Version 2 cli): empty workgroup leads to crash
X-BeenThere: xml2rfc@ietf.org
X-Mailman-Version: 2.1.29
List-Id: <xml2rfc.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/xml2rfc>, <mailto:xml2rfc-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/xml2rfc/>
List-Post: <mailto:xml2rfc@ietf.org>
List-Help: <mailto:xml2rfc-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/xml2rfc>, <mailto:xml2rfc-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 May 2019 18:36:41 -0000
#407: empty workgroup leads to crash
If the workgroup is empty xml2rfc 2.22.3 crashes with the following stack
trace:
(sorry for the horrendous make up)
{{{
>
> xml2rfc --text --v3 draft-gieben-mmark-00.xml && rm draft-gieben-
mmark-00.xml
> Parsing file draft-gieben-mmark-00.xml
> Traceback (most recent call last):
> File "/usr/bin/xml2rfc", line 11, in <module>
> load_entry_point('xml2rfc==2.22.3', 'console_scripts',
'xml2rfc')()
> File "/usr/lib/python2.7/dist-packages/xml2rfc/run.py", line 549,
in main
> writer.write(filename)
> File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py",
line 228, in write
> lines = self.render(self.root, width=72, joiners=joiners)
> File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py",
line 271, in render
> res = func(e, width, **kwargs)
> File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py",
line 2834, in render_rfc
> lines = self.ljoin(lines, c, width, **kwargs)
> File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py",
line 446, in ljoin
> res = mklines(self.render(e, width, **kwargs), e)
> File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py",
line 271, in render
> res = func(e, width, **kwargs)
> File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py",
line 1604, in render_front
> text = '\n\n\n\n' + self.render_first_page_top(e, width,
**kwargs) + '\n'
> File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py",
line 1796, in render_first_page_top
> left = get_left(e)
> File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py",
line 1723, in get_left
> left.append(group.text.strip())
> AttributeError: 'NoneType' object has no attribute 'strip'
> Makefile:8: recipe for target 'draft-gieben-mmark-00.txt' failed
> make: *** [draft-gieben-mmark-00.txt] Error 1
}}}
--
---------------------------+----------------------------------
Reporter: miek@miek.nl | Owner: henrik@levkowetz.com
Type: defect | Status: new
Priority: medium | Milestone:
Component: Version 2 cli | Version: 2.10.x
Keywords: |
---------------------------+----------------------------------
Ticket URL: <https://trac.tools.ietf.org/tools/xml2rfc/trac/ticket/407>
xml2rfc <http://tools.ietf.org/tools/xml2rfc/>
- [xml2rfc] #407 (Version 2 cli): empty workgroup l… xml2rfc issue tracker
- Re: [xml2rfc] #407 (Version 2 cli): empty workgro… xml2rfc issue tracker
- Re: [xml2rfc] #407 (Version 2 cli): empty workgro… xml2rfc issue tracker