Re: [xmpp] WGLC of draft-ietf-xmpp-websocket-02

Gordin <9ordin@gmail.com> Sun, 20 April 2014 23:23 UTC

Return-Path: <9ordin@gmail.com>
X-Original-To: xmpp@ietfa.amsl.com
Delivered-To: xmpp@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3F6B01A00BD for <xmpp@ietfa.amsl.com>; Sun, 20 Apr 2014 16:23:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tmhOCWF09BJ5 for <xmpp@ietfa.amsl.com>; Sun, 20 Apr 2014 16:23:49 -0700 (PDT)
Received: from mail-ie0-x231.google.com (mail-ie0-x231.google.com [IPv6:2607:f8b0:4001:c03::231]) by ietfa.amsl.com (Postfix) with ESMTP id 0B3A01A0077 for <xmpp@ietf.org>; Sun, 20 Apr 2014 16:23:48 -0700 (PDT)
Received: by mail-ie0-f177.google.com with SMTP id rl12so3194149iec.8 for <xmpp@ietf.org>; Sun, 20 Apr 2014 16:23:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=DuCQWwIxqerfdQXgKAQt1VeMX3FHK8GCYXzKshWeIZM=; b=glvhdWEUEt7/oRvMKECB8Bdz69/H30VIfuo8w0mwwyWy4SyzBuhv/r5DtXVxatSuKy ClzCfTK5E63pkXdwJo+u/oyYy4vlN6EYzEWnauoXa3sxTpNQI5RfO2+qpBBP2emAxPQx zEiH0CZ7VbsgBbthGyL5YcciIRpjNQf/2osnyVf086nhg09LqMyESvZSJeupSdkW0jp2 oAaqzf2qHpxES9oKGpGsDPgpM7jnjj1y0y2hgCGLgCxJ50KGLqyN76MNsZz+TZBbqnmg yompZKc6qEv47EJfJASChGfK+xUcQmaqT9Ayab+7vLrKlO2EotMUko8pKCNKU/whil9D lsIw==
X-Received: by 10.42.129.9 with SMTP id o9mr27651069ics.38.1398036224169; Sun, 20 Apr 2014 16:23:44 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.50.168.41 with HTTP; Sun, 20 Apr 2014 16:23:24 -0700 (PDT)
In-Reply-To: <F8275190-9346-4879-9843-A3DF6C604F8C@nostrum.com>
References: <F8275190-9346-4879-9843-A3DF6C604F8C@nostrum.com>
From: Gordin <9ordin@gmail.com>
Date: Mon, 21 Apr 2014 01:23:24 +0200
Message-ID: <CAFp5o_+sy6X5JTS-kg0iSYJU4R1J7EPLSM5hyrttPCZUiP2JLg@mail.gmail.com>
To: Ben Campbell <ben@nostrum.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Archived-At: http://mailarchive.ietf.org/arch/msg/xmpp/eKF9L-WJg86AJKLgIDhSIYKRBc8
Cc: draft-ietf-xmpp-websocket.all@tools.ietf.org, XMPP Working Group <xmpp@ietf.org>
Subject: Re: [xmpp] WGLC of draft-ietf-xmpp-websocket-02
X-BeenThere: xmpp@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: XMPP Working Group <xmpp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/xmpp>, <mailto:xmpp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/xmpp/>
List-Post: <mailto:xmpp@ietf.org>
List-Help: <mailto:xmpp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/xmpp>, <mailto:xmpp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Apr 2014 23:23:53 -0000

I implemented all of the websocket drafts for Strophe.js and found
most of it straightforward, but I have a few minor clarifications to
add for "3.4.  Stream Initiation" (in the -03 version).

It reads
"The first message sent by the initiating entity after the WebSocket
opening handshake is complete MUST be an <open/> element qualified by
the "urn:ietf:params:xml:ns:xmpp-framing" namespace. The 'from', 'id',
'to', and 'version' attributes of this element mirror those of the
XMPP opening stream tag as defined for the
'http://etherx.jabber.org/streams' namespace in XMPP [RFC6120]."

The first sentence could be rearrenged to
"The first message sent after the WebSocket opening handshake is
complete MUST be an <open/> element qualified by the
"urn:ietf:params:xml:ns:xmpp-framing" namespace by the initiating
entity."
to emphasize that the initiating entity has to send the first message
after the handshake.
More important though, "The 'from', 'id', 'to', and 'version'
attributes of this element …" suggests that the the initiating entity
should include an 'id' attribute in the <open/> element, which is a
MUST NOT in RFC6120 as this 'id' "MUST be generated by the receiving
entity" and "the initiating entity MUST NOT include the 'id'
attribute" as stated in
http://tools.ietf.org/html/rfc6120#section-4.7.3 . It would be nice if
there was an example and a reference to RFC6120, section 4.7.3 to make
it clear that the 'id' attribute should only be present in the
response of the receiving entity. Something like:

   C: <open xmlns="urn:ietf:params:xml:ns:xmpp-framing"
            to="example.com"
            version="1.0" />
   S: <open xmlns="urn:ietf:params:xml:ns:xmpp-framing"
            id='++TR84Sm6A3hnt3Q065SnAbbk3Y='
            to="example.com"
            version="1.0" />

-- Gordin

2014-04-07 23:29 GMT+02:00 Ben Campbell <ben@nostrum.com>om>:
> This is a Working Group Last Call of draft-ietf-xmpp-websocket-02. The draft is available at the following URL:
>
> http://tools.ietf.org/html/draft-ietf-xmpp-websocket-02
>
> The WGLC will conclude on 21 April, 2014. Please send your comments to the authors and the XMPP mailing list.
>
> Thanks!
>
> Ben.
>
> _______________________________________________
> xmpp mailing list
> xmpp@ietf.org
> https://www.ietf.org/mailman/listinfo/xmpp