Re: [xrblock] WGLC for 'RTCP XR Report Block for Loss Concealment Metrics Reporting on Video Applications'

Colin Perkins <csp@csperkins.org> Thu, 27 August 2015 14:35 UTC

Return-Path: <csp@csperkins.org>
X-Original-To: xrblock@ietfa.amsl.com
Delivered-To: xrblock@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AFC5A1A01F9 for <xrblock@ietfa.amsl.com>; Thu, 27 Aug 2015 07:35:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.001
X-Spam-Level:
X-Spam-Status: No, score=-0.001 tagged_above=-999 required=5 tests=[BAYES_40=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TBVHCTDLWcT3 for <xrblock@ietfa.amsl.com>; Thu, 27 Aug 2015 07:35:57 -0700 (PDT)
Received: from balrog.mythic-beasts.com (balrog.mythic-beasts.com [IPv6:2a00:1098:0:82:1000:0:2:1]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ABB181A0231 for <xrblock@ietf.org>; Thu, 27 Aug 2015 07:35:57 -0700 (PDT)
Received: from [130.209.247.112] (port=51195 helo=mangole.dcs.gla.ac.uk) by balrog.mythic-beasts.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from <csp@csperkins.org>) id 1ZUyHT-0000i6-F4; Thu, 27 Aug 2015 15:35:56 +0100
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
From: Colin Perkins <csp@csperkins.org>
In-Reply-To: <9904FB1B0159DA42B0B887B7FA8119CA5CAF9F10@AZ-FFEXMB04.global.avaya.com>
Date: Thu, 27 Aug 2015 15:35:37 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <B299A3C4-8D59-4C8A-B040-9047D130B486@csperkins.org>
References: <9904FB1B0159DA42B0B887B7FA8119CA5CAF9F10@AZ-FFEXMB04.global.avaya.com>
To: "Romascanu, Dan (Dan)" <dromasca@avaya.com>
X-Mailer: Apple Mail (2.1878.6)
X-BlackCat-Spam-Score: -28
X-Mythic-Debug: Threshold = On =
Archived-At: <http://mailarchive.ietf.org/arch/msg/xrblock/Z6fClb3jD9bxaboqaXDz8LNJq7Q>
Cc: xrblock <xrblock@ietf.org>
Subject: Re: [xrblock] WGLC for 'RTCP XR Report Block for Loss Concealment Metrics Reporting on Video Applications'
X-BeenThere: xrblock@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Metric Blocks for use with RTCP's Extended Report Framework working group discussion list <xrblock.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/xrblock>, <mailto:xrblock-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/xrblock/>
List-Post: <mailto:xrblock@ietf.org>
List-Help: <mailto:xrblock-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/xrblock>, <mailto:xrblock-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Aug 2015 14:35:59 -0000

On 13 Aug 2015, at 13:41, Romascanu, Dan (Dan) <dromasca@avaya.com> wrote:
> We start a Working Group Last Call for the document ‘RTCP XR Report Block for Loss Concealment Metrics Reporting on Video Applications'. Please let us know if you believe that this document is ready to be submitted to the IESG for consideration as Proposed Standard. Please send your comments, questions and concerns to the WG mail list before September 4, 2015. If you have read the document and you did not find any problems your input is also welcome. If you are aware about any relevant IPR please take the appropriate actions as per RFC 3979.
>  
> The document is available at https://www.ietf.org/id/draft-ietf-xrblock-rtcp-xr-video-lc-01.txt.

I think this is generally in good shape, but some of the definitions at the start of section 4 are unclear. Comments follow:

Section 1.1 uses "MUST" before the RFC 2119 terms have been defined.

Section 4: the first paragraph of this section says twice that a video loss concealment report block SHOULD be sent in the same packet as a Measurement Information Block. It probably only needs to say this once.

Section 4: the first paragraph, says that the video loss concealment report block "SHOULD be sent in the same packet as a Measurement Information Block", then says that the video loss concealment report "MUST be discarded" if the measurement period, included in the Measurement Information Block is not present. The later "MUST" seems to contradict the earlier "SHOULD" strength requirement. 

Section 4: the description of the fields following Figure 1 does not mention the RSV field. 

Section 4: some fields are defined as being measured in RTP timestamp units. Which RTP timestamp is used here? That used by the sender of the video loss concealment block, or that used by the source on which it is reporting?

The following lines contain uses of lower-case RFC 2119 keywords, which could cause confusion:

129:   endpoint or terminal may not see loss occurring between the probe and
130:   the endpoint, and may also not be fully aware of the specific loss
198:   another. Simple decoders may simply re-use the pixels that were in
199:   the missing area while more complex decoders may try to use several
207:   A decoder may user the undamaged pixels in the video frame to
208:   estimate what the missing block of pixels should have.
212:   The sender may encode the message in a redundant way so that receiver
216:   encoder may select a crucial area of an original video frame, extract
248:   discarded. It should be noted that the metrics in this report block
268:   |                  Mean Frame Freeze Duration (optional)        |
367:      Mean Frame Freeze Duration shall be calculated by summing the
369:      number of events. This metric is optional. It only exists
384:      a video frame is totally lost, a value of 0xFF shall be used for
408:      macroblocks, a value of 0, shall be used for the frame when
465:   An attacker may put incorrect information in the Video Loss
468:   Implementers should consider the guidance in [RFC7202] for using
470:   the implementation should apply encryption and authentication to the
658:      frame is decoded and rendered for playout. The metric shall be
700:      video frame is totally lost, a value of 0xFF shall be used for the
742:      there are no concealed macroblocks, a value of 0, shall be used

I suggest the text is either rephrased to avoid these, or they are replaced by the upper-case versions.

I didn't check the appendix.

Cheers,
Colin



-- 
Colin Perkins
https://csperkins.org/