[xrblock] AD evaluation: draft-ietf-xrblock-rtcp-xr-loss-conceal

Alissa Cooper <alissa@cooperw.in> Fri, 14 March 2014 19:12 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: xrblock@ietfa.amsl.com
Delivered-To: xrblock@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 189BB1A01BA for <xrblock@ietfa.amsl.com>; Fri, 14 Mar 2014 12:12:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S6BzXwjMW2t3 for <xrblock@ietfa.amsl.com>; Fri, 14 Mar 2014 12:12:55 -0700 (PDT)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by ietfa.amsl.com (Postfix) with ESMTP id C13ED1A01B6 for <xrblock@ietf.org>; Fri, 14 Mar 2014 12:12:55 -0700 (PDT)
Received: from compute2.internal (compute2.nyi.mail.srv.osa [10.202.2.42]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id D6E80209AE; Fri, 14 Mar 2014 15:12:48 -0400 (EDT)
Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Fri, 14 Mar 2014 15:12:48 -0400
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=cooperw.in; h=date :subject:from:to:message-id:mime-version:content-type :content-transfer-encoding; s=mesmtp; bh=aHJMwKPfvI8LRK1cZI/mYYh GdxU=; b=mW+RhXjJ4a7/tdnMUL2/64L7dhiyyqh/OOGdMuZFi7Vbx8aQg6t+EKg Ea06pfU/qSqdZZgjB0hs2LgH0Lhtrs/ueeuEglZK5yPZW1f+tysaw3DdyQ3AZxhV +qCKg/FEc5sH09PzhbvVrgEF+Q9SkHXx6sS0S0igQCyO5AzV+OUg=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=date:subject:from:to:message-id :mime-version:content-type:content-transfer-encoding; s=smtpout; bh=aHJMwKPfvI8LRK1cZI/mYYhGdxU=; b=Sh8I/ETHLf4Cu676JH02FfdR+dz/ mA/Wnk3kYzp7IMn/Xu1kznfz2vO53HNaD3q7ugFSFqX3f70Dkq+9D/2fV+0DLxfq 6O3R5R5DXSgS258kUbOZztu8rtuoyGMG9i+JKBwSPMcsOpfHy22pnnb/lNABb4To AhaM5FW3DXPko2I=
X-Sasl-enc: tPjaYlC2+yYSk6hPXW5Zoi3aiIYuYvK+C4Nzv9IOGEiu 1394824368
Received: from [171.68.18.51] (unknown [171.68.18.51]) by mail.messagingengine.com (Postfix) with ESMTPA id D5DD46800D8; Fri, 14 Mar 2014 15:12:47 -0400 (EDT)
User-Agent: Microsoft-MacOutlook/14.3.9.131030
Date: Fri, 14 Mar 2014 12:12:44 -0700
From: Alissa Cooper <alissa@cooperw.in>
To: xrblock@ietf.org, "draft-ietf-xrblock-rtcp-xr-loss-conceal@tools.ietf.org" <draft-ietf-xrblock-rtcp-xr-loss-conceal@tools.ietf.org>
Message-ID: <CF48A2BC.25ED4%alissa@cooperw.in>
Thread-Topic: AD evaluation: draft-ietf-xrblock-rtcp-xr-loss-conceal
Mime-version: 1.0
Content-type: text/plain; charset="US-ASCII"
Content-transfer-encoding: 7bit
Archived-At: http://mailarchive.ietf.org/arch/msg/xrblock/cO3hLYUa0Sx4pFk76stz2yburD8
Subject: [xrblock] AD evaluation: draft-ietf-xrblock-rtcp-xr-loss-conceal
X-BeenThere: xrblock@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Metric Blocks for use with RTCP's Extended Report Framework working group discussion list <xrblock.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/xrblock>, <mailto:xrblock-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/xrblock/>
List-Post: <mailto:xrblock@ietf.org>
List-Help: <mailto:xrblock-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/xrblock>, <mailto:xrblock-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Mar 2014 19:12:58 -0000

I have reviewed this draft in preparation for IETF LC.  Overall, it's in
good shape, and I have requested the LC.  A couple of minor comments to
address with any LC comments:

== In Section 3.2 and Section 4.2, I have a few issues with this text:

"Note that the enhancement method (plc =3 )for packet loss
      concealment offers an improved audio quality and or a better
      robustness against packet losses [G.711] and is equivalent to
      enhanced in section 4.7.1 of [RFC3611],"


I assume "and or" is supposed to be "and".

Also, enhanced does not appear in section 4.7.1 of RFC3611. Did you mean
4.7.6?

Is there text missing off the end, or is the comma that ends the sentence
supposed to be a period?

== In Section 4.2, I have an issue with this text:

"Buffer adjustment-type concealment
      SHALL not cause Concealed Seconds to be incremented, with the
      following exception.  An implementation MAY cause Concealed
      Seconds to be incremented for 'emergency' buffer adjustments made
      during talk spurts."

SHALL not (with "not" in lowercase) is not appropriate usage of 2119
language (it should be SHALL NOT). But it also seems to me that SHALL NOT
is inappropriate in this case, because there is an exceptional
circumstance when concealed seconds should be incremented. So I think this
should actually be SHOULD NOT.

== Sections 3 and 4 refer to NLS and NCS as the placeholders for the block
type numbers to be assigned by IANA, but in section 6.1 they are listed as
LCB and CSB, respectively. The same acronyms should be used throughout.

Thanks,
Alissa