Re: [yang-doctors] Yangdoctors early review of draft-ietf-bfd-unsolicited-01

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Wed, 21 August 2019 22:33 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B9980120110; Wed, 21 Aug 2019 15:33:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -13.098
X-Spam-Level:
X-Spam-Status: No, score=-13.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_COMMENT_SAVED_URL=1.391, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_HTML_ATTACH=0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=Mr71I9wJ; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=0Q+BhM6V
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6SN1YcL7Z-pS; Wed, 21 Aug 2019 15:33:07 -0700 (PDT)
Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1A1C81200A3; Wed, 21 Aug 2019 15:33:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=30723; q=dns/txt; s=iport; t=1566426787; x=1567636387; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=Dse6CS/knaez2gDDzW1ypY9t40zO9jmCo4XF4NBjLBA=; b=Mr71I9wJ5SSXtJan8ohh7CPmtJrfr+8Ia4xDukBtT1X4lCgRxGvNppFM vC6qafctnPiNqGjz9bYhVbhlRg1GvbxmmIkgWBZZGJh8z7vluLb7Hk7qc dxPJ33n95orZfULUDUvE/zfHBp8nOlCV40Mz6XBAEACcKA6NmEjRI0m2b g=;
X-Files: Diff_ draft-ietf-bfd-yang.txt - draft-ietf-bfd-yang-17v2.txt.html : 16915
IronPort-PHdr: =?us-ascii?q?9a23=3AXzoNOR08oTcz8OGWsmDT+zVfbzU7u7jyIg8e44?= =?us-ascii?q?YmjLQLaKm44pD+JxKHt+51ggrPWoPWo7JfhuzavrqoeFRI4I3J8RVgOIdJSw?= =?us-ascii?q?dDjMwXmwI6B8vQE1fyLPvjaQQxHd9JUxlu+HToeUU=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ATAADHxV1d/5RdJa1bCRkBAQEBAQE?= =?us-ascii?q?BAQEBAQEHAQEBAQEBgVQDAQEBAQELAYFEJCwDbVUgBAsqhB+BX4FoA4ppTYI?= =?us-ascii?q?PiCaBOI4HgS6BJANUAgcBAQEMAQEjCgIBAYMJgTYCF4JFIzUIDgIFAQEEAQE?= =?us-ascii?q?BAgEGBG2FJwyFSgEBAQECARIRChMBATcBBAsCAQgOCiAKAgICHxElAgQOBQ4?= =?us-ascii?q?UgwABgWoDDg8BAgyfUQKBOIhhc4EygnsBAQWFHA0Lgg8HCYE0AYttGIFAP4E?= =?us-ascii?q?RJx+CTD6CGjwLAQECAReBHRQtFoJeMoIEIowagkwxhQ+BDYYWhHiKWEAJAoI?= =?us-ascii?q?dgzODNYlYBIN1G4IxbYZDjmWMeAmIPYF6jjECBAIEBQIOAQEFgVEBNoFYcBV?= =?us-ascii?q?lAYJBCYIVJINyhRSFP3IBgSiMIQEB?=
X-IronPort-AV: E=Sophos;i="5.64,414,1559520000"; d="html'217?scan'217,208,217";a="606567618"
Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by rcdn-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 21 Aug 2019 22:33:03 +0000
Received: from XCH-RCD-007.cisco.com (xch-rcd-007.cisco.com [173.37.102.17]) by rcdn-core-12.cisco.com (8.15.2/8.15.2) with ESMTPS id x7LMX3Bf029031 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 21 Aug 2019 22:33:04 GMT
Received: from xhs-rcd-003.cisco.com (173.37.227.248) by XCH-RCD-007.cisco.com (173.37.102.17) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 21 Aug 2019 17:33:03 -0500
Received: from xhs-rcd-003.cisco.com (173.37.227.248) by xhs-rcd-003.cisco.com (173.37.227.248) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 21 Aug 2019 17:33:02 -0500
Received: from NAM01-BN3-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-003.cisco.com (173.37.227.248) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 21 Aug 2019 17:33:02 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gkcnQVuinukYqilGzZG68wyAVpyZm8/CpdHlybGs5ZX5ECodNZ8qHrOz2/df/7OmcFUPq5LvLw12cYhYSwW4WR+ys5Ke8kiuirLl/BF7B3hr5neuBOgKPacW2t4UUOBzgiUQ3o7k9MD/Z4b8PdvHGi2ij7xvarMJn+QH4ZVbxN8XQpdpSZ0cGBRU+d6dld9fJHb9NiI12YyCIAoBMlJ4QB4vd0fX/Kh26o9GxBcuHsJbfj88UOQ9XGj8lzxAcxEqXTDh9WuctpJy84MBDCIOoXUKz9/eaMChjS6yuUZS8Uu3dhyVMtlI4JyB58SkX1YAh4bLL2qONNpGNYED5BZbMA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vq5CA2jtF6Gt7k5DBPhV6BM5QLdt73lENyuWMS3oXBk=; b=DGr6xezDQsq1Z+i/cp/9LZafZyFRtuBVIV5JVQs3uEr6NCS8waCOAJPDVu7tRyVUMwjOCk9D1I4Tmo/jGvhLv04s9K2vmHNpTjG31LoUjLdQ7GCfqZSfuZGF4T7+1PLLr5bJ+8iTjwtgVcP6XTe6GxHTyTbn7oVLKN2OJ53fJyxcg7UvdENp5dVwRA0+ew9oz6NSENUBqjLbn6eYgElrW7IlMO0M8PeKC7SWw9ffyB238HiMWNz4oJuQXlyI1I8zNFyGf5J8K7NkJN4hRaeUKSjH3YlWXmBjnximhkyBboIMisJvQb1+jyzQgyMHGnGRuAKaPa0FDvfcbMkgG2d8IQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vq5CA2jtF6Gt7k5DBPhV6BM5QLdt73lENyuWMS3oXBk=; b=0Q+BhM6Vdh5lrKRkWhtq90NGQdUFTXtg4/5UEVAMFZ5bs9tPmycm843vUtsl3oQgWmtepcVnNGELHazgnb0r/72dfhzhK3/V6Ag+Xul8uP6AXn1XdRmRZhUtD1pyH4VfmAegHqK75mUMsDL91CDEYrpjtSgWufqQvfFFs36zq5Y=
Received: from MN2PR11MB4157.namprd11.prod.outlook.com (20.179.150.223) by MN2PR11MB4143.namprd11.prod.outlook.com (20.179.150.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.16; Wed, 21 Aug 2019 22:33:01 +0000
Received: from MN2PR11MB4157.namprd11.prod.outlook.com ([fe80::80bb:d4b:bc47:7daf]) by MN2PR11MB4157.namprd11.prod.outlook.com ([fe80::80bb:d4b:bc47:7daf%3]) with mapi id 15.20.2178.020; Wed, 21 Aug 2019 22:33:01 +0000
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: Jeffrey Haas <jhaas@pfrc.org>
CC: Martin Bjorklund <mbj@tail-f.com>, "mjethanandani@gmail.com" <mjethanandani@gmail.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "rtg-bfd@ietf.org" <rtg-bfd@ietf.org>, "draft-ietf-bfd-unsolicited.all@ietf.org" <draft-ietf-bfd-unsolicited.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-bfd-yang@ietf.org" <draft-ietf-bfd-yang@ietf.org>
Thread-Topic: Yangdoctors early review of draft-ietf-bfd-unsolicited-01
Thread-Index: AQHVVoFcW4RvcvlvFUaeAOxMqn9qZqcCz2yA///ENgCAAEUogP//wIcAgANzdgD//70XgAAE2uwA
Date: Wed, 21 Aug 2019 22:33:01 +0000
Message-ID: <1C786A2F-B87F-4D1A-AA6B-1D88252D7069@cisco.com>
References: <156621414936.19813.853283734958376284@ietfa.amsl.com> <0CD4CB48-9382-4724-A5A6-A7B0DE7D7D57@gmail.com> <22279DB9-A0F3-4D5E-BFDC-38B2AD5B109F@cisco.com> <20190819.211837.1184862907842631386.mbj@tail-f.com> <496A5CD5-23C9-4865-BC52-EFC5409475A8@cisco.com> <20190821201328.GC367@pfrc.org> <94D8BB16-13A8-41BC-A0AF-B75F99FA667F@cisco.com>
In-Reply-To: <94D8BB16-13A8-41BC-A0AF-B75F99FA667F@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.1a.0.190609
authentication-results: spf=none (sender IP is ) smtp.mailfrom=rrahman@cisco.com;
x-originating-ip: [2001:420:2840:1250:6900:eb73:e481:aee6]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a118b797-e904-4092-b483-08d7268786a6
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(49563074)(7193020); SRVR:MN2PR11MB4143;
x-ms-traffictypediagnostic: MN2PR11MB4143:
x-ms-exchange-purlcount: 9
x-microsoft-antispam-prvs: <MN2PR11MB4143C852A5FA5236E5DAD28EABAA0@MN2PR11MB4143.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0136C1DDA4
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(4636009)(376002)(346002)(39860400002)(366004)(396003)(136003)(189003)(199004)(34654002)(58126008)(71190400001)(71200400001)(6512007)(25786009)(53936002)(102836004)(36756003)(186003)(6486002)(6306002)(8936002)(66574012)(8676002)(81156014)(54906003)(81166006)(99286004)(478600001)(6246003)(229853002)(76176011)(486006)(6916009)(966005)(4326008)(6116002)(6506007)(86362001)(446003)(33656002)(66446008)(66556008)(66476007)(64756008)(66616009)(305945005)(99936001)(66946007)(316002)(256004)(6436002)(5660300002)(2906002)(14454004)(2616005)(76116006)(7736002)(53546011)(11346002)(46003)(476003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4143; H:MN2PR11MB4157.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: ICsPGkHBnO4z2dC0ncZ/Xj1API3dnjP6knXkeIFtnrG/bDHTB7w28NQR80cok8kNdL2FIf1UGDdBZ1+bepxV15ir4H9XV4sYm1Z/cEWAihVumqPO/ketG/0RF7AV3rDk8EF56htkXqLLssgflWH1YOkqHrwXEMsytFJmWO0KSTYIrtEdRh0I+6c1qxmyFEq1M3hIwCK/cazLg8addUF2FXhzOa8ZIeNOfbl/itovqQPVWq+ikP1S9WwTq++hJSLH5KeW8ldw/Q9stFX1m2fSh7IeX5FTLM06lZL7uAPiFmYOvbPNk54IHUZZ1ciYEq/v60N1F1mdskcps5ZSU1bO2UrVs2AJaE4kmq+08n4sGfT0odRubKlPAJSkeASYnpqrtm2WVP9gszLDLxa/NL6GdtPA3rBqD4y9ghAdbQ2RQkA=
x-ms-exchange-transport-forked: True
Content-Type: multipart/mixed; boundary="_002_1C786A2FB87F4D1AAA6B1D88252D7069ciscocom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a118b797-e904-4092-b483-08d7268786a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2019 22:33:01.5888 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W6t3m75kWTkEpwkYWk0UOicr+RpLTOWJP4er0R3gF9bL3yWiOUpsubTnFO1Avw/aQ/H09yyd4HWUlJX5fwAitg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4143
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.17, xch-rcd-007.cisco.com
X-Outbound-Node: rcdn-core-12.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/-35AOP5aYOcW1sAgn046Yv5qeIs>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-bfd-unsolicited-01
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Aug 2019 22:33:10 -0000

And this is what the changes would look like.

On 2019-08-21, 4:14 PM, "Reshad Rahman (rrahman)" <rrahman@cisco.com>; wrote:

    Hi Jeff,
    
    Yes, to me it makes sense to do the change suggested by Martin (add "default tx-rx-intervals;" to the choice statement). BFD YANG co-authors, please respond asap if you disagree.
    
    Regards,
    Reshad.
    
    On 2019-08-21, 4:11 PM, "Jeffrey Haas" <jhaas@pfrc.org>; wrote:
    
        Reshad,
        
        If procedures permit it (I'm unclear on the detail), does it make sense to
        pull the BFD yang module for a fix from the editor queue?
        
        -- Jeff
        
        On Mon, Aug 19, 2019 at 07:31:27PM +0000, Reshad Rahman (rrahman) wrote:
        > I was looking at an old copy of the doc which didn't have default. So yes, mandatory doesn't make sense with the default statements.
        > 
        > Your assumption below wrt the intention is correct. I don't know how feasible it is to add this while it's in the editor q.
        > 
        > Regards,
        > Reshad.
        > 
        > On 2019-08-19, 3:18 PM, "Martin Bjorklund" <mbj@tail-f.com>; wrote:
        > 
        >     "Reshad Rahman (rrahman)" <rrahman@cisco.com>; wrote:
        >     > Thanks Martin and Mahesh.
        >     > 
        >     > I believe we should add a mandatory statement to the choic (speaking
        >     > as BFD YANG co-author,)
        >     
        >     But then it is not clear why all leafs in the cases have default
        >     statements.
        >     
        >     Since the 'single-interval' case is optional with a if-feature (which
        >     BTW is weird since it is trivial to implement), and the only other
        >     case has default values on both its leafs, I would have assumed that
        >     the intention was that if nothing is configured, the server should use
        >     1000000 microseconds for the intervals.  If this is the intention,
        >     perhaps a statement:  "default tx-rx-intervals;" can be added to the
        >     module, even though the doc is in the RFC ed q.
        >     
        >     
        >     /martin
        >     
        >     
        >     
        >     > 
        >     > Just created https://github.com/bfd-wg
        >     > 
        >     > Regards,
        >     > Reshad.
        >     > 
        >     > 
        >     > On 2019-08-19, 2:45 PM, "Mahesh Jethanandani" <mjethanandani@gmail.com>; wrote:
        >     > 
        >     >     [Adding the authors of BFD YANG module]
        >     >     
        >     >     Martin brings up a good point. But since the document that contains ietf-bfd-types is sitting in RFC Ed Queue, this will have to go into a bis document.
        >     >     
        >     >     Chairs, could you create a bfd-wg in GitHub for us to track this as an issue to be fixed as part of a bis document?
        >     >     
        >     >     > On Aug 19, 2019, at 4:29 AM, Martin Björklund via Datatracker <noreply@ietf.org>; wrote:
        >     >     > 
        >     >     > Reviewer: Martin Björklund
        >     >     > Review result: Ready with Nits
        >     >     > 
        >     >     > I have reviewed this document from a YANG model perspective only.
        >     >     > 
        >     >     > My only comment is actually for a grouping defined in ietf-bfd-type, but used
        >     >     > in this module.  There is a choice "interval-config-type":
        >     >     > 
        >     >     >  +--rw unsolicited {bfd-unsol:unsolicited-params-global}?
        >     >     >       +--rw enable?                           boolean
        >     >     >       +--rw local-multiplier?                 multiplier
        >     >     >       +--rw (interval-config-type)?
        >     >     >          +--:(tx-rx-intervals)
        >     >     >          |  +--rw desired-min-tx-interval?    uint32
        >     >     >          |  +--rw required-min-rx-interval?   uint32
        >     >     >          +--:(single-interval) {single-minimum-interval}?
        >     >     >             +--rw min-interval?               uint32
        >     >     > 
        >     >     > This choice is not mandatory and doesn't have a default case, so the question
        >     >     > is what happens if no nodes from the choice has been configured?   I would
        >     >     > expect the choice to have a default case (but this then would apply to
        >     >     > ietf-bfd-types, not this document.)
        >     >     > 
        >     >     > 
        >     >     
        >     >     Mahesh Jethanandani
        >     >     mjethanandani@gmail.com
        >     >     
        >     >     
        >     >     
        >     >     
        >     > 
        >     
        >