[yang-doctors] Yangdoctors last call review of draft-ietf-netconf-ssh-client-server-03

Andy Bierman <andy@yumaworks.com> Fri, 28 July 2017 22:14 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Andy Bierman <andy@yumaworks.com>
To: yang-doctors@ietf.org
Cc: draft-ietf-netconf-ssh-client-server.all@ietf.org, netconf@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <150128005005.20715.8994557350330588925@ietfa.amsl.com>
Date: Fri, 28 Jul 2017 15:14:10 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/-Qc3rUWNinetJDp3GWJOgFvgiqA>
Subject: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-ssh-client-server-03

Reviewer: Andy Bierman
Review result: Ready with Nits

Review: draft-ietf-netconf-ssh-client-server-03

Modules:
 (M1) ietf-ssh-client@2017-06-13.yang
 (M2) ietf-ssh-common@2017-06-13.yang
 (M3) ietf-ssh-server@2017-06-13.yang


YANG Usage:

 I did not find anything wrong in either module.
 pyang and yangdump-pro do not report any errors or warnings.

Comments:

C1:

 (M3) transport-params leafrefs

 Example of <transport-params> in sec. 4.2 shows ietf-ssh-common
 as the module namespace but this will never happen in real usage.
 People will copy the various identityref examples in this section
 and not encode the identityref prefix correctly.

C2:

Sec 1.2 Tree Diagrams

Old text should be replaced with reference to
draft-ietf-netmod-yang-tree-diagrams-01

C3:

 (M1) IETF copyright says 2014; change to 2017
 (M3) IETF copyright says 2014; change to 2017

[yang-doctors] Yangdoctors last call review of dr… Andy Bierman
Re: [yang-doctors] Yangdoctors last call review o… Kent Watsen
Re: [yang-doctors] Yangdoctors last call review o… Gary Wu (garywu)