[yang-doctors] Yangdoctors last call review of draft-ietf-ospf-yang-23

Ladislav Lhotka via Datatracker <noreply@ietf.org> Tue, 23 July 2019 21:15 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: yang-doctors@ietf.org
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id BE75C1209B2; Tue, 23 Jul 2019 14:15:02 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ladislav Lhotka via Datatracker <noreply@ietf.org>
To: <yang-doctors@ietf.org>
Cc: draft-ietf-ospf-yang.all@ietf.org, ietf@ietf.org, lsr@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.99.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Ladislav Lhotka <lhotka@nic.cz>
Message-ID: <156391650267.28055.13718648231048242876@ietfa.amsl.com>
Date: Tue, 23 Jul 2019 14:15:02 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/0CKg1cqWrMnk6y7J0LTvLFZkPv8>
Subject: [yang-doctors] Yangdoctors last call review of draft-ietf-ospf-yang-23
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jul 2019 21:15:09 -0000

Reviewer: Ladislav Lhotka
Review result: Ready with Nits

I reviewed already revision 09 of this module [1]. All substantial
objections and suggestions expressed in that review are addressed in
revision 23 and I am satisfied with the result. I especially
appreciate that descriptions were considerably expanded and references
added in many places.

I tested validity of the ietf-ospf module with pyang and Yangson
tools, and found no issues. The comments below are non-substantial and
do not affect practical use of the module.

In summary, I think this YANG module and document is a remarkable
piece of work demonstrating that it is possible to build quite complex
vendor-neutral data model that can be used equally well with several
router plaforms.


     - names of locally-defined identities as parameters of XPath
       functions derived-from and derived-from-or-self sometimes have
       the 'ospf:' prefix, sometimes don't. I suggest to be
       consistent, and the option without a prefix looks better to me.

     - RFC 8407 suggests this format of references to RFC:
       RFC XXXX: Title of the Document
       This draft uses a hyphen instead of a colon. I suggest to
       follow the 8407 convention so as to make parsing easier.

     - the title of Sec. 2.8 should be "OSPF Notifications" (plural
       and capitalization)

     - enumerations "nssa-translator-state-type" and
       "restart-status-type" define the value parameter
       for two of their enums but not for the third. This should be

[1] https://datatracker.ietf.org/doc/review-ietf-ospf-yang-09-yangdoctors-lc-lhotka-2017-12-06/