[yang-doctors] Yangdoctors last call review of draft-ietf-ospf-yang-23

Ladislav Lhotka via Datatracker <noreply@ietf.org> Tue, 23 July 2019 21:15 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ladislav Lhotka via Datatracker <noreply@ietf.org>
To: yang-doctors@ietf.org
Cc: draft-ietf-ospf-yang.all@ietf.org, ietf@ietf.org, lsr@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Ladislav Lhotka <lhotka@nic.cz>
Message-ID: <156391650267.28055.13718648231048242876@ietfa.amsl.com>
Date: Tue, 23 Jul 2019 14:15:02 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/0CKg1cqWrMnk6y7J0LTvLFZkPv8>
Subject: [yang-doctors] Yangdoctors last call review of draft-ietf-ospf-yang-23

Reviewer: Ladislav Lhotka
Review result: Ready with Nits

I reviewed already revision 09 of this module [1]. All substantial
objections and suggestions expressed in that review are addressed in
revision 23 and I am satisfied with the result. I especially
appreciate that descriptions were considerably expanded and references
added in many places.

I tested validity of the ietf-ospf module with pyang and Yangson
tools, and found no issues. The comments below are non-substantial and
do not affect practical use of the module.

In summary, I think this YANG module and document is a remarkable
piece of work demonstrating that it is possible to build quite complex
vendor-neutral data model that can be used equally well with several
router plaforms.

Comments:

- names of locally-defined identities as parameters of XPath
functions derived-from and derived-from-or-self sometimes have
the 'ospf:' prefix, sometimes don't. I suggest to be
consistent, and the option without a prefix looks better to me.

- RFC 8407 suggests this format of references to RFC:
RFC XXXX: Title of the Document
This draft uses a hyphen instead of a colon. I suggest to
follow the 8407 convention so as to make parsing easier.

- the title of Sec. 2.8 should be "OSPF Notifications" (plural
and capitalization)

- enumerations "nssa-translator-state-type" and
"restart-status-type" define the value parameter
for two of their enums but not for the third. This should be
avoided.

[1] https://datatracker.ietf.org/doc/review-ietf-ospf-yang-09-yangdoctors-lc-lhotka-2017-12-06/

[yang-doctors] Yangdoctors last call review of dr… Ladislav Lhotka via Datatracker
Re: [yang-doctors] Yangdoctors last call review o… Acee Lindem (acee)