Re: [yang-doctors] Yangdoctors early review of draft-ietf-mpls-base-yang-10

Tarek Saad <tsaad.net@gmail.com> Thu, 12 September 2019 13:18 UTC

From: Tarek Saad <tsaad.net@gmail.com>
To: Ebben Aries <exa@arrcus.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "mpls@ietf.org" <mpls@ietf.org>, "draft-ietf-mpls-base-yang.all@ietf.org" <draft-ietf-mpls-base-yang.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Thread-Topic: Yangdoctors early review of draft-ietf-mpls-base-yang-10
Thread-Index: ATkwNDk0XwiEpmF5LrvZdM9A3YooW7hycIxb
X-MS-Exchange-MessageSentRepresentingType: 1
Date: Thu, 12 Sep 2019 13:17:59 +0000
Message-ID: <BYAPR19MB3415533CD4DEA0AEB56022DBFCB00@BYAPR19MB3415.namprd19.prod.outlook.com>
References: <156615954036.3697.1825462750505422399@ietfa.amsl.com>
In-Reply-To: <156615954036.3697.1825462750505422399@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-Exchange-Organization-SCL: -1
X-MS-TNEF-Correlator:
X-MS-Exchange-Organization-RecordReviewCfmType: 0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/3Ishj46Da17r0gRqkq_u1wC682A>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-mpls-base-yang-10
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Sep 2019 13:18:09 -0000

Hi Ebben,

Thanks for your review and comments. We have uploaded a new revision of the document that addresses the comments.
Inline for more details.

On 8/18/19, 4:19 PM, "Ebben Aries via Datatracker" <noreply@ietf.org> wrote:

    Reviewer: Ebben Aries
    Review result: On the Right Track
    
    1 module in this draft:
    - ietf-mpls@2019-02-24.yang
    
    No YANG compiler errors or warnings (pyang 2.0.1, yanglint 1.1.40, confdc 6.6.3)
    
    Module ietf-mpls@2019-02-24.yang:
    --------------------------------------------------
    - Remove WG Chairs from contact information per
      https://tools.ietf.org/html/rfc8407#appendix-B
[TS]: done.

    - 'ietf-interfaces' import should reference RFC8343 rather
[TS]: updated.

    - Must clause for start/end-label is incorrect.  Would suggest moving this
      must statement underneath the `leaf end-label` as well:
    
      e.g.
    
      leaf end-label {
          type rt-types:mpls-label;
          must '. >= ../start-label' {
              error-message
                "The end-label must be greater than or equal " +
                "to start-label";
          }
          description "Label-block end";
      }
[TS]: OK, I moved this check to under end-label. I added similar check for start-label too.

    - Use of 'state' container under '/routing/mpls/label-blocks/label-block/state'
      These nodes could sit as r/o nodes by the looks of it directly under the
      label-block list.  In addition, do these nodes need '-count' suffixes?
      Should they rather be of type `yang:counter32`?
[TS]: removed the 'state' container and updated to directly go under list. Also changed to type to yang:counter32.

      See: https://github.com/netmod-wg/FAQ/wiki/NMDA-Modelling-FAQ
    - Is there any intention to define any surrounding features?
[TS]: updated.
    
    General comments/minor nits on the draft/modules:
    --------------------------------------------------
    - Section 1: s/feauture/feature/
    - Section 2.1: s/the the/the/
    - Section 2.1: 'labeled' vs. 'labelled'
    - Section 2.4: s/followinig/following/
    - Module line 354/367: This is for the 'active-route' action statement rather
    
 [TS]: addressed the typos, thanks.

Regards,
Tarek (for authors)

[yang-doctors] Yangdoctors early review of draft-… Ebben Aries via Datatracker
Re: [yang-doctors] Yangdoctors early review of dr… Tarek Saad
Re: [yang-doctors] Yangdoctors early review of dr… Tarek Saad