IETF Logo Mail Archive

Re: [yang-doctors] Yangdoctors last call review of draft-ietf-opsawg-tacacs-yang-03

Ladislav Lhotka <ladislav.lhotka@nic.cz> Thu, 07 May 2020 06:55 UTC

Return-Path: <ladislav.lhotka@nic.cz>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3804F3A0980; Wed, 6 May 2020 23:55:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HPN5CwVn8y-Y; Wed, 6 May 2020 23:55:53 -0700 (PDT)
Received: from trail.lhotka.name (trail.lhotka.name [77.48.224.143]) by ietfa.amsl.com (Postfix) with ESMTP id A6F433A097F; Wed, 6 May 2020 23:55:52 -0700 (PDT)
Received: by trail.lhotka.name (Postfix, from userid 109) id 735B28600AB; Thu, 7 May 2020 08:55:41 +0200 (CEST)
Received: from localhost (unknown [172.29.2.100]) by trail.lhotka.name (Postfix) with ESMTPSA id D8D6F860051; Thu, 7 May 2020 08:55:39 +0200 (CEST)
From: Ladislav Lhotka <ladislav.lhotka@nic.cz>
To: "Wubo (lana)" <lana.wubo@huawei.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
Cc: "last-call@ietf.org" <last-call@ietf.org>, "draft-ietf-opsawg-tacacs-yang.all@ietf.org" <draft-ietf-opsawg-tacacs-yang.all@ietf.org>, "opsawg@ietf.org" <opsawg@ietf.org>
In-Reply-To: <ddcdeabe7c6b4a9eb13132a17bc2d236@huawei.com>
References: <ddcdeabe7c6b4a9eb13132a17bc2d236@huawei.com>
Date: Thu, 07 May 2020 08:55:50 +0200
Message-ID: <871rnww7wp.fsf@nic.cz>
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/5LegvSjsyXDBpd_vC_q-bBuKsRU>
Subject: Re: [yang-doctors] Yangdoctors last call review of draft-ietf-opsawg-tacacs-yang-03
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 May 2020 06:55:55 -0000

"Wubo (lana)" <lana.wubo@huawei.com> writes:
>
> - The "case" statements in ietf-system-tacacsplus:tacacsplus/source-type are unnecessary because each contains only one leaf of the same name; I suggest to remove them.
> [Bo] I need to wait for the further guidance from WG. The "choice case" is added based on the email discussion of the WG, which provides some flexibility in specifying the IP address for server communication. Some vendors prefer IP addresses, and some vendors derive IP addresses through interfaces.

I am not suggesting to remove this choice, this is of course not YANG Doctor's business. My comment is related exclusively to YANG syntax: if you have a "case" statement containing only one data node, then the "case" statement can be omitted, see sec. 7.9.2 in RFC 7950. Such a shorthand is IMO preferable (less clutter), unless you want to leave the possibility of augmenting the case node later - I don't think though it is an option here.

Thanks, Lada

-- 
Ladislav Lhotka 
Head, CZ.NIC Labs
PGP Key ID: 0xB8F92B08A9F76C67

v2.23.0 | Report a Bug | By Email