Re: [yang-doctors] [netconf] Yangdoctors last call review of draft-ietf-netconf-notification-capabilities-05

Kent Watsen <kent@watsen.net> Fri, 01 November 2019 15:46 UTC

Return-Path: <0100016e27a53a56-4e90c30c-cf53-4df0-9cd7-8a5b5ce9b1ce-000000@amazonses.watsen.net>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 06B101208E4; Fri, 1 Nov 2019 08:46:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=amazonses.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id beiosRk9JnaC; Fri, 1 Nov 2019 08:46:12 -0700 (PDT)
Received: from a8-33.smtp-out.amazonses.com (a8-33.smtp-out.amazonses.com [54.240.8.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9FF2F12091B; Fri, 1 Nov 2019 08:46:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw; d=amazonses.com; t=1572623170; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Message-Id:References:To:Feedback-ID; bh=B2FP5FxKo4ZWuhilYME3NCaiSy814ZTyot04DAZkkUY=; b=donEn7+jKT3omxy07Gk+9tsgzqI3+QUXRvMZAMQ0BTJDZC7WsRL7sBnqr34ocFiD W31XAM0m8O4ePoa1j45Oh6h0OLMYvks+eLjgHxaf3WEHLCZKwo4fGqGZHva4uHEZIdW D9dHOvxUXpnIK4syQzTHDNXUqfjn/yNQmmVmQGC8=
Content-Type: multipart/alternative; boundary="Apple-Mail=_3C57301B-50A5-43DB-9970-C085EFDE665A"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
From: Kent Watsen <kent@watsen.net>
In-Reply-To: <157233302184.6593.3869700028694968875@ietfa.amsl.com>
Date: Fri, 01 Nov 2019 15:46:10 +0000
Cc: "netconf@ietf.org" <netconf@ietf.org>
Message-ID: <0100016e27a53a56-4e90c30c-cf53-4df0-9cd7-8a5b5ce9b1ce-000000@email.amazonses.com>
References: <157233302184.6593.3869700028694968875@ietfa.amsl.com>
To: Ladislav Lhotka <lhotka@nic.cz>, draft-ietf-netconf-notification-capabilities@ietf.org
X-Mailer: Apple Mail (2.3445.104.11)
X-SES-Outgoing: 2019.11.01-54.240.8.33
Feedback-ID: 1.us-east-1.DKmIRZFhhsBhtmFMNikgwZUWVrODEw9qVcPhqJEI2DA=:AmazonSES
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/5yCWRF9DR51BCA4NfJ2e4BzNq9c>
X-Mailman-Approved-At: Fri, 01 Nov 2019 11:26:03 -0700
Subject: Re: [yang-doctors] [netconf] Yangdoctors last call review of draft-ietf-netconf-notification-capabilities-05
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Nov 2019 15:46:20 -0000

[moving yang-doctors to BCC]


Thank you Lada.

Authors, please update the draft as needed to address these YANG Doctor comments.

Kent // as Shepherd




> On Oct 29, 2019, at 3:10 AM, Ladislav Lhotka via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Ladislav Lhotka
> Review result: Ready with Nits
> 
> ***** Section 2. Introduction
>      - Paragraph 3: the use of MAY is inappropriate: publishers
>        indeed may have limitations, but this should follow from RFC
>        8641, and this document should take it as a fact.
> ***** Section 3. Notification Capability Model
>      - The use of RFC 2119 terms is again questionable: I understand
>        the ietf-notification-capabilities data as an optional aid for
>        the implementors, but requiring that "The file SHALL be
>        available in implementation time ..." is way too strict.
> ***** Section 3.2. YANG Module
>      - This is one of the cases where it would be helpful to know
>        which of the imported modules, such as ietf-netconf-acm, is
>        also intended to be implemented. This may be addressed in a
>        future YANG version (see issue #95 in yang-next), until then I
>        would suggest to include YANG library data describing a
>        minimum implementation.
> ***** Appendix A. Instance data examples
>      - Example in Fig. 2: the <datastore> element has an incorrect
>        XML namespace (of the ietf-datastores module).
>      - Many enum values are invalid because they contain
>        leading/trailing whitespace. It would be better to encode the
>        examples in JSON.
> 
> 
> _______________________________________________
> netconf mailing list
> netconf@ietf.org
> https://www.ietf.org/mailman/listinfo/netconf