Re: [yang-doctors] [MBONED] Yangdoctors early review of draft-ietf-mboned-cbacc-02
"Holland, Jake" <jholland@akamai.com> Sat, 17 April 2021 21:38 UTC
Return-Path: <jholland@akamai.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1FE8A3A33D8; Sat, 17 Apr 2021 14:38:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.8
X-Spam-Level:
X-Spam-Status: No, score=-2.8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=akamai.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6O58L5d8hRcr; Sat, 17 Apr 2021 14:38:11 -0700 (PDT)
Received: from mx0a-00190b01.pphosted.com (mx0a-00190b01.pphosted.com [IPv6:2620:100:9001:583::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 651003A33D1; Sat, 17 Apr 2021 14:38:08 -0700 (PDT)
Received: from pps.filterd (m0122332.ppops.net [127.0.0.1]) by mx0a-00190b01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13HLTcI1017703; Sat, 17 Apr 2021 22:38:07 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=jan2016.eng; bh=lodMfkCnkjRp4JyOZndJGOqnVRCZY8Xdpb4nfzD6gNM=; b=Hrde2o+dFiFli1XpGeWKoeGa7skGwiZ1kH64bsBMPBvOEmhuRkOtnMhyUpuB2xpQMGfX oWlZ5IT3o1GDq4qwBMIWHWLA9bh9/pDFLsZwILTsaHQ4EQyh+KAshHEChRco5jgtlGZV t1hs/IZCm53lP6QcJwWKmArm7RilvkUozwlxOQUhjUMnM0tqOIj517f4rQSYV3UtZOBg g0AbF40zI7tKf+Y+1UAOnfH8+wumOSec1qTmzintHsIMpYKApfimhozYS9+8qtbZ9aXc fzHFSzswWibRtiNa8gAi57jN3hfRHCbKgbHnbrS6e8rS5ByFk+BrPIZ7GGOnFkbulJi4 pQ==
Received: from prod-mail-ppoint5 (prod-mail-ppoint5.akamai.com [184.51.33.60] (may be forged)) by mx0a-00190b01.pphosted.com with ESMTP id 37yqqn1vm1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Apr 2021 22:38:07 +0100
Received: from pps.filterd (prod-mail-ppoint5.akamai.com [127.0.0.1]) by prod-mail-ppoint5.akamai.com (8.16.0.43/8.16.0.43) with SMTP id 13HLYsEE005330; Sat, 17 Apr 2021 14:38:05 -0700
Received: from email.msg.corp.akamai.com ([172.27.123.32]) by prod-mail-ppoint5.akamai.com with ESMTP id 37ywnbharh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sat, 17 Apr 2021 14:38:05 -0700
Received: from usma1ex-dag1mb6.msg.corp.akamai.com (172.27.123.65) by usma1ex-dag1mb3.msg.corp.akamai.com (172.27.123.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 17 Apr 2021 17:38:04 -0400
Received: from usma1ex-dag1mb6.msg.corp.akamai.com ([172.27.123.65]) by usma1ex-dag1mb6.msg.corp.akamai.com ([172.27.123.65]) with mapi id 15.00.1497.012; Sat, 17 Apr 2021 17:38:04 -0400
From: "Holland, Jake" <jholland@akamai.com>
To: Reshad Rahman <reshad@yahoo.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "draft-ietf-mboned-cbacc.all@ietf.org" <draft-ietf-mboned-cbacc.all@ietf.org>, "mboned@ietf.org" <mboned@ietf.org>
Thread-Topic: [MBONED] Yangdoctors early review of draft-ietf-mboned-cbacc-02
Thread-Index: AQHXLxfUODq5hRGKeU2IDsxr+Uze5aq5E2oA
Date: Sat, 17 Apr 2021 21:38:04 +0000
Message-ID: <7232F37D-884E-4345-8570-52111636E92E@akamai.com>
References: <161817573499.20366.15012284864667773875@ietfa.amsl.com>
In-Reply-To: <161817573499.20366.15012284864667773875@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.47.21031401
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [172.27.118.139]
Content-Type: text/plain; charset="utf-8"
Content-ID: <A0F80987194BE1489E28D10E351F63AD@akamai.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-17_15:2021-04-16, 2021-04-17 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104170154
X-Proofpoint-ORIG-GUID: J8o9iNC_CCiCbMtShhoQYKORi410VHs0
X-Proofpoint-GUID: J8o9iNC_CCiCbMtShhoQYKORi410VHs0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-17_15:2021-04-16, 2021-04-17 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 lowpriorityscore=0 mlxscore=0 phishscore=0 adultscore=0 clxscore=1011 suspectscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104170154
X-Agari-Authentication-Results: mx.akamai.com; spf=${SPFResult} (sender IP is 184.51.33.60) smtp.mailfrom=jholland@akamai.com smtp.helo=prod-mail-ppoint5
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/C2rWCXsf-SP6Zd8Yww2ChHtpyto>
Subject: Re: [yang-doctors] [MBONED] Yangdoctors early review of draft-ietf-mboned-cbacc-02
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Apr 2021 21:38:16 -0000
Hi Reshad, Thanks for your review! Sorry for the slow response, it's been a hectic time for me. On 04-11, 2:15 PM, "Reshad Rahman via Datatracker" <noreply@ietf.org> wrote: > Comments/questions: > > The document and YANG module-name have CBACC, yet the module prefix is "ambi", > is this on purpose? Intuitively, I was expecting the prefix to be "cbacc". Whoops, thanks for catching this, I have it fixed now in my local copy. This was not on purpose. > For presence statement, use CBACC-enabled instead of cbacc-enabled? > > Is max-mss for a TCP Max Segment Size, or is this really max packet size? And > no need for jumbograms since this is for UDP? This is not a TCP MSS option, but rather intended to capture a similar concept for the multicast IP packets. This is meant to be an advertisement of the max IP payload size that the sender will send for this data stream. I guess I would call it a CBACC MSS option, instead of a TCP MSS option, but do you think that will cause confusion? Maybe I should rename it to something like max-pdu or max-packet-size? (The value is often useful to check against network mtu or packet buffer size for a receiving app.) > Consider renaming max-bits-per-second to something along the lines of > max-speed. Description says kilobits (not bits). Thanks, I agree and will go ahead with this, and thanks for catching it. > Add "unit" statement e.g. to data-rate-window and max-bits-per-second Thanks, I hadn't noticed this YANG feature. It seems to be named "units" though, I think that's what you mean? (From section 7.3.3 of RFC 7950: https://tools.ietf.org/html/rfc7950#section-7.3.3 ) I don't see guidance on standardized fields, but I assume that the suggestion is satisfied by adding this to max-speed: units "kilobits/second"; and this to data-rate-window: units "milliseconds"; Is that correct? > OOC, why so many priorities? I'm used to seeing 3 or 8 bits for priority. I guess I hadn't given the size much thought, but more seemed better than less here, since it's not taking packet space in the data stream, and seems a pretty trivial difference in resources at the per-stream control layer. I was aiming to let the sender specify relative priority between all the different streams they might be serving, which could in theory go to a much higher count, but in practice I expected this to be plenty. But based on the early experiments with deploying it, I'm finding I might need to refactor the priority in this spec, so maybe this will become moot. That analysis and experimenting is still in progress, and I don't yet have a concrete replacement after thinking through the use cases more carefully. But I'll consider whether there's value in reducing this size if it keeps the same form, and it's a good question. > Security considerations should mention the YANG data nodes. Thanks, I've added a note to my local copy. I'm tentatively interpreting this comment as "follow the directions from Section 3.7 of RFC 8407", is that a correct summary of this advice? https://tools.ietf.org/html/rfc8407#section-3.7 Very helpful review, much appreciated! Best regards, Jake
- [yang-doctors] Yangdoctors early review of draft-… Reshad Rahman via Datatracker
- Re: [yang-doctors] [MBONED] Yangdoctors early rev… Holland, Jake
- Re: [yang-doctors] [MBONED] Yangdoctors early rev… Reshad Rahman