Re: [yang-doctors] Yangdoctors early review of draft-ietf-babel-yang-model-03

Martin Bjorklund <mbj@tail-f.com> Mon, 14 October 2019 14:07 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E8E11120058; Mon, 14 Oct 2019 07:07:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VU6VWJD89ExE; Mon, 14 Oct 2019 07:07:14 -0700 (PDT)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 6881F12002F; Mon, 14 Oct 2019 07:07:11 -0700 (PDT)
Received: from localhost (unknown [173.38.220.41]) by mail.tail-f.com (Postfix) with ESMTPSA id B0F241AE02BA; Mon, 14 Oct 2019 16:07:09 +0200 (CEST)
Date: Mon, 14 Oct 2019 16:06:42 +0200 (CEST)
Message-Id: <20191014.160642.807920684918683059.mbj@tail-f.com>
To: rkrejci@cesnet.cz, noreply@ietf.org
Cc: yang-doctors@ietf.org, draft-ietf-babel-yang-model.all@ietf.org, babel@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <157106166738.24700.11185508261809138396@ietfa.amsl.com>
References: <157106166738.24700.11185508261809138396@ietfa.amsl.com>
X-Mailer: Mew version 6.8 on Emacs 25.2
Mime-Version: 1.0
Content-Type: Text/Plain; charset=utf-8
Content-Transfer-Encoding: base64
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/CFUJgbZrTUzXkdK27knXD91Gb-I>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-babel-yang-model-03
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Oct 2019 14:07:16 -0000

Radek Krejčí via Datatracker <noreply@ietf.org>; wrote:
> Reviewer: Radek Krejčí
> Review result: Ready with Nits
> 
> There is a single module in the draft: ietf-babel@2019-08-22.yang.
> 
> There are 2 warnings reported by pyang 2.0.2, but both warnings seem to be
> false.

Actually, I think they are correct.


> ietf-babel@2019-08-22.yang:53: warning: RFC 8407: 3.1: The IETF Trust Copyright
> statement seems to be missing (see pyang --ietf-help for details).

Ok it isn't missing, but it doesn't use the eaxct words it should
use.

> ietf-babel@2019-08-22.yang:208: warning: the module seems to use RFC 2119
> keywords, but the required text from RFC 8174 is not found (see pyang
> --ietf-help for details).

This one seems legit as well.


/martin