Re: [yang-doctors] [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-registration-interface-dm-04

"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> Wed, 06 November 2019 02:02 UTC

Return-Path: <jaehoon.paul@gmail.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EE2D1120236; Tue, 5 Nov 2019 18:02:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.988
X-Spam-Level:
X-Spam-Status: No, score=-1.988 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_HK_NAME_FM_MR_MRS=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gEVZWQXNLcLh; Tue, 5 Nov 2019 18:02:47 -0800 (PST)
Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1B330120041; Tue, 5 Nov 2019 18:02:23 -0800 (PST)
Received: by mail-lf1-x129.google.com with SMTP id 19so11537820lft.13; Tue, 05 Nov 2019 18:02:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j66Tt2tQscl56y0FlB5Ti2Jn/NSmpakxSMgIXDUUHUY=; b=h6mRa1nmmgGjM8ZvJ/IUMA795oZXB0Is2PvZhcKoMVYQq9ER0gVBIp6dR13dZrTPnL LYOc4ysxl2M80a6tcpO0y6rTPv+U4slVvVwjUpzDjVdisoNW11UcdsI6TUyl8LoC7wZz 67fXeG7lyx6TwSUMqH4aQd77l7IMtneR+8FNkdp3tdIZQ1QKY1FTnp+LqFUGaWwN7eIp dsXNrVIo6SbGvKdHkjZOZlaR1Iw4CHgdFy6mb7OsCUTRn9HsDC4vlYHFXW6+UuWc7rxQ CpkvL+KIOUr+2+yVNSfbRRmyEZYI6ojjNvoqqHQx+zZCML765iN3UdwEl6OX3ax5bhiW PFOg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j66Tt2tQscl56y0FlB5Ti2Jn/NSmpakxSMgIXDUUHUY=; b=icB3rlAwyjJS/JPn+B1L4BHA3thkeczfOMrw1fFC6jMsaJ5qlQMqi+Auy4ZikW6wu+ hwPUfayHaO+XdbjrbUXrs8KEO666f0Y/LvI4B6cwULxKhTtJny5VsSgPC26irVdYFBN8 CKye8AKuHOoMTS5Ag5fwrx8kBHzMP86Kd0gXPQjWBIegXyTDGUQKJM2A+8XU9YnGNStY dmcuLsDZWDeshvQjt1LJ0yI3MVoA/sXtooddbZ/wjmrkDHmVGm0qPYIHlEm8LUPCm/47 ALkgKsPPJLvbazX2uEX/ibkxnLWO7nLZlu2ZUd4UVYy+KHbZbH9a1Kgl+EC2Raz1hRDf Y1Wg==
X-Gm-Message-State: APjAAAWm2DJ9wEA8KbOdvFMQkZjXItKWB/4mouJIKc7cP1tEWmj1WNKQ B4lJs4oAeyQ/eIMzzC39nPeM+a30SQnGVe6ZCWQ=
X-Google-Smtp-Source: APXvYqynK70qZHp0GCcsEkY9Uoi8ZzLEy+uPzzAib5+5LwFrvhAnjQ9D0oya/Dxdvtk9QxSaf7sK/hgKn/xRnaOM2V4=
X-Received: by 2002:a19:c813:: with SMTP id y19mr17651409lff.41.1573005741909; Tue, 05 Nov 2019 18:02:21 -0800 (PST)
MIME-Version: 1.0
References: <156175664267.21931.10329030969352120108@ietfa.amsl.com> <CAPK2DezmXhBA39GFMrU6tYFte_rDK+DE=WyWpzSNFMvnNU+xGQ@mail.gmail.com>
In-Reply-To: <CAPK2DezmXhBA39GFMrU6tYFte_rDK+DE=WyWpzSNFMvnNU+xGQ@mail.gmail.com>
From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Date: Wed, 6 Nov 2019 11:01:46 +0900
Message-ID: <CAPK2Deym5jVmi4JKekRVznpNCkO_x8PN7jz7DLXkgUNZ9V4uUw@mail.gmail.com>
To: Reshad Rahman <rrahman@cisco.com>
Cc: YANG Doctors <yang-doctors@ietf.org>, "i2nsf@ietf.org" <i2nsf@ietf.org>, draft-ietf-i2nsf-registration-interface-dm.all@ietf.org, Sangwon Hyun <swhyun77@gmail.com>, skku-iotlab-members@googlegroups.com, "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Content-Type: multipart/alternative; boundary="00000000000079eb390596a3f08b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/CQIStTn46Mlp4ZbHNT1rA9XcqQw>
Subject: Re: [yang-doctors] [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-registration-interface-dm-04
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Nov 2019 02:02:50 -0000

Hi Reshad,
I believe that I have addressed your comments on I2NSF Registration
Interface Data Model:
https://tools.ietf.org/html/draft-ietf-i2nsf-registration-interface-dm-05

If you are satisfied with the revision, could you update the Review result
in the following page?
https://datatracker.ietf.org/doc/review-ietf-i2nsf-registration-interface-dm-04-yangdoctors-lc-rahman-2019-06-28/

Thanks.

Best Regards,
Paul


On Thu, Jul 25, 2019 at 11:23 PM Mr. Jaehoon Paul Jeong <
jaehoon.paul@gmail.com>; wrote:

> Hi Reshad,
> Here is the revision letter for the revised draft, reflecting your
> comments along with the revised draft:
> https://tools.ietf.org/html/draft-ietf-i2nsf-registration-interface-dm-05
>
> If you have further comments and questions, please let me know.
>
> Thanks.
>
> Best Regards,
> Paul
>
> On Fri, Jun 28, 2019 at 5:17 PM Reshad Rahman via Datatracker <
> noreply@ietf.org>; wrote:
>
>> Reviewer: Reshad Rahman
>> Review result: On the Right Track
>>
>> YANG Doctor review of draft-ietf-i2nsf-registration-interface-dm-04 (by
>> Reshad
>> Rahman)
>>
>> Major comments:
>> - Look at appendix B of RFC8407 for an example of how a YANG module
>> should be
>> structured. This document does not abide to that. - Poor descriptions e.g.
>> "nsf-name" for leaf "nsf-name" etc - prefix "iiregi" doesn't seem right.
>> What
>> about "nsfreg"? Probably needs coordination with the other I2NSF YANG
>> modules
>> to have consistency between the prefixes. I see that YD Acee suggested
>> "nsfintf" for draft-ietf-i2nsf-nsf-facing-interface-dm-06 - No unit
>> specified
>> for bandwidth, processing (performance) - nsf-address is IPv4 specific -
>> Security considerations should list the nodes as per section 3.7 of
>> RFC8407. -
>> Should this document be informational since 8329 is informational? -
>> Section 2
>> should use RFC8174 also - Refer to RFC8407 instead of 6807 (YANG
>> Guidelines) -
>> Examples should use IPv6 as examples (use the range from RFC3849). Kudos
>> for
>> all the examples.
>>
>> Minor comments and questions:
>> - The YANG trees such as Figure 6, 7 etc don't show the contents of the
>> groupings. So they don't help much. - nsf-port-address should be
>> nsf-port? -
>> Section 4, last bullet. I am not an expert on I2NSF so not clear to me
>> why this
>> query is needed, is it because NSF may not re-register after their
>> capabilities
>> have been updated? Might be worth adding some explanation. - Have the
>> examples
>> been validated?
>>
>> _______________________________________________
>> I2nsf mailing list
>> I2nsf@ietf.org
>> https://www.ietf.org/mailman/listinfo/i2nsf
>>
>
>
> --
> ===========================
> Mr. Jaehoon (Paul) Jeong, Ph.D.
> Associate Professor
> Department of Software
> Sungkyunkwan University
> Office: +82-31-299-4957
> Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
> Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
> <http://cpslab.skku.edu/people-jaehoon-jeong.php>
>


-- 
===========================
Mr. Jaehoon (Paul) Jeong, Ph.D.
Associate Professor
Department of Software
Sungkyunkwan University
Office: +82-31-299-4957
Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
<http://cpslab.skku.edu/people-jaehoon-jeong.php>