IETF Logo Mail Archive

[yang-doctors] 答复: Yangdoctors last call review of draft-ietf-ccamp-l1csm-yang-15

Zhenghaomian <zhenghaomian@huawei.com> Thu, 09 December 2021 14:50 UTC

Return-Path: <zhenghaomian@huawei.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8DE1E3A0D38; Thu, 9 Dec 2021 06:50:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fUm-FeWWOs6I; Thu, 9 Dec 2021 06:50:16 -0800 (PST)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7B8D13A0D3A; Thu, 9 Dec 2021 06:50:16 -0800 (PST)
Received: from fraeml738-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4J8xjf17Hfz67KRx; Thu, 9 Dec 2021 22:48:22 +0800 (CST)
Received: from canpemm500010.china.huawei.com (7.192.105.118) by fraeml738-chm.china.huawei.com (10.206.15.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 9 Dec 2021 15:50:12 +0100
Received: from canpemm500009.china.huawei.com (7.192.105.203) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 9 Dec 2021 22:50:10 +0800
Received: from canpemm500009.china.huawei.com ([7.192.105.203]) by canpemm500009.china.huawei.com ([7.192.105.203]) with mapi id 15.01.2308.020; Thu, 9 Dec 2021 22:50:10 +0800
From: Zhenghaomian <zhenghaomian@huawei.com>
To: Joe Clarke <jclarke@cisco.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "ccamp@ietf.org" <ccamp@ietf.org>, "draft-ietf-ccamp-l1csm-yang.all@ietf.org" <draft-ietf-ccamp-l1csm-yang.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Yangdoctors last call review of draft-ietf-ccamp-l1csm-yang-15
Thread-Index: AQHX5SbJ2DEst/C5Rkmr7O9Mu05p/qwqTQQQ
Date: Thu, 9 Dec 2021 14:50:09 +0000
Message-ID: <24f4817e66ef425cbcb8e9494d614371@huawei.com>
References: <163819327359.330.16877162327268836589@ietfa.amsl.com>
In-Reply-To: <163819327359.330.16877162327268836589@ietfa.amsl.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.45.87.53]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/D3DVgChOVFUPe36GAdBFf6z4NIA>
Subject: [yang-doctors] =?utf-8?b?562U5aSNOiBZYW5nZG9jdG9ycyBsYXN0IGNh?= =?utf-8?q?ll_review_of_draft-ietf-ccamp-l1csm-yang-15?=
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Dec 2021 14:50:22 -0000

Hi Joe, 

Thank you very much for the review and useful comments. We are accepting all the proposals and please check the diffs from https://github.com/haomianzheng/IETF-ACTN-YANG-Model/pull/91/files.  

We plan to update the draft with latest yang/tree in a week, thanks. 

Best wishes,
Haomian

-----邮件原件-----
发件人: Joe Clarke via Datatracker [mailto:noreply@ietf.org] 
发送时间: 2021年11月29日 21:41
收件人: yang-doctors@ietf.org
抄送: ccamp@ietf.org; draft-ietf-ccamp-l1csm-yang.all@ietf.org; last-call@ietf.org
主题: Yangdoctors last call review of draft-ietf-ccamp-l1csm-yang-15

Reviewer: Joe Clarke
Review result: Ready with Nits

I have been asked to review this draft and the L1CSM YANG module it includes on behalf of YANG Doctors.  Overall, I think the draft/module is ready, but I did find a few small issues.  First, please run "pyang -f yang" on this to normalize its formatting.  There were a few spacing and other formatting issues that will be cleaned up by doing this.  Other items are below:

In the header of the YANG module, you import ietf-layer1-types with a mark of RFCYYYY.  In your comment below calling out RFCXXXX (i.e., this RFC) it would be good to point the RFC Editor to YYYY as well.

===

In your identity definition section, you have a number of identity descriptions which are self-referential.  Admittedly, this is one of my pet peeves, but if you could add more clarifying description text to identities such as one-way-delay, one-way-errored-second, etc. it would help implementors and operators better consume the YANG module without always needing to refer to external references.

===

Can time-interval be uint32 instead of int?  I do not thing a negative time interval is possible/useful here.

===

The description of the grouping subscriber-l1vc-sls-service-attributes doesn't look accurate.  This is not a value per se, but a collection of attributes.

===

In the /services/service list you explicitly have "mandatory true" for the key service-id.  This is not needed since the key is mandatory.

v2.8.7 | Report a Bug | By Email