Re: [yang-doctors] [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-registration-interface-dm-04

"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> Thu, 25 July 2019 14:24 UTC

Return-Path: <jaehoon.paul@gmail.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 618F9120153; Thu, 25 Jul 2019 07:24:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.488
X-Spam-Level:
X-Spam-Status: No, score=-0.488 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HK_NAME_FM_MR_MRS=1.499, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_FREEMAIL_DOC_PDF=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n7epbBAF1RR5; Thu, 25 Jul 2019 07:24:29 -0700 (PDT)
Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 99A4912008B; Thu, 25 Jul 2019 07:24:28 -0700 (PDT)
Received: by mail-wm1-x334.google.com with SMTP id p74so45154872wme.4; Thu, 25 Jul 2019 07:24:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KJh/KrjueSuMmGhcPj3w37lXHgxnWvKKxUR3b8JcNnY=; b=paYWMK2/TQHr367rCSd3H+mWMPoekpnLcCDWxkZwWe2T3N0A8d1u5g1QlXXHOwQZky jG+t30KStAp0PbzBz5Sl0oPlikJuEs+AcHJEzIWmDTAc2rLqkoKAwRn3hZUhL0M+ZY8A Sh3qB7iIHGmqlAt4bEt8zOjzJx1YKYHSwnj8ONwfQJW2Nmgi9nl1a937hFIHTOgYPT0w /pUuWcNv4jsDhOjVn8n/sl1uDHVwO4bzGXdAwomFSQKsTW61bNw6Z8oOLr0gzHl6iI4w XsWdx2pe93Ir+sBTYZv5Ty7RMu0A3ATeZG60ufFQ7c0Ffg49CE6P3zNdgSDyyAnaIdKE owDw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KJh/KrjueSuMmGhcPj3w37lXHgxnWvKKxUR3b8JcNnY=; b=mE57xM2W4bpDTW8oK9pVwQqj9LQZXGg7+hJL8X8MQz6F8Jh0TK30a7mcCg8UqZ1NNH kdamMlXrO8c8mDEwSZtTH4ZnQ9OsEJwlUyN+rBRWbyyVVIql26b68xVUZMwqmOna0IfI jJJg/8gXnsx2q1ah5FpUVffqGEOgeakfnpwYTwXudRRAjtzNr0kQtXLM2gOM+kzVSei5 xPh8xEIwsGIF9NpR5u2ZfqVs6iToRb4jMTYNwNB59zL66JnsCqa1YXC/PTU2E9zpmUyb xNet3PiuIK1tRsOd0/idjrd9ifQQRm2FU9nwhQe5okDUJXr21nNwlxueVx1i4ejBDhCD XSkw==
X-Gm-Message-State: APjAAAU5eDWFNqN3DquOc+1ufJpzeRbP8iC+j6C3dSyEN1CLonQz9kCy Oh0OEh418fWx3nLcGtVcFX/Q07HVXMHWNLreaNs=
X-Google-Smtp-Source: APXvYqxj9m9dHrTIcDbSbh+Fq9pg40/KMAQgS0h0L4DG6xkzY1q+eAJqrqzEZRmvyIug4ebcvIW6qfRWkMGGS+YxAKA=
X-Received: by 2002:a1c:9813:: with SMTP id a19mr77986934wme.11.1564064666537; Thu, 25 Jul 2019 07:24:26 -0700 (PDT)
MIME-Version: 1.0
References: <156175664267.21931.10329030969352120108@ietfa.amsl.com>
In-Reply-To: <156175664267.21931.10329030969352120108@ietfa.amsl.com>
From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Date: Thu, 25 Jul 2019 10:23:47 -0400
Message-ID: <CAPK2DezmXhBA39GFMrU6tYFte_rDK+DE=WyWpzSNFMvnNU+xGQ@mail.gmail.com>
To: Reshad Rahman <rrahman@cisco.com>
Cc: YANG Doctors <yang-doctors@ietf.org>, "i2nsf@ietf.org" <i2nsf@ietf.org>, draft-ietf-i2nsf-registration-interface-dm.all@ietf.org, skku_secu-brain_all@googlegroups.com, "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000db35d3058e822ed7"
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/DFbQJzgOvJgPszj11a3-6oPE2Vg>
Subject: Re: [yang-doctors] [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-registration-interface-dm-04
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jul 2019 14:24:33 -0000

Hi Reshad,
Here is the revision letter for the revised draft, reflecting your comments
along with the revised draft:
https://tools.ietf.org/html/draft-ietf-i2nsf-registration-interface-dm-05

If you have further comments and questions, please let me know.

Thanks.

Best Regards,
Paul

On Fri, Jun 28, 2019 at 5:17 PM Reshad Rahman via Datatracker <
noreply@ietf.org>; wrote:

> Reviewer: Reshad Rahman
> Review result: On the Right Track
>
> YANG Doctor review of draft-ietf-i2nsf-registration-interface-dm-04 (by
> Reshad
> Rahman)
>
> Major comments:
> - Look at appendix B of RFC8407 for an example of how a YANG module should
> be
> structured. This document does not abide to that. - Poor descriptions e.g.
> "nsf-name" for leaf "nsf-name" etc - prefix "iiregi" doesn't seem right.
> What
> about "nsfreg"? Probably needs coordination with the other I2NSF YANG
> modules
> to have consistency between the prefixes. I see that YD Acee suggested
> "nsfintf" for draft-ietf-i2nsf-nsf-facing-interface-dm-06 - No unit
> specified
> for bandwidth, processing (performance) - nsf-address is IPv4 specific -
> Security considerations should list the nodes as per section 3.7 of
> RFC8407. -
> Should this document be informational since 8329 is informational? -
> Section 2
> should use RFC8174 also - Refer to RFC8407 instead of 6807 (YANG
> Guidelines) -
> Examples should use IPv6 as examples (use the range from RFC3849). Kudos
> for
> all the examples.
>
> Minor comments and questions:
> - The YANG trees such as Figure 6, 7 etc don't show the contents of the
> groupings. So they don't help much. - nsf-port-address should be nsf-port?
> -
> Section 4, last bullet. I am not an expert on I2NSF so not clear to me why
> this
> query is needed, is it because NSF may not re-register after their
> capabilities
> have been updated? Might be worth adding some explanation. - Have the
> examples
> been validated?
>
> _______________________________________________
> I2nsf mailing list
> I2nsf@ietf.org
> https://www.ietf.org/mailman/listinfo/i2nsf
>


-- 
===========================
Mr. Jaehoon (Paul) Jeong, Ph.D.
Associate Professor
Department of Software
Sungkyunkwan University
Office: +82-31-299-4957
Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
<http://cpslab.skku.edu/people-jaehoon-jeong.php>