Re: [yang-doctors] [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-registration-interface-dm-04

"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> Sat, 29 June 2019 03:29 UTC

Return-Path: <jaehoon.paul@gmail.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 118F6120967; Fri, 28 Jun 2019 20:29:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.498
X-Spam-Level:
X-Spam-Status: No, score=-0.498 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HK_NAME_FM_MR_MRS=1.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SNq4K2dLia7l; Fri, 28 Jun 2019 20:29:15 -0700 (PDT)
Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7AC8B12092D; Fri, 28 Jun 2019 20:29:12 -0700 (PDT)
Received: by mail-wm1-x32f.google.com with SMTP id c6so10678987wml.0; Fri, 28 Jun 2019 20:29:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uyMuTwowzVn1HKDAk57aaSaM+cuoayqjx+EzA+g0Wrg=; b=eeSxn1+XEc99ncdG6DHr80kQYEh7wYVKzIMht1O/MqWhJkl8yHeY2K9qSvrghmzz7C W1aHxzAbZNhbWSTUpXzuzyAPztUWTbwFtadGNz3w53jTnb1Ju25y1yAbEAVmsF9tdF3U sDEjdhJeH9RSOzFO8an3iLhlbPC8/vARtaFz68DiN6MAtY7HoMd1waVk+D8cMvsR70zF 5nrK53FohWvNDfbEi0Sm+OMEPOl6bpXk6OL0UQ2StmJ1fw3tYgZgk3SgU4t+XkBD7kOd Aj+sOe8OkGEpqJrLCoaqW4K1vmXE3ldMc6KdiBxRmzQ/DndUVh61nb8AGZx2/XDih/IH snGA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uyMuTwowzVn1HKDAk57aaSaM+cuoayqjx+EzA+g0Wrg=; b=uGV++n0oSGKbMg4qOOk9Ofy5fILYx1Yi5faCP2tdlmzrqHkjTpvrNg+4iExzf6AcXt LgZtcHm2ZAzj4a7weTGxX17XNlXtQG3hxypBQlx5XJsUrsKQlJh4yO5m3uuxy89CBtWd 7OFnfQfboO/X1fWvRRskb7T8YdQkj4UMCgz2nKeh+kXLFa26Y1hRyRu/RghBdNA4hkz1 riYPMhe/6s0JxVNTwXlQcL6wctfYsF5QGYsGDVz87PZGzzqg+2PdICOXidcpPxYpdO1l /de5LWldFPHL0UloO5OgcpNrHjwcWXLJ8UkoTB5KMHYYDaxrW7zVToDd+JhIlOoM1D59 3XKw==
X-Gm-Message-State: APjAAAVzKL06GwXOWX3PteM2vp+0Zh4zRmH5u1d5JwiPpZ18PjJB+W6T fyN4HjIdJbsfq+GPRa0QmvJIHq1zRrwaBuGHizo=
X-Google-Smtp-Source: APXvYqz3vZXhk4uL+1AZCjDs7s9KKhKTneF3qt2Wr3OO6boaLoX40jiLaMty5DgrJmw+SglggOav+3fZAH60qTUCV58=
X-Received: by 2002:a1c:4987:: with SMTP id w129mr8933187wma.41.1561778950820; Fri, 28 Jun 2019 20:29:10 -0700 (PDT)
MIME-Version: 1.0
References: <156175664267.21931.10329030969352120108@ietfa.amsl.com>
In-Reply-To: <156175664267.21931.10329030969352120108@ietfa.amsl.com>
From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Date: Sat, 29 Jun 2019 12:34:15 +0900
Message-ID: <CAPK2DexBfxotU9=r-qN-PJovAVeAbUQYzTa6cCKSoLsuihx2HA@mail.gmail.com>
To: Reshad Rahman <rrahman@cisco.com>
Cc: YANG Doctors <yang-doctors@ietf.org>, "i2nsf@ietf.org" <i2nsf@ietf.org>, draft-ietf-i2nsf-registration-interface-dm.all@ietf.org, skku_secu-brain_all@googlegroups.com, "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Content-Type: multipart/alternative; boundary="00000000000094d999058c6dff53"
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/FfqTvPIf72jfpzqpoGR9qWZWveU>
Subject: Re: [yang-doctors] [I2nsf] Yangdoctors last call review of draft-ietf-i2nsf-registration-interface-dm-04
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Jun 2019 03:29:17 -0000

Hi Reshad,
I sincerely appreciate your valuable comments.

We authors will address your comments on the revision.

Thanks.

Best Regards,
Paul

On Sat, Jun 29, 2019 at 6:17 AM Reshad Rahman via Datatracker <
noreply@ietf.org>; wrote:

> Reviewer: Reshad Rahman
> Review result: On the Right Track
>
> YANG Doctor review of draft-ietf-i2nsf-registration-interface-dm-04 (by
> Reshad
> Rahman)
>
> Major comments:
> - Look at appendix B of RFC8407 for an example of how a YANG module should
> be
> structured. This document does not abide to that. - Poor descriptions e.g.
> "nsf-name" for leaf "nsf-name" etc - prefix "iiregi" doesn't seem right.
> What
> about "nsfreg"? Probably needs coordination with the other I2NSF YANG
> modules
> to have consistency between the prefixes. I see that YD Acee suggested
> "nsfintf" for draft-ietf-i2nsf-nsf-facing-interface-dm-06 - No unit
> specified
> for bandwidth, processing (performance) - nsf-address is IPv4 specific -
> Security considerations should list the nodes as per section 3.7 of
> RFC8407. -
> Should this document be informational since 8329 is informational? -
> Section 2
> should use RFC8174 also - Refer to RFC8407 instead of 6807 (YANG
> Guidelines) -
> Examples should use IPv6 as examples (use the range from RFC3849). Kudos
> for
> all the examples.
>
> Minor comments and questions:
> - The YANG trees such as Figure 6, 7 etc don't show the contents of the
> groupings. So they don't help much. - nsf-port-address should be nsf-port?
> -
> Section 4, last bullet. I am not an expert on I2NSF so not clear to me why
> this
> query is needed, is it because NSF may not re-register after their
> capabilities
> have been updated? Might be worth adding some explanation. - Have the
> examples
> been validated?
>
> _______________________________________________
> I2nsf mailing list
> I2nsf@ietf.org
> https://www.ietf.org/mailman/listinfo/i2nsf
>


-- 
===========================
Mr. Jaehoon (Paul) Jeong, Ph.D.
Associate Professor
Department of Software
Sungkyunkwan University
Office: +82-31-299-4957
Email: jaehoon.paul@gmail.com, pauljeong@skku.edu
Personal Homepage: http://iotlab.skku.edu/people-jaehoon-jeong.php
<http://cpslab.skku.edu/people-jaehoon-jeong.php>