Re: [yang-doctors] Yangdoctors early review of draft-ietf-opsawg-yang-vpn-service-pm-05
"Wubo (lana)" <lana.wubo@huawei.com> Wed, 13 April 2022 02:28 UTC
Return-Path: <lana.wubo@huawei.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A46EB3A1977; Tue, 12 Apr 2022 19:28:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.907
X-Spam-Level:
X-Spam-Status: No, score=-1.907 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dkobMncUIgr9; Tue, 12 Apr 2022 19:28:21 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BB0853A1975; Tue, 12 Apr 2022 19:28:21 -0700 (PDT)
Received: from fraeml736-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4KdRKV1LdYz67VMG; Wed, 13 Apr 2022 10:26:06 +0800 (CST)
Received: from kwepemi500011.china.huawei.com (7.221.188.124) by fraeml736-chm.china.huawei.com (10.206.15.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 13 Apr 2022 04:28:18 +0200
Received: from kwepemi500014.china.huawei.com (7.221.188.232) by kwepemi500011.china.huawei.com (7.221.188.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 13 Apr 2022 10:28:16 +0800
Received: from kwepemi500014.china.huawei.com ([7.221.188.232]) by kwepemi500014.china.huawei.com ([7.221.188.232]) with mapi id 15.01.2375.024; Wed, 13 Apr 2022 10:28:16 +0800
From: "Wubo (lana)" <lana.wubo@huawei.com>
To: Ladislav Lhotka <ladislav.lhotka@nic.cz>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "draft-ietf-opsawg-yang-vpn-service-pm.all@ietf.org" <draft-ietf-opsawg-yang-vpn-service-pm.all@ietf.org>, "opsawg@ietf.org" <opsawg@ietf.org>
Thread-Topic: Yangdoctors early review of draft-ietf-opsawg-yang-vpn-service-pm-05
Thread-Index: AQHYS0SDXsnFmRMkjk+xrAgqqeIr7qzsQhvA
Date: Wed, 13 Apr 2022 02:28:16 +0000
Message-ID: <416aa4b5a767495888b720de9955231a@huawei.com>
References: <164942105516.26234.8769974956037116940@ietfa.amsl.com>
In-Reply-To: <164942105516.26234.8769974956037116940@ietfa.amsl.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.136.98.73]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/J-C-KOsWuOQOdATfxmDj-Uylks8>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-opsawg-yang-vpn-service-pm-05
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Apr 2022 02:28:27 -0000
Hi Lada, Many thanks for your helpful review. We'll fix the errors in these examples in the next version. Please see inline for details. Thanks, Bo -----Original Message----- From: Ladislav Lhotka via Datatracker [mailto:noreply@ietf.org] Sent: Friday, April 8, 2022 8:31 PM To: yang-doctors@ietf.org Cc: draft-ietf-opsawg-yang-vpn-service-pm.all@ietf.org; opsawg@ietf.org Subject: Yangdoctors early review of draft-ietf-opsawg-yang-vpn-service-pm-05 Reviewer: Ladislav Lhotka Review result: Ready with Nits **** General comments The Internet-Draft contains a large YANG module that augments the network topology model with L2/L3 VPN performance monitoring statistics. The module is well designed and documented, I found no issues in it. Examples of JSON instance data are useful for readers of the I-D, but less so if they contain errors (see below). If possible, I'd suggest to validate the examples with appropriate tools, or at least carefully check after each change in the data model. **** Specific comments ***** Section 5 - File name in <CODE BEGINS> line should be ...@2022-04-08.yang Bo Wu: Fixed. ***** Appendix A.2 - module "ietf-network-topo" doesn't exist, should it be "ietf-network"? Bo Wu: Yes. Thanks for pointing this out. ***** Appendix A.3 - leaf "middle-percentile" should probably be "intermediate-percentile". - leaf "unit-values" should be "unit-value" - The leaf "ietf-network-vpn-pm:inter-vpn-access-interface" is illegal (probably misplaced) Bo Wu: Thanks for catching this. We sill fix these.
- [yang-doctors] Yangdoctors early review of draft-… Ladislav Lhotka via Datatracker
- Re: [yang-doctors] Yangdoctors early review of dr… Wubo (lana)