Re: [yang-doctors] Yangdoctors last call review of draft-ietf-bfd-yang-09

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Tue, 20 March 2018 13:06 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B0B6F1270AE; Tue, 20 Mar 2018 06:06:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.531
X-Spam-Level:
X-Spam-Status: No, score=-14.531 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DfyKwYn8xjFf; Tue, 20 Mar 2018 06:06:29 -0700 (PDT)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0E11D124B17; Tue, 20 Mar 2018 06:06:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=16880; q=dns/txt; s=iport; t=1521551189; x=1522760789; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=RowQVGXgEXUpqqVFK0NTdVD1G4ywO12jyOKSc7hX2Bg=; b=ceam4Se4f5uPoznK2ClUz4LV5xTyeIN7vNIKXsc/o/N/WDiDGrWLhyWO cAYSzm3zn5h7A9wsOiMefkNp/eqHXLDePzitWi5Z3i5zIH7esdpt/UPIA f7WHlo7Sbh/gFSXcBSUsxfrdfWKmKdUjbKWuDwbMZ6GDM+22hahDbMuJQ E=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AEAQBVBrFa/4QNJK1aAxkBAQEBAQEBA?= =?us-ascii?q?QEBAQEHAQEBAQGDUGZyKAqDU4odjX6CA4EWlAeCEgsjhG4CGoMyITQYAQIBAQE?= =?us-ascii?q?BAQECayiFJgEFI1YOAgIBBgIOAgIGKgICAhkXFw4CBA4FDoUMD40Em0CCJohbg?= =?us-ascii?q?X8PBYUyghWBVYFUKIJ4gx4BAQIBAReBYgoZBAmCQTCCESADjDuFA4Z/CQKDWoI?= =?us-ascii?q?ziSuBTkCDPYdrh0OBcYZfAhETAYEpAR44gVJwFRlLAYIYCYIpG44edAGOHiyBA?= =?us-ascii?q?4EYAQEB?=
X-IronPort-AV: E=Sophos;i="5.48,335,1517875200"; d="scan'208";a="86683706"
Received: from alln-core-10.cisco.com ([173.36.13.132]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2018 13:06:28 +0000
Received: from XCH-ALN-001.cisco.com (xch-aln-001.cisco.com [173.36.7.11]) by alln-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id w2KD6SXF002531 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 20 Mar 2018 13:06:28 GMT
Received: from xch-rcd-005.cisco.com (173.37.102.15) by XCH-ALN-001.cisco.com (173.36.7.11) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 20 Mar 2018 08:06:27 -0500
Received: from xch-rcd-005.cisco.com ([173.37.102.15]) by XCH-RCD-005.cisco.com ([173.37.102.15]) with mapi id 15.00.1320.000; Tue, 20 Mar 2018 08:06:27 -0500
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
CC: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "rtg-bfd@ietf.org" <rtg-bfd@ietf.org>, "draft-ietf-bfd-yang.all@ietf.org" <draft-ietf-bfd-yang.all@ietf.org>
Thread-Topic: Yangdoctors last call review of draft-ietf-bfd-yang-09
Thread-Index: AQHTpkBKVunZZ+hp3EiObmH4QVr8yqOyUdqAgAMdoICACtpxgIAOdPYAgAqd34A=
Date: Tue, 20 Mar 2018 13:06:27 +0000
Message-ID: <5A6DEA92-C05C-476C-8CE0-F314E88D1ACF@cisco.com>
References: <151868731494.7525.9572645824096052010@ietfa.amsl.com> <6A04AE1F-F538-40CD-BFB4-3452B50C7F9D@cisco.com> <9A6B372F-2FD1-409A-BF3B-AFF48D1E74B4@cisco.com> <F5EE16C2-B4E3-4B0A-835F-EB729900323E@cisco.com> <20180313145844.c5zz27p6tscl7me6@elstar.local>
In-Reply-To: <20180313145844.c5zz27p6tscl7me6@elstar.local>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.a.0.180210
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.86.245.146]
Content-Type: multipart/mixed; boundary="_002_5A6DEA92C05C476C8CE0F314E88D1ACFciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/KIqT7YVUDmxobydnePv-JeTyk80>
Subject: Re: [yang-doctors] Yangdoctors last call review of draft-ietf-bfd-yang-09
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Mar 2018 13:06:35 -0000

Hi Juergen,

Thanks again for the excellent review. We've just published rev12 to address your latest comments.

Please see inline.

Regards,
Reshad.

On 2018-03-13, 10:58 AM, "Juergen Schoenwaelder" <j.schoenwaelder@jacobs-university.de> wrote:

    On Sun, Mar 04, 2018 at 02:12:30PM +0000, Reshad Rahman (rrahman) wrote:
    > 
    > We have made the changes in revs 10 and 11 to address your comments . The exception is module ietf-bfd-types which did not get renamed per reason below.
    >
    
    Hi,
    
    here is my re-review of draft-ietf-bfd-yang. I think the document has
    significantly improved since the -09 version, the authors have done an
    excellent job to improve the document quality.
    
    I have mostly a few minor mostly editorial issues left, except the
    first one, which concerns the schema mount use case.
    
    - Thanks for clarifying that the modules can be used on standalone
      devices. The new text is helpful.
    
      For the LNE and NI use cases, does it make sense to detail the mount
      points that are used? My understanding is that schema mount requires
      that mount points are identified with a "mount-point" extension
      statement, i.e., you can't mount at arbitrary places in the
      hierarchy but only at places that have been designated as mount
      points.
    
      That all said, since your YANG modules are basically augmenting
      other YANG modules that may be mounted, you do not seem to need a
      separate schema mount. If my understanding is correct, then here is
      a starting point for making this clearer:
    
      OLD
    
        When used at the network device level, the BFD YANG model is used
        "as-is".  When the BFD model is to be used in a Logical Network
        Element or in a Network Instance, the approach taken is to do a
        schema-mount (see Schema Mount [I-D.ietf-netmod-schema-mount]) of the
        BFD model in the appropriate location.  For example, if an
        implementation supports BFD IP multihop in network instances, the
        implementation would do schema-mount of the BFD IP multihop model in
        a mount-point which resides in a network instance.
    
      NEW
    
        When used at the network device level, the BFD YANG model are used
        "as-is".  When the BFD YANG model is used in a Logical Network
        Element or in a Network Instance, then the BFD YANG model augments
        the mounted routing model for the Logical Network Element or the
        Network Instance.
    
      Note that with this change, you also do not need a reference to
      schema mount.
<RR> Done.
      
    - Since the different use cases (device, LNE, NI) are discussed right
      at the beginning of Section 2, it seems the following statements in
      Sections 2.5, 2.6, 2.7, 2.8, 2.9 are not really needed:
    
                                       The "bfd" node under control-plane-
       protocol can be used in a network device (top-level), or mounted in
       an LNE or in a network instance.
    
                                                The "ip-sh" node can be used
       in a network device (top-level), or mounted in an LNE or in a network
       instance.
    
                                                                The "ip-mh"
       node can be used in a network device (top-level), or mounted in an
       LNE or in a network instance.
    
                                  The "lag" node can be used in a network
       device (top-level), or mounted in an LNE or in a network instance.
    
                                                                 The "mpls"
       node can be used in a network device (top-level), or mounted in an
       LNE or in a network instance.
<RR> Done
    
    - The text at the beginning of Section 2.13 should also mention RFC
      8177 since you are importing it.
<RR> Done

    - It might be useful to give more explicit instructions to IANA. I
      assume you want IANA to update the iana-bfd-types module whenever
      changes are made to the "BFD Diagnostic Codes" registry and "BFD
      Authentication Types" registries. Giving clear instructions what
      IANA is expected to do and when is better than a soft statement such
      as "intended to reflect". But IANA is going to ask questions about
      this anyway during their review I assume.
<RR> Updated 5.1
    
    - The feature definitions in ietf-bfd-types have text of the form "as
      defined in RFC 5880" and perhaps it makes sense to add reference
      statements to these feature definitions. There are also a number of
      identities that say "as per RFC 588X" where perhaps reference
      statements should be added.
<RR> Added reference sections to the feature definitions and identities.
    
    - The text at the beginning of Section 2.13 should also	mention	RFC
      6991 since you are importing it. And you are also importing from
      RFC XXXX (the routing model).
<RR> 2.13 already mentions RFC 6991 but it was missing from 2.15 and 2.17 (it's been added). 2.13 already has mention of 8022bis (routing model). 8022bis is now rfc8349.

    - The text at the beginning of Section 2.16 should also mention
      that you import from RFC XXXX (the routing model).
<RR> We now mention rfc8349 (8022bis).
    
    - The text at the beginning of Section 2.17 should also mention that
      you import from RFC 6991 and from RFC XXXX (the routing model).
<RR> Added mention of RFC6991.
    
    - The text at the beginning of Section 2.18 should also mention that
      you import from RFC XXXX (the routing model).
<RR> We now mention rfc8349  (8022bis).
    
    - The text at the beginning of Section 2.19 should also mention that
      you import from RFC XXXX (the routing model).
<RR> We now mention rfc8349   (8022bis).
    
    - I have not validated the examples - I hope the authors have done so.
      They look more plausible than in the previous version I reviewed.
<RR> Yes we have validated them using yanglint.
    
    /js
    
    -- 
    Juergen Schoenwaelder           Jacobs University Bremen gGmbH
    Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
    Fax:   +49 421 200 3103         <https://www.jacobs-university.de/>
    

--- Begin Message ---
A new version of I-D, draft-ietf-bfd-yang-12.txt
has been successfully submitted by Reshad Rahman and posted to the
IETF repository.

Name:		draft-ietf-bfd-yang
Revision:	12
Title:		YANG Data Model for Bidirectional Forwarding Detection (BFD)
Document date:	2018-03-20
Group:		bfd
Pages:		74
URL:            https://www.ietf.org/internet-drafts/draft-ietf-bfd-yang-12.txt
Status:         https://datatracker.ietf.org/doc/draft-ietf-bfd-yang/
Htmlized:       https://tools.ietf.org/html/draft-ietf-bfd-yang-12
Htmlized:       https://datatracker.ietf.org/doc/html/draft-ietf-bfd-yang
Diff:           https://www.ietf.org/rfcdiff?url2=draft-ietf-bfd-yang-12

Abstract:
   This document defines a YANG data model that can be used to configure
   and manage Bidirectional Forwarding Detection (BFD).

   The YANG modules in this document conform to the Network Management
   Datastore Architecture (NMDA).

                                                                                  


Please note that it may take a couple of minutes from the time of submission
until the htmlized version and diff are available at tools.ietf.org.

The IETF Secretariat


--- End Message ---