Re: [yang-doctors] Yangdoctors early review of draft-ietf-lime-yang-connection-oriented-oam-model-03

wangzitao <wangzitao@huawei.com> Tue, 23 January 2018 03:17 UTC

From: wangzitao <wangzitao@huawei.com>
To: Carl Moberg <calle@tail-f.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "draft-ietf-lime-yang-connection-oriented-oam-model.all@ietf.org" <draft-ietf-lime-yang-connection-oriented-oam-model.all@ietf.org>, "lime@ietf.org" <lime@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Thread-Topic: Yangdoctors early review of draft-ietf-lime-yang-connection-oriented-oam-model-03
Thread-Index: AdOT9mRYUEM4j8ZmSyWkLn5SZj+pgg==
Date: Tue, 23 Jan 2018 03:17:05 +0000
Message-ID: <E6BC9BBCBCACC246846FC685F9FF41EA2B8B085D@DGGEML504-MBS.china.huawei.com>
Accept-Language: en-US
Content-Language: zh-CN
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/Kh-PVOD-yYgldZMVEsugu-E9o2M>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-lime-yang-connection-oriented-oam-model-03
Precedence: list

Hi Carl,
Thank you for these good comments!
Please find my reply in-line.

Best Regards!
-Michael

-----邮件原件-----
发件人: Carl Moberg [mailto:calle@tail-f.com]
发送时间: 2018年1月23日 7:00
收件人: yang-doctors@ietf.org
抄送: draft-ietf-lime-yang-connection-oriented-oam-model.all@ietf.org; lime@ietf.org; ietf@ietf.org
主题: Yangdoctors early review of draft-ietf-lime-yang-connection-oriented-oam-model-03

Reviewer: Carl Moberg
Review result: On the Right Track

This is my review of draft-ietf-lime-yang-connection-oriented-oam-model-03 and the included YANG module.

Overall, the document is in reasonable shape but needs more attention around one fundamental aspect, and a short list of minor issues.

My understanding is that this module is intended to be implemented as a network service model, per the module classification RFC (RFC8199). But e.g. the ‘mip'
list has a key 'interface' of type 'if:interface-ref'. That type is defined in ietf-interfaces to be a leafref with path "/if:interfaces/if:interface/if:name”
assuming that the module context is a single network element. This seems self-contradicting and needs to be resolved.

+++Michael: agree. The 'interface' may not enough to distinguish different MIPs. We will fix it in next version, and may be define an "id" as the key.

I would suggest running the YANG module through 'pyang -f yang' to provide consistent formatting of the module. I think it would also be worth considering putting the content in the canonical order. E.g. the location of the description statement in the mip-address grouping makes it hard to read.

+++Michael: OK. Will improve it.

The 'session' list is 'ordered-by user', but does not provide any description or explanation to the meaning of the order.

+++Michael: agree. Will remove it in next version.

The content of the description strings are in need of language fixes.

+++Michael: OK. Will improve it.

[yang-doctors] Yangdoctors early review of draft-… Carl Moberg
Re: [yang-doctors] Yangdoctors early review of dr… wangzitao