Re: [yang-doctors] Yangdoctors early review of draft-ietf-opsawg-mud-08
Eliot Lear <lear@cisco.com> Tue, 22 August 2017 14:03 UTC
Return-Path: <lear@cisco.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 415C113239C; Tue, 22 Aug 2017 07:03:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 182b4q95RZPe; Tue, 22 Aug 2017 07:03:18 -0700 (PDT)
Received: from aer-iport-1.cisco.com (aer-iport-1.cisco.com [173.38.203.51]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 49FA8132256; Tue, 22 Aug 2017 07:03:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=6478; q=dns/txt; s=iport; t=1503410597; x=1504620197; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to; bh=d9d8Mq96mwc9t/tmEaS5iAXD1bie9SbJJQB/mbuueU8=; b=RsI6h5muAOtBGwJXm4YAlbkNQ+Znb7vXTr5GNebWQC+wb3J/zZ25VtyF 8SFSkphIDJTaVEb2FUr+x4VyhTu6y6vD0BZ8YUVS43F8Q+ivcCn71HDkd dZGZakCWsNbKi/vi7cwkYp8vUS6i2DHYzt6nFnZqWYYjf6+VBZm8cMUNe M=;
X-Files: signature.asc : 481
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DYAABKOJxZ/xbLJq1cGgEBAQECAQEBAQgBAQEBk2Z0kHAilh+CEgeFQAKEYxgBAgEBAQEBAQFrKIUZAQUjVhALDgoqAgJXBgEMCAEBii2sVoImi10BAQEBAQEBAQEBAQEBAQEBAQERD4MqhTErC4JxhEwRgymCQh8FigqHEI87hDOCIYRWiRmLSocWlikfOIEKMiEIHBVJhxw+iQqCQQEBAQ
X-IronPort-AV: E=Sophos;i="5.41,412,1498521600"; d="asc'?scan'208";a="696684402"
Received: from aer-iport-nat.cisco.com (HELO aer-core-1.cisco.com) ([173.38.203.22]) by aer-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2017 14:03:12 +0000
Received: from [10.61.78.225] (ams3-vpn-dhcp3809.cisco.com [10.61.78.225]) by aer-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id v7ME3COT012371; Tue, 22 Aug 2017 14:03:12 GMT
To: Martin Bjorklund <mbj@tail-f.com>, yang-doctors@ietf.org
Cc: draft-ietf-opsawg-mud.all@ietf.org, opsawg@ietf.org
References: <150340909415.6001.14045177084948571272@ietfa.amsl.com>
From: Eliot Lear <lear@cisco.com>
Message-ID: <b391f249-b88c-8412-b59d-54c8a16e3fde@cisco.com>
Date: Tue, 22 Aug 2017 16:03:13 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <150340909415.6001.14045177084948571272@ietfa.amsl.com>
Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="akLgnsE2FgsC8XkWr2VSJDKJHqoeJROo5"
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/MpiKCx6I0lTtqivjA92vQ1Fhwmc>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-opsawg-mud-08
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Aug 2017 14:03:21 -0000
Thanks, Martin, for your timely review. We'll sort through the issues and come back to the group and to you. Eliot On 8/22/17 3:38 PM, Martin Bjorklund wrote: > Reviewer: Martin Bjorklund > Review result: Ready with Issues > > Hi, > > I am the assigned YANG doctors reviewer for this document. Here are > my comments: > > > o Section 2 says: > > The MUD file is limited to the serialization of a > small number of YANG schema, including the models specified in the > following documents: > > o [I-D.ietf-netmod-acl-model] > > o [RFC6991] > > Is the intention that *only* these models are included, or *at > least* these models are included? > > RFC6991 doesn't define any data nodes, so I don't think it needs to > be listed. I suggest you are a bit more specific, and list: > > o ietf-access-control-list [I-D.ietf-netmod-acl-model] > > o ietf-mud [...] > > > o Section 3 uses the term "element" (it is used in other places as > well). YANG uses the term "data node" or "node". Or "YANG data > node". I suggest you use one of these terms, and import the term > in your Terminology section. > > Also, the YANG module uses the term "element" to refer to "device": > > leaf is-supported { > type boolean; > description > "The element is currently supported > by the manufacturer."; > } > > > o In your Terminology section you introduce the term "Thing". But > the text often use "device". Maybe use "device" consistently? > > > o In order to get consistent indentation of the YANG modules, I > suggest you run: > > pyang -f yang ietf-mud.yang > > (and same for ietf-acldns.yang) > > > o Ensure that description statements contain proper sentences. Also > ensure that the descriptions are descriptive. As an example of the > latter, this is not a good description: > > description > "Which way are we talking about?"; > > In general, I found that the main document had better descriptions > than the YANG module. Consider moving the text from the main > document to the YANG module (this also reduces the risk of > inconsistencies). If don't want to move text, I think you need to > spend some effort on almost all descriptions in the YANG module. > > > o In both modules, make sure you have a single revision > statement. Note that in IETF-terms, a revision statement is added > when a new version of the module is publsihed as an RFC (so the > initial RFC would have one revision statement). > > > o The "ietf-mud" module is a bit unorthodox; it defines configuration > data nodes, but it is not supposed to be implemented by a normal > NETCONF/RESTCONF server. Rather, it will be instantiated in a JSON > file. I think this should be stated in the description of the > module. > > > o I don't think the feature "mud-acl" is necessary. It is only used > to make the acl augment conditional on the feature. I think that > if this module is supported, the feature is also supported. Or do > you envision implementations of this module that would not support > this feature? If so, maybe you can explain that use case in the > document. > > > o leaf cache-validity could use a "units" statement: > > units "hours"; > > > o I suggest you rename the grouping "access_lists" to "access-lists" > for consitency. > > > o Should any of the leafs in "/metainfo" be mandatory? > > > o The "extensions" leaf-list mentions an IANA registry for > extensions. It would be usefule to mention this registry by name. > > Also, shouldn't this registry be defined in the IANA Considerations > section? > > > o Section 3.7 mentions a leaf "packet-direction". There is no such > leaf in the YANG module. There is one called "direction-initiated" > though. > > But since the "/device" container contains two different ACL sets, > one for "to" and one for "from", is this augmentation really > necessary? > > > o The model has: > > leaf local-networks { > type empty; > description > "this string is used to indicate networks > considered local in a given environment."; > > This leaf is of type "empty", but the description says it is a > string. > > Also, what is the format of this string? (Hmm, I think the > description is wrong, this should indeed be type empty). > > > o Would it be useful with an indication of the revision of "ietf-mud" > that is used as the schema for a MUD file? I.e., something like a > leaf "mud-module-revision" in the "metainfo" container. > > > o The example in section 8 has some errors, e.g., it has some > camelCase node names. > > >
- [yang-doctors] Yangdoctors early review of draft-… Martin Bjorklund
- Re: [yang-doctors] Yangdoctors early review of dr… Eliot Lear
- Re: [yang-doctors] Yangdoctors early review of dr… Martin Bjorklund
- Re: [yang-doctors] Yangdoctors early review of dr… Andy Bierman
- Re: [yang-doctors] Yangdoctors early review of dr… Eliot Lear
- Re: [yang-doctors] Yangdoctors early review of dr… Martin Bjorklund
- Re: [yang-doctors] Yangdoctors early review of dr… Eliot Lear
- Re: [yang-doctors] Yangdoctors early review of dr… Kent Watsen
- Re: [yang-doctors] Yangdoctors early review of dr… Eliot Lear
- Re: [yang-doctors] Yangdoctors early review of dr… Martin Bjorklund
- Re: [yang-doctors] Yangdoctors early review of dr… Eliot Lear