Re: [yang-doctors] Yangdoctors early review of draft-ietf-idr-bgp-model-07

"Mehmet Ersue" <mersue@gmail.com> Tue, 31 December 2019 15:47 UTC

Return-Path: <mersue@gmail.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 430921200EB for <yang-doctors@ietfa.amsl.com>; Tue, 31 Dec 2019 07:47:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kwJ_DR1C8y2g for <yang-doctors@ietfa.amsl.com>; Tue, 31 Dec 2019 07:47:33 -0800 (PST)
Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 51DBA12008B for <yang-doctors@ietf.org>; Tue, 31 Dec 2019 07:47:33 -0800 (PST)
Received: by mail-ed1-x530.google.com with SMTP id cy15so35525632edb.4 for <yang-doctors@ietf.org>; Tue, 31 Dec 2019 07:47:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:references:in-reply-to:subject:date:message-id:mime-version :content-transfer-encoding:thread-index:content-language; bh=vghB9WYkepx1MMO1RmvAMa/IavA/Hx07lSU602Z5sno=; b=lWTU5b4yxnCYy29CqmX8wihh6ITcjye0YF+/Y90MJAxdPzrmJV8v91ayfgleqVCbY4 0qBYZmdwFtMRwa92b1dfRuieC/+pEUPDnE+uUUg0e/6tiqCHj96nbdqd1g5nFAc0jYen yM2P99wq+lLJ3hknwtzwVYHv8Lp6Mnfxp6pDInn83ljfYGIZ1U/oUr6CLfspaP9I9Gss U0KSRSW60tYeoO49uPOo6UEI9yarWYhGuYYTCPB6vBWmdg/OHdqK8XS7lC3TWquT+lrF 4qb/tvdozMsly7eWr6ePJUrfqyAu/f6AxUsX6j4/41dgsn0Hsp35uV+POL6mNFzrwWqi Cf/Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:references:in-reply-to:subject:date :message-id:mime-version:content-transfer-encoding:thread-index :content-language; bh=vghB9WYkepx1MMO1RmvAMa/IavA/Hx07lSU602Z5sno=; b=Ot0D7Wc3n3V/jodvN8VRritfLQbgkybJ7DEQGkIDQR0Et1OFIhCXUsDI0SE+BR8CuN qg7bxza2ruEiOru/P3/HMGHqTK9lO2cbWpyKQOvpz248Vj6/o9exn9gCzaqfhyJBxxX9 WB0q+rxF8U9gWryJsHarO28/HH1lYBSwMGUlGJfKNy6xsT647e7jaXMoXQUjavqZLpbP codeoblLVeCHqoHuWhMuZXXHQTDCuM0VrExTu0K4Pu+5+A6bgc6mlGVm2PdcKT+lRqXS RMGRIodAouuhxrJ9bUyEB2goWKIPX6XGcRNHPhK5EFzwzh7HKdGU+VgoPyVSPZccZk3g JNCQ==
X-Gm-Message-State: APjAAAVFDUhepqr7tc6i/AqwdHI8B80uu44p76w9gP6WN/1ngdC2HCf8 yuOWFmCss7TmJELCLEbJscQ=
X-Google-Smtp-Source: APXvYqymRT7AjJXebivpCK5rSk+iGwCIj6ldqil4ebByFmviKHMbEpQvACyQTMIH/wNmyxCdO25Jgw==
X-Received: by 2002:a05:6402:c82:: with SMTP id cm2mr76193835edb.19.1577807251719; Tue, 31 Dec 2019 07:47:31 -0800 (PST)
Received: from DESKTOPFLHJVQJ ([2001:16b8:2d32:3a00:ac4a:7e7f:8b0:aa76]) by smtp.gmail.com with ESMTPSA id f10sm5912624eds.31.2019.12.31.07.47.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Dec 2019 07:47:31 -0800 (PST)
From: "Mehmet Ersue" <mersue@gmail.com>
To: "'Andy Bierman'" <andy@yumaworks.com>, <yang-doctors@ietf.org>
References: <157773531468.4577.5049465733732578910@ietfa.amsl.com>
In-Reply-To: <157773531468.4577.5049465733732578910@ietfa.amsl.com>
Date: Tue, 31 Dec 2019 16:47:30 +0100
Message-ID: <00b101d5bff1$9d5da040$d818e0c0$@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQKDXdf/M2eJQWY05xwrC/vWX93ekaZ5J11w
Content-Language: de
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/NM5Ako3vG8qBRBp6qcooIHGR-9I>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-idr-bgp-model-07
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Dec 2019 15:47:36 -0000

Thank you very much Andy for this great effort!

Cheers,
Mehmet

> -----Original Message-----
> From: yang-doctors <yang-doctors-bounces@ietf.org> On Behalf Of Andy
> Bierman via Datatracker
> Sent: Monday, December 30, 2019 8:49 PM
> To: yang-doctors@ietf.org
> Cc: idr@ietf.org; draft-ietf-idr-bgp-model.all@ietf.org
> Subject: [yang-doctors] Yangdoctors early review of draft-ietf-idr-bgp-
> model-07
> 
> Reviewer: Andy Bierman
> Review result: On the Right Track
> 
> 
> Major issues:
> 
>   - The ietf-bgp module uses (legal) YANG 1.1 constructs that are
>     not supported by available tools so it cannot be validated.
>     The solution options are
>     (A) rewrite the module so it does not place any definitions
>         in the main module.  Instead place all definitions in
>         submodules. Add YANG 1.0 include-stmts as needed so pyang
>         can validate the module
>     (B) wait until the opensource tools properly support this
>         YANG 1.1 usage and resubmit the module at that time
> 
>   - The modules import ietf-routing-policy. Version used was
>     2019-03-04.  This module has a fatal error caused because
>     ietf-interface-common has apparently been replaced with
>     ietf-if-extensions@2019-11-04
> 
>       leaf subinterface {
>         type leafref {
>           path "/if:interfaces/if:interface/if-cmn:encapsulation"
>              + "/if-l3-vlan:dot1q-vlan"
>              + "/if-l3-vlan:outer-tag/if-l3-vlan:vlan-id";
>         }
> 
>     The path expression is wrong. if-cmn:encapsulation is now
>     if-ext:encapsulation.  You need to check the XPath everywhere
>     when you refactor YANG modules.
> 
>   - Full review of these modules is not possible at this time without
>     proper opensource tools. Processing the YANG statements
>     by hand is extremely difficult, given the large amount
>     of groupings used which are spread across many modules and
>     submodules.
> 
> 
> Minor Issues
> 
>   - The "clear" actions need to be specific about the exact set
>     of objects that are affected. The value of each object once it
>     is cleared needs to be specified in every object that is affected
>     by the action.  Impact on operations should be explained in
>     each action-stmt
> 
>   - Some TODO items still remain indicating the YANG definitions
>     are temporary and will be replaced by more correct statements.
> 
>   - Additional reference-stmts would be useful to implementors
>     who are familar with the routing RFCs that the YANG objects
>     are based on
> 
> Editorial Comments
> 
>   - The implementation complexity appears to be very high
>     for both server and client developers.  The interactions between
>     subtrees is non-trivial and probably requires more clarifications.
>     This needs to be done by implementors, not document reviewers.
> 
> 
> _______________________________________________
> yang-doctors mailing list
> yang-doctors@ietf.org
> https://www.ietf.org/mailman/listinfo/yang-doctors