Re: [yang-doctors] Yangdoctors early review of draft-ietf-bfd-unsolicited-01

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Wed, 21 August 2019 20:14 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 625CF1207FE; Wed, 21 Aug 2019 13:14:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=nJxB4Kbz; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=CkbP3EV3
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3K0qTOUM_gl9; Wed, 21 Aug 2019 13:14:03 -0700 (PDT)
Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7F91B12089C; Wed, 21 Aug 2019 13:14:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5994; q=dns/txt; s=iport; t=1566418443; x=1567628043; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Y74m0LU6WnMBWmLNEn610eutafw7fNTz7yUOFcI4504=; b=nJxB4Kbz51jDJ3WI7jwgmwHSHPLmUbOeO1oR8IW6GSTlrs0+oPced3CM 73S8JqIx4Ad+cohz5ERWLjbBNdHf8ay8+6xKtynEhSL2EMDfTFUhltv3L B4zESy/FJFGglb1e1Jiy8n6a0guuqHEsRiBQgy44zJ3nu5VjUNkJjWLsG Q=;
IronPort-PHdr: =?us-ascii?q?9a23=3AZ38h5hBNq1BKCERYYRwyUyQJPHJ1sqjoPgMT9p?= =?us-ascii?q?ssgq5PdaLm5Zn5IUjD/qs13kTRU9Dd7PRJw6rNvqbsVHZIwK7JsWtKMfkuHw?= =?us-ascii?q?QAld1QmgUhBMCfDkiuNuTjbykzGuxJVURu+DewNk0GUMs=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AdAADNpF1d/4ENJK1kGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBVgEBAQEBAQsBgURQA21VIAQLKoQfg0cDimdNgg+JXo4?= =?us-ascii?q?HglIDVAkBAQEMAQEfDgIBAYQ/AheCRSM3Bg4CBQEBBAEBAQIBBgRthScMhUo?= =?us-ascii?q?BAQEBAgESEREMAQE3AQQLAgEIDgoCAiYCAgIfERUQAgQOBSKDAAGBagMODwE?= =?us-ascii?q?Cn3sCgTiIYXOBMoJ7AQEFhRMNC4IWAwaBDCgBi20YgUA/gTgfgkw+ghpHAoF?= =?us-ascii?q?LFheCdDKCBCKMGoJMMZwCQAkCgh2GaIlYBIN1G4IxhzCOZYx4CYg9gXqOMQI?= =?us-ascii?q?EAgQFAg4BAQWBZiKBWHAVZQGCQYJCg3KKU3KBKYwdAQE?=
X-IronPort-AV: E=Sophos;i="5.64,412,1559520000"; d="scan'208";a="618181473"
Received: from alln-core-9.cisco.com ([173.36.13.129]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 21 Aug 2019 20:14:02 +0000
Received: from XCH-ALN-004.cisco.com (xch-aln-004.cisco.com [173.36.7.14]) by alln-core-9.cisco.com (8.15.2/8.15.2) with ESMTPS id x7LKE2rc007153 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 21 Aug 2019 20:14:02 GMT
Received: from xhs-rcd-003.cisco.com (173.37.227.248) by XCH-ALN-004.cisco.com (173.36.7.14) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 21 Aug 2019 15:14:01 -0500
Received: from xhs-aln-002.cisco.com (173.37.135.119) by xhs-rcd-003.cisco.com (173.37.227.248) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 21 Aug 2019 15:14:01 -0500
Received: from NAM02-CY1-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-002.cisco.com (173.37.135.119) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 21 Aug 2019 15:14:01 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RIZQye25VU9l2cEQ18Fvs2EuCUKjD9e6aC5A75k1VyKBhDmYMweazDnPsF+S38XTfHaUU0AUoGrCLT7F/DZKgv8tAAA3vpj5SK9qj2JTP35YAl/HGa6WHGSGxqeWLB/7PbrLiNsLrdJ5KFMSUfGc0YNHRZq7bSyVMSkasch8z1zJ4uuIA81Ic1KINZKdHsK1d1iYbjMyJI/iksooaDR904hHcjUxiTVpDeZp2PQUNvMsbqTdYABNshWGm9eHPb2Q7WG4lWQ6qlJJkTkX2WVVmMGZo6jqrExWWaFx+5eXdMxtWN3VEKsBPmo3MLXRxjXVseO+RXNWcVSV+aP1RZZg8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y74m0LU6WnMBWmLNEn610eutafw7fNTz7yUOFcI4504=; b=Ob1MbJvoWxLqnKcaHbFZXtcL3++C51kA9Jds90Xdp29DviOYTPUJZen+GWqbONlB8EyBQpuGpGptkOOab+AqRqp4+fPfhE6hfSy00OwHhPCiY+O9ogpdVh+oJQmXaelRK7Uqd1gwwCFTs1IMehETCTj+ssCmZvp3Mo6S/FB6xPlv5QsS81ExH9SYwbPosSYHJzJh21r6QrsdQ/UZQjzv+fab/gnzdcUIf5mk4GZKRN17QQwGyPqii1k1B6C59xVB1NQSHqjpKud1WnCwrAhGidApoUQ7lsbNkGiD/bwbg0/rbiGBi5YAK/KJCXjC2GyGcta/WwJo50VUGJXx8X7fBw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y74m0LU6WnMBWmLNEn610eutafw7fNTz7yUOFcI4504=; b=CkbP3EV3evA9SOqngQY+SDRJFtSc2qqwuuNpTORtcQNWUh9t4b4tOb9ismDVoCVJlEiCB2uI7azpYF4nyMhx2hTjs811pc+o6lPDU+9AWIx2Apkk6CFjmxnvD/Q8eZSJzLeRaEUs7bfTPZefzNuHhLNR38toLtpTQioZgb/6goc=
Received: from MN2PR11MB4157.namprd11.prod.outlook.com (20.179.150.223) by MN2PR11MB4256.namprd11.prod.outlook.com (52.135.36.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.18; Wed, 21 Aug 2019 20:14:00 +0000
Received: from MN2PR11MB4157.namprd11.prod.outlook.com ([fe80::80bb:d4b:bc47:7daf]) by MN2PR11MB4157.namprd11.prod.outlook.com ([fe80::80bb:d4b:bc47:7daf%3]) with mapi id 15.20.2178.020; Wed, 21 Aug 2019 20:14:00 +0000
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: Jeffrey Haas <jhaas@pfrc.org>
CC: Martin Bjorklund <mbj@tail-f.com>, "mjethanandani@gmail.com" <mjethanandani@gmail.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "rtg-bfd@ietf.org" <rtg-bfd@ietf.org>, "draft-ietf-bfd-unsolicited.all@ietf.org" <draft-ietf-bfd-unsolicited.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-bfd-yang@ietf.org" <draft-ietf-bfd-yang@ietf.org>
Thread-Topic: Yangdoctors early review of draft-ietf-bfd-unsolicited-01
Thread-Index: AQHVVoFcW4RvcvlvFUaeAOxMqn9qZqcCz2yA///ENgCAAEUogP//wIcAgANzdgD//70XgA==
Date: Wed, 21 Aug 2019 20:13:59 +0000
Message-ID: <94D8BB16-13A8-41BC-A0AF-B75F99FA667F@cisco.com>
References: <156621414936.19813.853283734958376284@ietfa.amsl.com> <0CD4CB48-9382-4724-A5A6-A7B0DE7D7D57@gmail.com> <22279DB9-A0F3-4D5E-BFDC-38B2AD5B109F@cisco.com> <20190819.211837.1184862907842631386.mbj@tail-f.com> <496A5CD5-23C9-4865-BC52-EFC5409475A8@cisco.com> <20190821201328.GC367@pfrc.org>
In-Reply-To: <20190821201328.GC367@pfrc.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.1a.0.190609
authentication-results: spf=none (sender IP is ) smtp.mailfrom=rrahman@cisco.com;
x-originating-ip: [2001:420:2840:1250:6900:eb73:e481:aee6]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 26f42dc6-6ae0-4f48-e7c2-08d726741aa8
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:MN2PR11MB4256;
x-ms-traffictypediagnostic: MN2PR11MB4256:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <MN2PR11MB4256042F5991E021F40B63DEABAA0@MN2PR11MB4256.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0136C1DDA4
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(136003)(366004)(376002)(39860400002)(34654002)(189003)(199004)(5660300002)(186003)(66574012)(8676002)(54906003)(102836004)(36756003)(6116002)(2906002)(53546011)(33656002)(58126008)(8936002)(81166006)(81156014)(316002)(7736002)(2616005)(71200400001)(476003)(4326008)(99286004)(6512007)(25786009)(446003)(11346002)(76176011)(6246003)(6486002)(6436002)(486006)(86362001)(256004)(71190400001)(478600001)(53936002)(966005)(14454004)(76116006)(91956017)(66946007)(6306002)(6506007)(6916009)(305945005)(229853002)(64756008)(66446008)(66476007)(66556008)(46003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4256; H:MN2PR11MB4157.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: dUak5CAicE5SrInpISz6+/yBpbTUsvOyM/I92+8oKIn6IXtFjtNr1ltBjTOnz3jNqnAuwmI+8P3lU0v+7vu0SdRujgRzUcaG1BESLOrZ34Eoh1+aqUwR0lxY0TnQr3KPQfSaMQwNbreao41qotDpn3kUKqp7B+Nfjyd1WadEJuJ3uXOUyDU94ct9o6enoCaf9cUAPoAAER8ZQqp0ZjbGJxE/+EFgYZuTmftyi9nbQoSrkXGXYls7zfKqhXdx3hR6PMnzTtJGo3Jp5QunbBFX2wD2u8tYrM2neRF+BM+p+W62Rk+GcmbYFeK7qWbwbdA+exYfAme+CycNeEhzojTHOUVD+GPpcXJIfww66mDkAmpYsqawnLvs8RrXJEQyp43swq+MwTu6FuhI4ZnH6bNbCWVnD/uDuSaRtxX66cMVpEM=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <9A5D4196F2A6CF45BAF2123C14387E45@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 26f42dc6-6ae0-4f48-e7c2-08d726741aa8
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2019 20:14:00.0793 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: s5kgq9YbYhgurBQLt7JmMEhigiL7Q2ZuCzfUFDG5flGU4Oj/E10Yco9fKXmnNmUKiWacK5J+yF0v00wkr+/Umw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4256
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.14, xch-aln-004.cisco.com
X-Outbound-Node: alln-core-9.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/NkBufj3A2eT2eJEF4PnND2ULS20>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-bfd-unsolicited-01
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Aug 2019 20:14:12 -0000

Hi Jeff,

Yes, to me it makes sense to do the change suggested by Martin (add "default tx-rx-intervals;" to the choice statement). BFD YANG co-authors, please respond asap if you disagree.

Regards,
Reshad.

On 2019-08-21, 4:11 PM, "Jeffrey Haas" <jhaas@pfrc.org>; wrote:

    Reshad,
    
    If procedures permit it (I'm unclear on the detail), does it make sense to
    pull the BFD yang module for a fix from the editor queue?
    
    -- Jeff
    
    On Mon, Aug 19, 2019 at 07:31:27PM +0000, Reshad Rahman (rrahman) wrote:
    > I was looking at an old copy of the doc which didn't have default. So yes, mandatory doesn't make sense with the default statements.
    > 
    > Your assumption below wrt the intention is correct. I don't know how feasible it is to add this while it's in the editor q.
    > 
    > Regards,
    > Reshad.
    > 
    > On 2019-08-19, 3:18 PM, "Martin Bjorklund" <mbj@tail-f.com>; wrote:
    > 
    >     "Reshad Rahman (rrahman)" <rrahman@cisco.com>; wrote:
    >     > Thanks Martin and Mahesh.
    >     > 
    >     > I believe we should add a mandatory statement to the choic (speaking
    >     > as BFD YANG co-author,)
    >     
    >     But then it is not clear why all leafs in the cases have default
    >     statements.
    >     
    >     Since the 'single-interval' case is optional with a if-feature (which
    >     BTW is weird since it is trivial to implement), and the only other
    >     case has default values on both its leafs, I would have assumed that
    >     the intention was that if nothing is configured, the server should use
    >     1000000 microseconds for the intervals.  If this is the intention,
    >     perhaps a statement:  "default tx-rx-intervals;" can be added to the
    >     module, even though the doc is in the RFC ed q.
    >     
    >     
    >     /martin
    >     
    >     
    >     
    >     > 
    >     > Just created https://github.com/bfd-wg
    >     > 
    >     > Regards,
    >     > Reshad.
    >     > 
    >     > 
    >     > On 2019-08-19, 2:45 PM, "Mahesh Jethanandani" <mjethanandani@gmail.com>; wrote:
    >     > 
    >     >     [Adding the authors of BFD YANG module]
    >     >     
    >     >     Martin brings up a good point. But since the document that contains ietf-bfd-types is sitting in RFC Ed Queue, this will have to go into a bis document.
    >     >     
    >     >     Chairs, could you create a bfd-wg in GitHub for us to track this as an issue to be fixed as part of a bis document?
    >     >     
    >     >     > On Aug 19, 2019, at 4:29 AM, Martin Björklund via Datatracker <noreply@ietf.org>; wrote:
    >     >     > 
    >     >     > Reviewer: Martin Björklund
    >     >     > Review result: Ready with Nits
    >     >     > 
    >     >     > I have reviewed this document from a YANG model perspective only.
    >     >     > 
    >     >     > My only comment is actually for a grouping defined in ietf-bfd-type, but used
    >     >     > in this module.  There is a choice "interval-config-type":
    >     >     > 
    >     >     >  +--rw unsolicited {bfd-unsol:unsolicited-params-global}?
    >     >     >       +--rw enable?                           boolean
    >     >     >       +--rw local-multiplier?                 multiplier
    >     >     >       +--rw (interval-config-type)?
    >     >     >          +--:(tx-rx-intervals)
    >     >     >          |  +--rw desired-min-tx-interval?    uint32
    >     >     >          |  +--rw required-min-rx-interval?   uint32
    >     >     >          +--:(single-interval) {single-minimum-interval}?
    >     >     >             +--rw min-interval?               uint32
    >     >     > 
    >     >     > This choice is not mandatory and doesn't have a default case, so the question
    >     >     > is what happens if no nodes from the choice has been configured?   I would
    >     >     > expect the choice to have a default case (but this then would apply to
    >     >     > ietf-bfd-types, not this document.)
    >     >     > 
    >     >     > 
    >     >     
    >     >     Mahesh Jethanandani
    >     >     mjethanandani@gmail.com
    >     >     
    >     >     
    >     >     
    >     >     
    >     > 
    >     
    >