[yang-doctors] Yangdoctors Early Review of draft-ietf-lpwan-schc-yang-data-model-04
Mehmet Ersue <mersue@gmail.com> Sun, 18 April 2021 14:59 UTC
Return-Path: <mersue@gmail.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 357BF3A1B2A; Sun, 18 Apr 2021 07:59:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e8Z-pyHUDxBj; Sun, 18 Apr 2021 07:59:10 -0700 (PDT)
Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 19BCB3A1B26; Sun, 18 Apr 2021 07:59:06 -0700 (PDT)
Received: by mail-ed1-x52f.google.com with SMTP id d21so17567745edv.9; Sun, 18 Apr 2021 07:59:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version:content-language :thread-index; bh=d0ROGkroZBdf1o1TKYoJhs6MGNPUQX2v7lWoEez6YPQ=; b=CdEO6kUcgW+2in+q64kt91rLjXSqEmC28RdR+GMqL6GKMbWsHfHyCfdJJWUz+m1RVi Vzr7XYm4d71yf58ByCjrGRLeZuH+oNqSVbPW+K3Vf5GON2S9XQari7wfezxXMjKiCgvl dCP0Gsx47LblzvZWLnPeX3eMd2fQ4dp+dXKXbX0EMjlQqnQi9P5GYYK0kqBB2w1vFRvQ 10kkkWZa1pK/1E+cjqB9fqdCIt0kOabeqCVzJ4YDWNB9Sp4zfkbow1sO9f9OOBU2dayT +Pq2EB35OUQ35LFTOk0/367Hk0j+NTPuNyXf0AnrNe2+HWUhCw5GQQeznqQhxibfqOGd TDQQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-language:thread-index; bh=d0ROGkroZBdf1o1TKYoJhs6MGNPUQX2v7lWoEez6YPQ=; b=duAj/LNk9XbFm0TVgksls7hDoCgJUZ7KdyEuy9GWbDlTDle2NxVE3zmDV70bBqx4F7 ylmLNjAmbjJGQ1EwIvDBKq7XuW1Qmh49Rzv+Aje5XZXj8j7WTsiGj/3WmIWYAVki4IKm ZMBfbvg8QcIDr79mSpTZ44mzfRUt1e/lqGOrbdLG0gPjatzHrPU6nUxfn8zSSA51+c9N V+/upbTf9sL9QnrhicV8PuWuSIzKgqHEvH47olADKf9HW1Oc6YtuJbMS/mFmSBfPpegB YOvl5b74ZI5wZi6uhazRVTYn46QYg8UNrlzz17IYMQQiP42bPqnVx9AD5aqCjiBxYeF0 6GEw==
X-Gm-Message-State: AOAM5317acIMo19aYT/PXOur6rrngMD6n7QSws/Nxb3Cgfxo+Mb7ZQLe kB09tCDz6rx6JGXBTMjdXqQ=
X-Google-Smtp-Source: ABdhPJxMfPdH8W8zHZBfdPM+/cWLGFfnpdeZ9dhszUhnRTdcXiQ6d74gH8OQf513iGfNpGDLik3S8w==
X-Received: by 2002:a05:6402:4242:: with SMTP id g2mr20486744edb.329.1618757943720; Sun, 18 Apr 2021 07:59:03 -0700 (PDT)
Received: from DESKTOPFLHJVQJ ([2001:16b8:2d01:4100:2900:347d:621:69d6]) by smtp.gmail.com with ESMTPSA id y25sm6080130ejb.34.2021.04.18.07.59.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Apr 2021 07:59:02 -0700 (PDT)
From: Mehmet Ersue <mersue@gmail.com>
To: yang-doctors@ietf.org
Cc: draft-ietf-lpwan-schc-yang-data-model.all@ietf.org, lpwan@ietf.org, 'Carl Moberg' <callemoberg@gmail.com>
Date: Sun, 18 Apr 2021 16:59:01 +0200
Message-ID: <005c01d73463$5ee2fda0$1ca8f8e0$@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_005D_01D73474.226E65B0"
X-Mailer: Microsoft Outlook 16.0
Content-Language: de
Thread-Index: Adc0Y0RuAHGV+BoJTwu4kr8s1b3owg==
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/NqGjsbWQB_y5RGoTgHfRkLPvx7E>
Subject: [yang-doctors] Yangdoctors Early Review of draft-ietf-lpwan-schc-yang-data-model-04
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Apr 2021 14:59:15 -0000
I'm sending this on behalf of Carl Moberg. It seems there was an issue and the review mail has not been generated. Text copied from https://datatracker.ietf.org/doc/review-ietf-lpwan-schc-yang-data-model-04-y angdoctors-early-moberg-2021-04-13/ Mehmet Reviewer: Carl Moberg Review result: On the Right Track This is my YANG Doctors Early Review of draft-ietf-lpwan-schc-yang-data-model-04 It is obviously challenging to provide early review feedback on how useful and efficient the YANG model representation is for a set of technologies that I am not an expert on, but here goes. Understanding that it is still early in the lifecycle of the module, I have not spent time on providing feedback on e.g. description texts, capitalization and spelling but have focused on the general structure and design of the module. I also haven't spent any time dissecting the output of `pyang --ietf`, but I would suggest the authors start looking into that as the content of the module moves ahead towards publication. I would also suggest considering running the module through `pyang -f yang` as that provides nice and consistent formatting and quoting. As for the content itself. I believe to the best of my understanding that the YANG module reflects the core data structures of RFC8724 well. I have a couple of questions that may lead to broader discussion on _how_ to capture certain aspects of these data structures in a way that makes it realistic to implement while still easy to use. As is right now, the YANG module assumes that all implementations support all FID types defined to be derived from field-id-base-type. It includes fields related IPv6, COAP/OSCORE, and ICMPv6 all in the same module. Is there a possibility that some implementations won't implement all three of those protocol groups? If so, it might be worth considering making FID type groups either optional using YANG 'feature' statements or break them out into separate modules to be advertised separately. There is currently no correlation between field-id type and field-length types in the same compression rule entry. I.e. the current YANG permits a field-identifier 'fid-ipv6-version' combined with a field-length 'fl-token-length' in a rule entry, which I understand to be nonsensical. If I am right in that it's an example of meaningless configuration, does the authors think it important (and possible) to work towards a more stringent validation of "meaningful" configuration by capturing the relationships between fields like in this example?
- [yang-doctors] Yangdoctors Early Review of draft-… Mehmet Ersue
- Re: [yang-doctors] Yangdoctors Early Review of dr… Laurent Toutain
- Re: [yang-doctors] Yangdoctors Early Review of dr… Laurent Toutain