Re: [yang-doctors] [Last-Call] Yangdoctors last call review of draft-ietf-i2nsf-nsf-monitoring-data-model-06

"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> Mon, 12 April 2021 11:59 UTC

Return-Path: <jaehoon.paul@gmail.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C15313A1AAA; Mon, 12 Apr 2021 04:59:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.598
X-Spam-Level:
X-Spam-Status: No, score=-0.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HK_NAME_FM_MR_MRS=1.499, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4XgM_nRAazf5; Mon, 12 Apr 2021 04:58:57 -0700 (PDT)
Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 221293A1AAC; Mon, 12 Apr 2021 04:58:57 -0700 (PDT)
Received: by mail-lf1-x12f.google.com with SMTP id x13so10792816lfr.2; Mon, 12 Apr 2021 04:58:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9/+D/NbRHQEqhoGdgBepCxqQr83hFrzvGoJ9KoThCBk=; b=hWSoYfbiYzQr2Nyfb0qfwerF/WL0SSvvXHNPFV0ly8gnqfITY55uUxMD5oIEHaIh8g LEALGEFuUQBwGZ96mwC5HEQjUE9TAF423BV8LoCJSCh2I9awzOWwtc5FEhfB9iiQuK9y 6942BykXDZB+n8VtqEcgaw+eVCMCHYGKC6jhF7g1GxigbjsCVK1Sr7mCej7GqpQMlJLA lAwdE69rvJCQkh2kHuhcgOk/VLrcW08MLPT5gDBRVlL/rWZO54GzTueJBZpZkmmghby8 plhpyImHPaqIk8pI7ifY1pCb91g+ChQ0ZVdZwL4Kx49qFXcjdAdNlghYRAAj2xKl3obe tguA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9/+D/NbRHQEqhoGdgBepCxqQr83hFrzvGoJ9KoThCBk=; b=jS/GSbLXPg3DmVO3zYN46NLnl+ex60t+KBNriQZeav/FbNa8nIBlX2ck53SjjeE75X IIq9V/5JJRNdwBqvqsvPBLQrUWtGlcJlMEh+g45+l4yGQjwqysUck/+SdaHJ6Jujjfml SwRSa/u45NmNtuZg7sC81aMG5PvILwrrBT8GiiFAHV+zFQQTu7ppfaD9lRX2CoHZJAzQ OUzvtphGERuBxEk/JgkKkIntQNhlgg4Qc6Uc1e9NEOHhk2DtitkVenNatHyik2KX6V/u SXH79PtrKqtpSp9Qs5Do5ccmpdHLI52K7484wwNUuNg+iDEwCs8qej/l4n1PaqWB3r8N ykgg==
X-Gm-Message-State: AOAM530Te0upx12LSZuO+1kBIG9qxGlF8lb5nwOaG0VPWSaGF+5pbrdt Z0a39q+Fh3IUk+C80dd6SO7FNvrygFoOw4+Ck3M=
X-Google-Smtp-Source: ABdhPJz9jlmN8IwTBuk7jQkCRGIIRHIGZhyFf+Gfgb8itnMDklyh7BqRoUk7K/6TGkHAyat7UDIx35JSOmdThcuWNjQ=
X-Received: by 2002:a05:6512:3582:: with SMTP id m2mr19308785lfr.10.1618228730020; Mon, 12 Apr 2021 04:58:50 -0700 (PDT)
MIME-Version: 1.0
References: <161652444666.30886.1452719047245335791@ietfa.amsl.com> <CAPK2Dezp8EZ9S4oCVz2YmAzXKxbne6qGoc5vfz=4MQvr3sWhGA@mail.gmail.com> <607419E2.6080803@btconnect.com>
In-Reply-To: <607419E2.6080803@btconnect.com>
From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Date: Mon, 12 Apr 2021 20:58:38 +0900
Message-ID: <CAPK2DexVmZZOYOEM_amOFyFrw2FkyGQeG+X9hFn7a20bg66WRQ@mail.gmail.com>
To: tom petch <daedulus@btconnect.com>
Cc: Andy Bierman <andy@yumaworks.com>, Linda Dunbar <linda.dunbar@futurewei.com>, Yoav Nir <ynir.ietf@gmail.com>, draft-ietf-i2nsf-nsf-monitoring-data-model.all@ietf.org, "i2nsf@ietf.org" <i2nsf@ietf.org>, Last Call <last-call@ietf.org>, YANG Doctors <yang-doctors@ietf.org>, skku-iotlab-members <skku-iotlab-members@googlegroups.com>, "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Content-Type: multipart/alternative; boundary="0000000000009e46ba05bfc53cdd"
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/XLHkSG-iviMB7iek94YsxyKnpzQ>
Subject: Re: [yang-doctors] [Last-Call] Yangdoctors last call review of draft-ietf-i2nsf-nsf-monitoring-data-model-06
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2021 11:59:02 -0000

Hi Tom,
I will address your comments.

Thanks.

Best Regards,
Paul

2021년 4월 12일 (월) 오후 6:59, tom petch <daedulus@btconnect.com>님이 작성:

> Paul
>
> Some admin comments on -07; I think that you need to:
>
> - change the title in YANG revision reference
>
> - add to the I-D references
> RFC959
> RFC8632
>
> - shorten lines. There is a limit to line length in RFC as per the Style
> Guide.  This is exceeded in the YANG where some of the path statements
> take it over 80 while some of the examples are over 100.
>
> - add a reference for the import of
> ietf-i2nsf-policy-rule-for-nsf
>
> HTH
>
> Tom Petcb
>
> On 01/04/2021 03:09, Mr. Jaehoon Paul Jeong wrote:
> > Hi Andy, Linda, and Yoav,
> > Patrick and I have addressed all the comments from Andy.
> > Here is the revised draft -07:
> >
> https://tools.ietf.org/html/draft-ietf-i2nsf-nsf-monitoring-data-model-07
> >
> > I attach a revision letter to explain how we addressed the comments.
> >
> > There are the major updates in this revision as follows:
> > ---
> >     o  This version is revised according to the comments of Andy Bierman
> >        who is a YANG doctor.
> >
> >     o  This version updates its title as "I2NSF NSF Monitoring Interface
> >        YANG Data Model".  It clarifies the NSF Monitoring Interface to
> >        deliver NSF monitoring data to an NSF data collector (e.g.,
> >        Security Controller and NSF data analyzer).
> >
> >     o  This version adds an attack destination IP address for DDoS-attack
> >        event to provide an NSF data collector with more information
> about the
> >        destination of DDoS-attack packets.
> >
> >     o  This version supports a notification for monitoring traffic flows
> >       to detect the source and destination (as a victim) of security
> attacks
> >       such as DDoS attack.
> > ---
> > If you have questions and comments, please let me know.
> >
> > Thanks.
> >
> > Best Regards,
> > Paul
> >
> >
> > On Wed, Mar 24, 2021 at 3:34 AM Andy Bierman via Datatracker <
> > noreply@ietf.org> wrote:
>