[yang-doctors] Yangdoctors early review of draft-ietf-mpls-base-yang-10

Ebben Aries via Datatracker <noreply@ietf.org> Sun, 18 August 2019 20:19 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: yang-doctors@ietf.org
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 6D0B71201E4; Sun, 18 Aug 2019 13:19:00 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ebben Aries via Datatracker <noreply@ietf.org>
To: <yang-doctors@ietf.org>
Cc: mpls@ietf.org, draft-ietf-mpls-base-yang.all@ietf.org, ietf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.100.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Ebben Aries <exa@arrcus.com>
Message-ID: <156615954036.3697.1825462750505422399@ietfa.amsl.com>
Date: Sun, 18 Aug 2019 13:19:00 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/YsMhVU4YtOPzdsCOW3lSzUd74ZY>
Subject: [yang-doctors] Yangdoctors early review of draft-ietf-mpls-base-yang-10
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Aug 2019 20:19:01 -0000

Reviewer: Ebben Aries
Review result: On the Right Track

1 module in this draft:
- ietf-mpls@2019-02-24.yang

No YANG compiler errors or warnings (pyang 2.0.1, yanglint 1.1.40, confdc 6.6.3)

Module ietf-mpls@2019-02-24.yang:
--------------------------------------------------
- Remove WG Chairs from contact information per
  https://tools.ietf.org/html/rfc8407#appendix-B
- 'ietf-interfaces' import should reference RFC8343 rather
- Must clause for start/end-label is incorrect.  Would suggest moving this
  must statement underneath the `leaf end-label` as well:

  e.g.

  leaf end-label {
      type rt-types:mpls-label;
      must '. >= ../start-label' {
          error-message
            "The end-label must be greater than or equal " +
            "to start-label";
      }
      description "Label-block end";
  }
- Use of 'state' container under '/routing/mpls/label-blocks/label-block/state'
  These nodes could sit as r/o nodes by the looks of it directly under the
  label-block list.  In addition, do these nodes need '-count' suffixes?
  Should they rather be of type `yang:counter32`?
  See: https://github.com/netmod-wg/FAQ/wiki/NMDA-Modelling-FAQ
- Is there any intention to define any surrounding features?

General comments/minor nits on the draft/modules:
--------------------------------------------------
- Section 1: s/feauture/feature/
- Section 2.1: s/the the/the/
- Section 2.1: 'labeled' vs. 'labelled'
- Section 2.4: s/followinig/following/
- Module line 354/367: This is for the 'active-route' action statement rather