Re: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-notification-capabilities-05

Balázs Lengyel <balazs.lengyel@ericsson.com> Tue, 05 November 2019 14:50 UTC

Return-Path: <balazs.lengyel@ericsson.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 83337120142; Tue, 5 Nov 2019 06:50:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XC6FLvTy_1rT; Tue, 5 Nov 2019 06:50:39 -0800 (PST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30084.outbound.protection.outlook.com [40.107.3.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 575B112090B; Tue, 5 Nov 2019 06:38:31 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Haz0GM59/rRMOFoUNTDCWHBOUMaL1B2/RtuaCNKC+XOHjs+inbOi/QnN1bnU/PTiRN4ghHJWBdRAMuXB/xQHdNZr0Z0RtCOWUJqposYwWCcJN87Lal0u4GJOZlnH42J8t8NTLh/pOYTa0R2Uh+NqMEZ8TJsBJkL/dAE5OHIKxJvMgutAdKQWvILgkjuMGdxN1zvehT2EttM7s7M2bR9IuhmbO0BYxVT9CgeXVZuRw8n7VQNT5CYIuAFtGhfHh6c0FvLhAZXn0AEj9GP2Bl6k8iRRJAinCZ/BlkzJ1b+xyhpJZJF10Bga9Z9SqchmO+IVr4yGUHjTzAIyUrSjVVerKg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/jMv4ihVkzY0uCxoPNMKImGEp1tD0g7hEBN+sZAk2hU=; b=MCirtAUfRfKUdhA9RspmKwQqTTTzUHBEODtSt2nwCy7145ZDmKlTTE5dls7SGzY8YkcWPbLxm/uxU7be0iwp4oeiomuwkAz9taZWQrMVmJD5H//FgoEYsu2oaZoJTxcnZtVx2Udxvq13zyDmQWdDVbEsJ0zsaJRntQNj2CeiIGqPZpPLrI6q64LnAwL3R6lzSVD9eJsyGYu76Rbmj38c1PdiMOcaKY/QfjMAJ++zqPIN1632HEIJZqAuGU3EBGsxMzF2YLHHqp98CNiyUSDhC44f7VIxXLt4BTT+wdRJZHZi+6xvcw6Uqfy0wBLiO0EjU0T2riI7ObB2SllTIB+rgA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/jMv4ihVkzY0uCxoPNMKImGEp1tD0g7hEBN+sZAk2hU=; b=f3upI8PnuxSdbaxZ6fstTM5VSlh9Tlwf/FQhK7I+cITWfnhfrJ4CQ2/XHqu3bqFakaNP46vpEpLPSUJYkuszzVnitd5JB44W/wRJGl2T0GzSkNtteSPxqucmuBRegFL6GVkrFBMKKRw9WQViMwkF8W2EdteD/dkLK0eufY+dkFA=
Received: from AM7PR07MB6214.eurprd07.prod.outlook.com (10.186.170.77) by AM7PR07MB6453.eurprd07.prod.outlook.com (10.186.171.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.13; Tue, 5 Nov 2019 14:38:27 +0000
Received: from AM7PR07MB6214.eurprd07.prod.outlook.com ([fe80::3c4a:6fb:4b5a:8a]) by AM7PR07MB6214.eurprd07.prod.outlook.com ([fe80::3c4a:6fb:4b5a:8a%7]) with mapi id 15.20.2430.014; Tue, 5 Nov 2019 14:38:27 +0000
From: =?utf-8?B?QmFsw6F6cyBMZW5neWVs?= <balazs.lengyel@ericsson.com>
To: Ladislav Lhotka <lhotka@nic.cz>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "last-call@ietf.org" <last-call@ietf.org>, "netconf@ietf.org" <netconf@ietf.org>, "draft-ietf-netconf-notification-capabilities.all@ietf.org" <draft-ietf-netconf-notification-capabilities.all@ietf.org>
Thread-Topic: Yangdoctors last call review of draft-ietf-netconf-notification-capabilities-05
Thread-Index: AQHVjifxsBW2rOU/zkWUCQzU06Ifbqd63YyQ
Date: Tue, 5 Nov 2019 14:38:27 +0000
Message-ID: <AM7PR07MB621460C59113526390C62A5FF07E0@AM7PR07MB6214.eurprd07.prod.outlook.com>
References: <157233302184.6593.3869700028694968875@ietfa.amsl.com>
In-Reply-To: <157233302184.6593.3869700028694968875@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=balazs.lengyel@ericsson.com;
x-originating-ip: [89.135.192.225]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1147285a-9204-4ad5-c1a9-08d761fdd1eb
x-ms-traffictypediagnostic: AM7PR07MB6453:
x-microsoft-antispam-prvs: <AM7PR07MB64538F4831ECDB41C3897C98F07E0@AM7PR07MB6453.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0212BDE3BE
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(136003)(346002)(366004)(39860400002)(189003)(51914003)(199004)(13464003)(66556008)(66476007)(55016002)(66574012)(76116006)(85182001)(53546011)(71200400001)(3846002)(86362001)(99936001)(2906002)(15650500001)(26005)(305945005)(8936002)(186003)(6506007)(446003)(52536014)(229853002)(81156014)(81166006)(76176011)(110136005)(74316002)(25786009)(486006)(5660300002)(33656002)(66066001)(99286004)(66446008)(71190400001)(6436002)(6116002)(2501003)(102836004)(256004)(7736002)(54906003)(11346002)(14444005)(7696005)(8676002)(85202003)(4326008)(14454004)(9686003)(316002)(66616009)(476003)(64756008)(6246003)(478600001)(66946007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM7PR07MB6453; H:AM7PR07MB6214.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: fZRy6PrUb/dq+L5flzGrTr+JUKp6Rq/dEaJcJ/V7bjTfE4hsRcQ6uzvjDY/UyFwdoXNIoFbmc6z+KGIoCudNn9qZHMcCjaCugJccQ/YeiRzKhCX4Cu4xq5Hv4WUkkfrM4j2XbU1L3hLNADgmT+t5Dr7G8yTQ0lLcriJV5YMCc6l8mp5MocXSaoirRlkTdRj0bOeFj+jEtBrKsUxqAcAaGuZvsPjfcrECgmY5ZeYZAUISRo8OXu3Cq9lVWXp5jAAWCrcP5URTf7Hk07rtDoWyXgEJoux+WKcueKteJJQ/kkVPyCCPlJYasoC1yEZdG8lac/wOzANU5pS0M5UHH1kg6dOnVu8OImo7aldR+Fp1KOkK4zjvcrHAtAGiHfOaHD0F0GHDDfPQG0YWfi3FQKP+V88bePpFpxtRmx5keIkOH+h1nZTmKW1H5HjvSgDVwSty
x-ms-exchange-transport-forked: True
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_0768_01D593EF.10227C60"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1147285a-9204-4ad5-c1a9-08d761fdd1eb
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2019 14:38:27.1677 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: r9gqYNM4m/OUAZKx/Nqvh48LZ0NED11jBnF9y9GXmmCnbjHZ7tdo7FjvuprS+jxcHbqtItJbQ3YLovgWQk6KDKMCAczDFP4CTRwpTO3PFAM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR07MB6453
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/Z2SDJnu5WpsPiAHexhAq-4NbwtE>
Subject: Re: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-notification-capabilities-05
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Nov 2019 14:50:48 -0000

Hello Lada,
Thanks for the comments. See answers below.
Regards Balazs

-----Original Message-----
From: Ladislav Lhotka via Datatracker <noreply@ietf.org>; 
Sent: 2019. október 29., kedd 8:10
To: yang-doctors@ietf.org
Cc: last-call@ietf.org; netconf@ietf.org; draft-ietf-netconf-notification-capabilities.all@ietf.org
Subject: Yangdoctors last call review of draft-ietf-netconf-notification-capabilities-05

Reviewer: Ladislav Lhotka
Review result: Ready with Nits

***** Section 2. Introduction
      - Paragraph 3: the use of MAY is inappropriate: publishers
        indeed may have limitations, but this should follow from RFC
        8641, and this document should take it as a fact.
BALAZS: OK
***** Section 3. Notification Capability Model
      - The use of RFC 2119 terms is again questionable: I understand
        the ietf-notification-capabilities data as an optional aid for
        the implementors, but requiring that "The file SHALL be
        available in implementation time ..." is way too strict.
BALAZS: OK, changed to SHOULD. Other reviewers wanted strong statements.
***** Section 3.2. YANG Module
      - This is one of the cases where it would be helpful to know
        which of the imported modules, such as ietf-netconf-acm, is
        also intended to be implemented. This may be addressed in a
        future YANG version (see issue #95 in yang-next), until then I
        would suggest to include YANG library data describing a
        minimum implementation.
BALAZS: OK. Yes, it would be useful information. I added it as a description substatement to import.  
***** Appendix A. Instance data examples
      - Example in Fig. 2: the <datastore> element has an incorrect
        XML namespace (of the ietf-datastores module).
BALAZS: I don't understand the comment; I don't see the error. Could you please advise me what you think should be there? Exactly where? 
      - Many enum values are invalid because they contain
        leading/trailing whitespace. It would be better to encode the
        examples in JSON.
BALAZS: I would like to keep the examples as they are.
In many previous RFCs lines in XML examples were broken into multiple lines. E.g. 
RFC7950 7.16.3
rfc8341 A.4
rfc8641 4.4.1
rfc6022 4.1
rfc8525 B
rfc8072 A.1.1
rfc6243  A.3.1
IMHO it is readable. It is better to use longer descriptive names in YANG, then to use short names just to avoid long lines in XML examples.